Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to improve coverage #90

Merged

Conversation

bharathsreekanth
Copy link
Contributor

@bharathsreekanth bharathsreekanth commented Feb 13, 2025

Description

A few minor enhancements to improve code coverage to >= 90%.
This PR targets the pmax/v2 package only.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained at least 90% code coverage?
  • Backward compatibility is not broken

How Has This Been Tested?

Ran unit tests
PASS
coverage: 90.0% of statements
status 0
ok github.com/dell/gopowermax/v2 37.153s coverage: 90.0% of statements

@bharathsreekanth bharathsreekanth merged commit c8e75b6 into usr/spark/ut-datarace-csi-powermax Feb 13, 2025
6 of 7 checks passed
@bharathsreekanth bharathsreekanth deleted the usr/sreekb/gopmax-uts branch February 13, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants