Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added secret inheritance for release action #80

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Added secret inheritance for release action #80

merged 5 commits into from
Feb 11, 2025

Conversation

harishp8889
Copy link
Collaborator

@harishp8889 harishp8889 commented Jan 13, 2025 •
edited
Loading

Description

Added secret inheritance for release action

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1490

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained at least 90% code coverage?
  • Backward compatibility is not broken

How Has This Been Tested?

Tested against fork: https://github.com/harishp8889/test-gofsutil-automation/actions/runs/12724867954/job/35471506833

suryagupta4
suryagupta4 previously approved these changes Jan 13, 2025
View reviewed changes
donatwork
donatwork previously approved these changes Jan 22, 2025
View reviewed changes
gallacher
gallacher previously approved these changes Jan 22, 2025
View reviewed changes
santhoshatdell
santhoshatdell previously approved these changes Jan 22, 2025
View reviewed changes
@santhoshatdell santhoshatdell mentioned this pull request Feb 10, 2025
Open
4 tasks
@santhoshatdell santhoshatdell merged commit a43ea82 into main Feb 11, 2025
8 checks passed
@santhoshatdell santhoshatdell deleted the secret-inheritance branch February 11, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatwork donatwork donatwork approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

@gallacher gallacher gallacher left review comments

@suryagupta4 suryagupta4 suryagupta4 left review comments

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harishp8889 @donatwork @gallacher @suryagupta4 @santhoshatdell