Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds File System metrics and its test scenarios #60

Merged
merged 3 commits into from
May 14, 2024
Merged

Adds File System metrics and its test scenarios #60

merged 3 commits into from
May 14, 2024

Conversation

delldubey
Copy link
Collaborator

Adds unit/int test for added metric API

Description

  • Adds FileSystem Metrics
  • Unit and integration tests

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1082

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained at least 90% code coverage?
  • Backward compatibility is not broken

How Has This Been Tested?

  • Unit Tests
  • Int Tests with driver

@delldubey
Adds file System metrics
fe94e7a 
Adds unit/int test for added metric API

Signed-off-by: Utkarsh Dubey <[email protected]>
@delldubey delldubey force-pushed the fileSystemMetrics branch from db020a8 to fe94e7a Compare May 9, 2024 13:44
shanmydell
shanmydell previously approved these changes May 9, 2024
View reviewed changes
@shanmydell
Copy link
Collaborator

@delldubey : Please fix security and linting errors.

@delldubey delldubey force-pushed the fileSystemMetrics branch 3 times, most recently from eeab9d0 to fe94e7a Compare May 13, 2024 10:12
@delldubey delldubey force-pushed the fileSystemMetrics branch from 2903ab9 to e73efaa Compare May 13, 2024 17:36
@delldubey
Copy link
Collaborator Author

@delldubey : Please fix security and linting errors.

Fixed.

@boyamurthy boyamurthy merged commit 0b464a1 into main May 14, 2024
5 checks passed
@shanmydell shanmydell deleted the fileSystemMetrics branch October 16, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanmydell shanmydell shanmydell approved these changes

@boyamurthy boyamurthy boyamurthy approved these changes

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@tssushma tssushma Awaiting requested review from tssushma

@nidtara nidtara Awaiting requested review from nidtara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delldubey @shanmydell @boyamurthy