Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for file interface module #41

Merged
merged 21 commits into from
Jan 25, 2024

Conversation

trisha-dell
Copy link
Contributor

@trisha-dell trisha-dell commented Jan 17, 2024

Description

Support for file interface module.

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Functional testing
  • Unit testing

@meenakshidembi691
Copy link
Contributor

Are info file updation requiredfor this module.

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@meenakshidembi691
Copy link
Contributor

Run E2E

@Bhavneet-Sharma
Copy link
Contributor

Please update the https://github.com/dell/ansible-powerstore/blob/main/playbooks/modules/info.yml with new changes those have introduced.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (1c36360) 88.59% compared to head (2f83a3b) 89.02%.

Files Patch % Lines
plugins/modules/file_dns.py 88.48% 6 Missing and 13 partials ⚠️
plugins/modules/file_nis.py 88.19% 6 Missing and 13 partials ⚠️
plugins/modules/smb_server.py 90.14% 6 Missing and 8 partials ⚠️
plugins/modules/file_interface.py 91.09% 6 Missing and 7 partials ⚠️
plugins/modules/nfs_server.py 90.71% 6 Missing and 7 partials ⚠️
...odule_utils/storage/dell/libraries/provisioning.py 72.41% 6 Missing and 2 partials ⚠️
...le_utils/storage/dell/libraries/powerstore_base.py 93.93% 0 Missing and 2 partials ⚠️
...sts/unit/plugins/module_utils/mock_file_dns_api.py 95.45% 0 Missing and 1 partial ⚠️
...it/plugins/module_utils/mock_file_interface_api.py 95.83% 0 Missing and 1 partial ⚠️
...sts/unit/plugins/module_utils/mock_file_nis_api.py 95.45% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   88.59%   89.02%   +0.42%     
==========================================
  Files         109      126      +17     
  Lines       14765    16171    +1406     
  Branches     1757     1925     +168     
==========================================
+ Hits        13081    14396    +1315     
- Misses       1121     1156      +35     
- Partials      563      619      +56     
Flag Coverage Δ
units 89.02% <93.57%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

felixs88
felixs88 previously approved these changes Jan 25, 2024
@trisha-dell trisha-dell dismissed stale reviews from felixs88 and Bhavneet-Sharma via 47f49f7 January 25, 2024 08:47
@Bhavneet-Sharma Bhavneet-Sharma merged commit 36b4447 into main Jan 25, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants