Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alert_rule_reg_fix #159

Merged
merged 2 commits into from
Feb 19, 2025
Merged

alert_rule_reg_fix #159

merged 2 commits into from
Feb 19, 2025

Conversation

Saksham-Nautiyal
Copy link
Contributor

@Saksham-Nautiyal Saksham-Nautiyal commented Feb 18, 2025

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.25%. Comparing base (79c8483) to head (f2ee0f8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/alert_rule.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files         145      145           
  Lines       16105    16105           
  Branches     2305     2305           
=======================================
  Hits        13892    13892           
  Misses       1543     1543           
  Partials      670      670           
Flag Coverage Δ
units 86.25% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

ShivamSh3
ShivamSh3 previously approved these changes Feb 18, 2025
sachin-apa
sachin-apa previously approved these changes Feb 18, 2025
trisha-dell
trisha-dell previously approved these changes Feb 18, 2025
@trisha-dell trisha-dell merged commit 5f7a55f into main Feb 19, 2025
19 checks passed
@trisha-dell trisha-dell deleted the reg_fix/alert_rule branch February 19, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants