Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fix for Settings and Snapshot module #156

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

trisha-dell
Copy link
Collaborator

@trisha-dell trisha-dell commented Feb 11, 2025

Description

Adding fix for Settings and Snapshot module

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test
  • Functional Test

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.40%. Comparing base (61ea1d4) to head (9d3d8da).

Files with missing lines Patch % Lines
plugins/modules/snapshot.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   86.40%   86.40%   -0.01%     
==========================================
  Files         145      145              
  Lines       16068    16069       +1     
  Branches     2298     2299       +1     
==========================================
  Hits        13884    13884              
  Misses       1518     1518              
- Partials      666      667       +1     
Flag Coverage Δ
units 86.40% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@trisha-dell trisha-dell merged commit a39967a into main Feb 12, 2025
19 checks passed
@trisha-dell trisha-dell deleted the BugFix_ECS02A-147-148 branch February 12, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants