Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alert_rule] added all functionality in alert_rule #154

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

Saksham-Nautiyal
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.25%. Comparing base (457b246) to head (0a53991).

Files with missing lines Patch % Lines
plugins/modules/alert_rule.py 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   86.27%   86.25%   -0.02%     
==========================================
  Files         145      145              
  Lines       16095    16105      +10     
  Branches     2303     2305       +2     
==========================================
+ Hits        13886    13892       +6     
- Misses       1541     1543       +2     
- Partials      668      670       +2     
Flag Coverage Δ
units 86.25% <63.63%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@rajshekarp87
Copy link
Contributor

Update author name and copyright

@rajshekarp87 rajshekarp87 merged commit 3d43450 into main Feb 13, 2025
19 checks passed
@rajshekarp87 rajshekarp87 deleted the defect_fix/alert_rule branch February 13, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

7 participants