[core] remove old option --clean

It's a legacy command which shouldn't be needed after DataDog#1435

Author: degemer

agent.py

@@ -247,12 +247,7 @@ def main():
         deprecate_old_command_line_tools()
 
     if command in COMMANDS_AGENT:
-        pid_file = PidFile('dd-agent')
-
-        if options.clean:
-            pid_file.clean()
-
-        agent = Agent(pid_file.get_path(), autorestart)
+        agent = Agent(PidFile('dd-agent').get_path(), autorestart)
 
     if command in START_COMMANDS:
         log.info('Agent version %s' % get_version())

config.py

@@ -73,8 +73,6 @@ def get_parsed_args():
                         dest='autorestart')
     parser.add_option('-d', '--dd_url', action='store', default=None,
                         dest='dd_url')
-    parser.add_option('-c', '--clean', action='store_true', default=False,
-                        dest='clean')
     parser.add_option('-u', '--use-local-forwarder', action='store_true',
                         default=False, dest='use_forwarder')
     parser.add_option('-n', '--disable-dd', action='store_true', default=False,
@@ -89,7 +87,6 @@ def get_parsed_args():
         # Ignore parse errors
         options, args = Values({'autorestart': False,
                                 'dd_url': None,
-                                'clean': False,
                                 'disable_dd':False,
                                 'use_forwarder': False}), []
     return options, args

dogstatsd.py

@@ -439,8 +439,7 @@ def main(config_path=None):
 
     if not args or args[0] in COMMANDS_START_DOGSTATSD:
         reporter, server, cnf = init(config_path, use_watchdog=True, use_forwarder=opts.use_forwarder, args=args)
-        pid_file = PidFile('dogstatsd')
-        daemon = Dogstatsd(pid_file.get_path(), server, reporter,
+        daemon = Dogstatsd(PidFile('dogstatsd').get_path(), server, reporter,
                            cnf.get('autorestart', False))
 
     # If no args were passed in, run the server in the foreground.

tests/checks/integration/test_tomcat.py

@@ -12,7 +12,6 @@
 from aggregator import MetricsAggregator
 from dogstatsd import Server
 from jmxfetch import JMXFetch
-from utils.pidfile import PidFile
 
 STATSD_PORT = 8126
 
@@ -43,7 +42,6 @@ class TestTomcat(unittest.TestCase):
     def setUp(self):
         aggregator = MetricsAggregator("test_host")
         self.server = Server(aggregator, "localhost", STATSD_PORT)
-        pid_file = PidFile('dogstatsd')
         self.reporter = DummyReporter(aggregator)
 
         self.t1 = threading.Thread(target=self.server.start)
@@ -64,7 +62,7 @@ def test_tomcat_metrics(self):
         while self.reporter.metrics is None:
             time.sleep(1)
             count += 1
-            if count > 25:ga
+            if count > 25:
                 raise Exception("No metrics were received in 25 seconds")
 
         metrics = self.reporter.metrics

tests/checks/mock/test_java_jmx.py

@@ -101,7 +101,6 @@ class JMXTestCase(unittest.TestCase):
     def setUp(self):
         aggregator = MetricsAggregator("test_host")
         self.server = Server(aggregator, "localhost", STATSD_PORT)
-        pid_file = PidFile('dogstatsd')
         self.reporter = DummyReporter(aggregator)
 
         self.t1 = threading.Thread(target=self.server.start)

tests/checks/mock/test_solr.py

@@ -12,7 +12,6 @@
 from dogstatsd import Server
 from jmxfetch import JMXFetch
 from tests.checks.common import Fixtures
-from utils.pidfile import PidFile
 
 STATSD_PORT = 8127
 
@@ -43,7 +42,6 @@ class JMXTestCase(unittest.TestCase):
     def setUp(self):
         aggregator = MetricsAggregator("test_host")
         self.server = Server(aggregator, "localhost", STATSD_PORT)
-        pid_file = PidFile('dogstatsd')
         self.reporter = DummyReporter(aggregator)
 
         self.t1 = threading.Thread(target=self.server.start)

tests/checks/mock/test_system_core.py

@@ -1,7 +1,7 @@
 import mock
 import psutil
 
-from tests.common import AgentCheckTest
+from tests.checks.common import AgentCheckTest
 from utils.platform import Platform
 
 if Platform.is_mac():

win32/agent.py

@@ -51,7 +51,6 @@ def __init__(self, args):
         opts, args = Values({
             'autorestart': False,
             'dd_url': None,
-            'clean': False,
             'use_forwarder': True,
             'disabled_dd': False
         }), []