Refactor code

* Use Rspec shared examples for sorting specs.
* Fix the insertion sort duplicate loop.

Author: deepakhb2

lib/Algorithm-Sorting/bubble_sort.rb

@@ -8,7 +8,7 @@ class << self
     # count: Counter to terminate recursion starts from 1
     # swap: Optimise algoritm to check if array is already sorted.
     #
-    def recursive(values, count, swap)
+    def recursive(values, count=1, swap=false)
       len = values.size
       if(!swap && len > 0 && count <= len)
         i = 0

lib/Algorithm-Sorting/insertion_sort.rb

@@ -1,7 +1,7 @@
 class InsertionSort
   class << self
     # Sort using recursion
-    def recursive(values, i=0)
+    def recursive(values, i=1)
       return values if i >= values.size
 
       (0...i).each do |j|
@@ -13,7 +13,7 @@ def recursive(values, i=0)
     # Sort using loop
     def non_recursive(values)
       n = values.size
-      (0...n).each do |i|
+      (1...n).each do |i|
         (0...i).each do |j|
           if(values[i] < values[j])
             values[j], values[i] = values[i], values[j]

spec/Algorithm-Sorting/bubble_sort_spec.rb

@@ -1,15 +1,5 @@
-describe BubbleSort do
-  let(:values) { [5,2,4,7,1,3,6] }
-
-  describe '#recursive' do
-    it 'sort using recursive technique' do
-      expect(described_class.recursive(values, 1, false)).to eq([1,2,3,4,5,6,7])
-    end
-  end
+require_relative './shared_example.rb'
 
-  describe '#non_recursive' do
-    it 'sort using non-recursive technique' do
-      expect(described_class.non_recursive(values)).to eq([1,2,3,4,5,6,7])
-    end
-  end
+describe BubbleSort do
+  include_examples "sorting"
 end

spec/Algorithm-Sorting/insertion_sort_spec.rb

@@ -1,15 +1,5 @@
-describe InsertionSort do
-  let(:values) { [5,2,4,7,1,3,6] }
-
-  describe '#recursive' do
-    it 'sort using recursive technique' do
-      expect(described_class.recursive(values)).to eq([1,2,3,4,5,6,7])
-    end
-  end
+require_relative './shared_example.rb'
 
-  describe '#non_recursive' do
-    it 'sort using non-recursive technique' do
-      expect(described_class.non_recursive(values)).to eq([1,2,3,4,5,6,7])
-    end
-  end
+describe InsertionSort do
+  include_examples "sorting"
 end

spec/Algorithm-Sorting/shared_example.rb

@@ -0,0 +1,15 @@
+shared_examples "sorting" do
+  let(:values) { [5,2,4,7,1,3,6] }
+
+  describe '#recursive' do
+    it 'sort using recursive technique' do
+      expect(described_class.recursive(values)).to eq([1,2,3,4,5,6,7])
+    end
+  end
+
+  describe '#non_recursive' do
+    it 'sort using non-recursive technique' do
+      expect(described_class.non_recursive(values)).to eq([1,2,3,4,5,6,7])
+    end
+  end
+end