Fix compiler warnings (#285)

Author: debasishg

build.sbt

@@ -25,8 +25,8 @@ lazy val coreSettings = commonSettings ++ Seq(
   name := "RedisClient",
   libraryDependencies ++= Seq(
     "org.apache.commons"      %  "commons-pool2"           % "2.8.0",
-    "org.slf4j"               %  "slf4j-api"               % "1.7.29",
-    "org.slf4j"               %  "slf4j-log4j12"           % "1.7.29"      % "provided",
+    "org.slf4j"               %  "slf4j-api"               % "1.7.32",
+    "org.slf4j"               %  "slf4j-log4j12"           % "1.7.32"      % "provided",
     "log4j"                   %  "log4j"                   % "1.2.17"      % "provided",
     "org.scalatest"           %% "scalatest"               % "3.1.0"       % "test"
   ) ++

src/test/scala/com/redis/PoolSpec.scala

@@ -1,12 +1,14 @@
 package com.redis
 
 import com.redis.common.RedisDocker
-import org.scalatest.{BeforeAndAfterEach, FunSpec, Matchers}
+import org.scalatest.BeforeAndAfterEach
+import org.scalatest.funspec.AnyFunSpec
+import org.scalatest.matchers.should.Matchers
 
 import scala.concurrent._
 import scala.concurrent.duration._
 
-class PoolSpec extends FunSpec
+class PoolSpec extends AnyFunSpec
                with Matchers
                with BeforeAndAfterEach
                with RedisDocker {
@@ -27,7 +29,7 @@ class PoolSpec extends FunSpec
 
   override def afterAll(): Unit = {
     clients.withClient{ client => client.disconnect }
-    clients.close
+    clients.close()
     super.afterAll()
   }
 

src/test/scala/com/redis/PubSubSpec.scala

@@ -1,9 +1,10 @@
 package com.redis
 
 import com.redis.common.RedisDocker
-import org.scalatest.{FunSpec, Matchers}
+import org.scalatest.funspec.AnyFunSpec
+import org.scalatest.matchers.should.Matchers
 
-class PubSubSpec extends FunSpec
+class PubSubSpec extends AnyFunSpec
                  with Matchers
                  with RedisDocker {
 
@@ -37,7 +38,7 @@ class PubSubSpec extends FunSpec
               // exit will unsubscribe from all channels and stop subscription service
               case "exit" =>
                 println("unsubscribe all ..")
-                r.unsubscribe
+                r.unsubscribe()
 
               // message "+x" will subscribe to channel x
               case x if x startsWith "+" =>

src/test/scala/com/redis/SSLSpec.scala

@@ -4,9 +4,10 @@ import java.security.cert.X509Certificate
 import org.apache.http.ssl.{SSLContexts, TrustStrategy}
 
 import com.redis.common.RedisDockerSSL
-import org.scalatest.{FunSpec, Matchers}
+import org.scalatest.funspec.AnyFunSpec
+import org.scalatest.matchers.should.Matchers
 
-class SSLSpec extends FunSpec with Matchers with RedisDockerSSL {
+class SSLSpec extends AnyFunSpec with Matchers with RedisDockerSSL {
 
   // Our certificate on the test server is self-signed, which will be
   // rejected by the default SSLContext. This SSLContext is therefore

src/test/scala/com/redis/SerializationSpec.scala

@@ -2,10 +2,11 @@ package com.redis
 
 import com.redis.common.IntSpec
 import com.redis.serialization._
-import org.scalatest.{FunSpec, Matchers}
+import org.scalatest.funspec.AnyFunSpec
+import org.scalatest.matchers.should.Matchers
 
 
-class SerializationSpec extends FunSpec
+class SerializationSpec extends AnyFunSpec
                      with Matchers
                      with IntSpec {
 

src/test/scala/com/redis/WatchSpec.scala

@@ -1,11 +1,12 @@
 package com.redis
 
 import com.redis.common.RedisDocker
-import org.scalatest.{FunSpec, Matchers}
+import org.scalatest.funspec.AnyFunSpec
+import org.scalatest.matchers.should.Matchers
 
 import scala.concurrent.Future
 
-class WatchSpec extends FunSpec
+class WatchSpec extends AnyFunSpec
                      with Matchers
                      with RedisDocker {
 
@@ -33,7 +34,7 @@ class WatchSpec extends FunSpec
 
       p2.futureValue should equal(true)
       p1.futureValue should equal(None)
-      clients.close
+      clients.close()
     }
   }
 }

src/test/scala/com/redis/cluster/ReconnectableSpec.scala

@@ -72,7 +72,7 @@ class ReconnectableSpec extends AnyFunSpec with GivenWhenThen
   }
 
   def waitForCluster(expected: List[ClusterNode] => Boolean, remaining: Int = 10,
-                     p: Promise[Boolean] = Promise[Boolean]): Future[Boolean] =
+                     p: Promise[Boolean] = Promise[Boolean]()): Future[Boolean] =
     if (expected(r.listServers)) {
       p.success(true).future
     } else if (remaining > 0) {

src/test/scala/com/redis/common/IntClusterSpec.scala

@@ -20,12 +20,12 @@ trait IntClusterSpec extends BeforeAndAfterEach with RedisDockerCluster {
     format(key)
   }
 
-  override def afterAll: Unit = {
+  override def afterAll(): Unit = {
     r.close()
     super.afterAll()
   }
 
-  override def afterEach: Unit = {
+  override def afterEach(): Unit = {
     r.flushall
     super.afterEach()
   }

src/test/scala/com/redis/common/IntSpec.scala

@@ -8,12 +8,12 @@ trait IntSpec extends BeforeAndAfterEach with RedisDocker {
 
   protected def r: BaseApi with AutoCloseable
 
-  override def afterAll: Unit = {
+  override def afterAll(): Unit = {
     r.close()
     super.afterAll()
   }
 
-  override def afterEach: Unit = {
+  override def afterEach(): Unit = {
     r.flushall
     super.afterEach()
   }

src/test/scala/com/redis/common/StringTypeData.scala

@@ -1,7 +1,8 @@
 package com.redis.common
 
 import com.redis.api.{BaseApi, StringApi}
-import org.scalatest.{GivenWhenThen, Informing, Matchers, Suite}
+import org.scalatest.{GivenWhenThen, Informing, Suite}
+import org.scalatest.matchers.should.Matchers
 
 trait StringTypeData extends IntSpec with Matchers with GivenWhenThen {
   that: Suite with Informing =>