# updated transcoder and dockerfile. transcoder accepts audio_codec and video_codec

Author: ddragosd

Dockerfile

@@ -1,6 +1,6 @@
 # ffmpeg live transcoder
 #
-# VERSION               2.4.3-1.1
+# VERSION               2.4.3
 #
 # From https://trac.ffmpeg.org/wiki/CompilationGuide/Centos
 #
@@ -15,4 +15,6 @@ RUN mkdir -p /var/log/streamkit/
 # forward request and error logs to docker log collector
 RUN ln -sf /dev/stdout /var/log/streamkit/*
 
+VOLUME /var/log/streamkit/
+
 ENTRYPOINT ["python", "/usr/local/live-transcoder/live_transcoder.py"]

README.md

@@ -22,6 +22,15 @@ Usage:
 ```
     docker run ddragosd/ffmpeg-live-transcoder:2.4.3-1.1 \
         --user-config-json "`cat /usr/local/live-transcoder-config.json`"
+
+```
+
+To specify a log file:
+
+```
+    docker run -v /var/log/streamkit:/var/log/streamkit ddragosd/ffmpeg-live-transcoder:2.4.3-1.1 \
+        --user-config-json "`cat /usr/local/live-transcoder-config.json`" \
+        --log-file "/var/log/streamkit/ffmpeg-live-transcoding.log"
 ```
 
 

default_config.json

@@ -7,70 +7,94 @@
         {
             "width": 1440,
             "height": 1080,
-            "bitrate": 2200
+            "bitrate": 2200,
+            "audio_codec": "copy",
+            "video_codec": "libx264"
         },
         {
             "width": 960,
             "height": 720,
-            "bitrate": 1000
+            "bitrate": 1000,
+            "audio_codec": "copy",
+            "video_codec": "libx264"
         },
         {
             "width": 640,
             "height": 480,
-            "bitrate": 600
+            "bitrate": 600,
+            "audio_codec": "copy",
+            "video_codec": "libx264"
         },
         {
-            "width": 640,
+            "width": 480,
             "height": 360,
             "bitrate": 300,
-            "audio_bitrate": 96
+            "audio_codec": "libfdk_aac",
+            "audio_bitrate": 96,
+            "video_codec": "libx264"
         },
         {
             "width": 320,
             "height": 240,
             "bitrate": 150,
-            "audio_bitrate": 96
+            "audio_codec": "libfdk_aac",
+            "audio_bitrate": 96,
+            "video_codec": "libx264"
         },
         {
             "width": 214,
             "height": 160,
             "bitrate": 64,
-            "audio_bitrate": 48
+            "audio_codec": "libfdk_aac",
+            "audio_bitrate": 48,
+            "video_codec": "libx264"
         }
     ],
     "hd_streams": [
         {
             "width": 1920,
             "height": 1080,
-            "bitrate": 2400
+            "bitrate": 2400,
+            "audio_codec": "copy",
+            "video_codec": "libx264"
         },
         {
             "width": 1280,
             "height": 720,
-            "bitrate": 1200
+            "bitrate": 1200,
+            "audio_codec": "copy",
+            "video_codec": "libx264"
         },
         {
             "width": 854,
             "height": 480,
-            "bitrate": 600
+            "bitrate": 600,
+            "audio_codec": "copy",
+            "video_codec": "libx264"
         },
         {
             "width": 640,
             "height": 360,
             "bitrate": 300,
-            "audio_bitrate": 96
+            "audio_codec": "libfdk_aac",
+            "audio_bitrate": 96,
+            "video_codec": "libx264"
         },
         {
             "width": 426,
             "height": 240,
             "bitrate": 150,
-            "audio_bitrate": 96
+            "audio_codec": "libfdk_aac",
+            "audio_bitrate": 96,
+            "video_codec": "libx264"
         },
         {
             "width": 284,
             "height": 160,
             "bitrate": 10,
-            "audio_bitrate": 48
+            "audio_codec": "libfdk_aac",
+            "audio_bitrate": 48,
+            "video_codec": "libx264"
         }
     ],
     "max_retries": 90,

live_transcoder.py

@@ -18,7 +18,7 @@
 
 
 class LiveTranscoder:
-    def __init__(self):
+    def __init__(self, log_filename):
         # initialize config
         # Initialize Blank Configs
         self.config = ConfigObj()
@@ -27,14 +27,6 @@ def __init__(self):
         self.log = logging.getLogger("LiveTranscoder")
         self.log.setLevel(logging.DEBUG)
         log_format = logging.Formatter("%(asctime)s %(name)s [%(levelname)s]: %(message)s")
-        log_filename = "/var/log/streamkit/live_transcoder_%s.log" % \
-                       (datetime.datetime.fromtimestamp(time.time()).strftime('%Y-%m-%d_%H_%M_%S'))
-        try:
-            file_handler = logging.FileHandler(log_filename)
-            file_handler.setFormatter(log_format)
-            self.log.addHandler(file_handler)
-        except:
-            pass
 
         # when executing the collector separately, log directly on the output stream
         stream_handler = logging.StreamHandler()
@@ -43,6 +35,18 @@ def __init__(self):
 
         logging.getLogger('LiveTranscoder').addHandler(stream_handler)
 
+        try:
+            file_handler = logging.FileHandler(log_filename)
+            file_handler.setFormatter(log_format)
+            self.log.addHandler(file_handler)
+            self.log.info("Log Handler added for file [%s]", log_filename)
+        except Exception, e:
+            self.log.warn("Could not create logfile [%s]")
+            self.log.exception(e)
+            pass
+
+
+
     def _get_default_config(self, file_name='/etc/live-transcoder/default_config.json'):
         config_file = open(file_name)
         cfg = json.load(config_file)
@@ -51,6 +55,8 @@ def _get_default_config(self, file_name='/etc/live-transcoder/default_config.jso
         return cfg
 
     def _get_user_config(self, user_config_json):
+        if not user_config_json:
+            return None
         try:
             self.log.info("Loading user-data: %s", user_config_json)
             config = json.loads(user_config_json)
@@ -112,21 +118,21 @@ def _getTranscodingCmd(self, config):
         sub_commands = []
         for quality in bitrates:
             if int(quality["bitrate"]) <= int(config["bitrate"]):
-                sub_cmd_template = """-f flv -c:a copy -c:v libx264 -s %dx%d -x264opts bitrate=%d -rtmp_playpath %s -rtmp_app %s %s """
-                sub_cmd_template_audio = """-f flv -c:a copy -b:a %dk -c:v libx264 -s %dx%d -x264opts bitrate=%d -rtmp_playpath %s -rtmp_app %s %s """
+                sub_cmd_template = """-f flv -c:a copy -c:v %s -s %dx%d -x264opts bitrate=%d -rtmp_playpath %s -rtmp_app %s %s """
+                sub_cmd_template_audio = """-f flv -c:a %s -b:a %dk -c:v libx264 -s %dx%d -x264opts bitrate=%d -rtmp_playpath %s -rtmp_app %s %s """
                 target_stream = config["target_stream"]
                 target_stream = target_stream.replace("$width", str(quality["width"]))
                 target_stream = target_stream.replace("$height", str(quality["height"]))
                 target_stream = target_stream.replace("$bitrate", str(quality["bitrate"]))
                 sub_cmd = ''
-                if "audio_bitrate" in quality:
+                if "audio_bitrate" in quality and "audio_codec" in quality:
                     sub_cmd = sub_cmd_template_audio % (
-                        quality["audio_bitrate"], quality["width"], quality["height"], quality["bitrate"],
+                        quality["audio_codec"], quality["audio_bitrate"], quality["width"], quality["height"], quality["bitrate"],
                         target_stream,
                         config["target_app"], config["target_host"] )
                 else:
                     sub_cmd = sub_cmd_template % (
-                        quality["width"], quality["height"], quality["bitrate"], target_stream,
+                        quality["video_codec"],quality["width"], quality["height"], quality["bitrate"], target_stream,
                         config["target_app"], config["target_host"] )
                 cmd = cmd + sub_cmd
         return cmd
@@ -158,28 +164,34 @@ def startLiveTranscoding(self, user_config_json):
 
         max_retries = int(self.config["max_retries"])
         max_retries_delay = int(self.config["max_retries_delay_sec"])
+        cmd_exit_code = None
         for i in range(1, max_retries + 1):
             self.config = self._updateStreamMetadataInConfig(self.config)
-
-            cmd = self._getTranscodingCmd(self.config)
-            self.log.info("Executing FFmpeg command:\n%s\n", cmd)
-
-            # start live transcoding
-            cmd_args = cmd.split()
-            self.log.info("Running command. (run=%d/%d)", i, max_retries)
-            r = self._runTranscodingCommand(cmd_args)
-            self.log.info("Transcoding command stopped. (run=%d/%d). Code=%d", i, max_retries, r)
+            if "bitrate" in self.config and "width" in self.config and "height" in self.config:
+                cmd = self._getTranscodingCmd(self.config)
+                self.log.info("Executing FFmpeg command:\n%s\n", cmd)
+
+                # start live transcoding
+                cmd_args = cmd.split()
+                self.log.info("Running command. (run=%d/%d)", i, max_retries)
+                cmd_exit_code = self._runTranscodingCommand(cmd_args)
+            self.log.info("Transcoding command stopped. (run=%d/%d). Code=%d", i, max_retries, (cmd_exit_code or -777))
             time.sleep(max_retries_delay)
 
         self.log.info("Live-Transcoder has completed ! You can now shutdown the instance.")
 
 
-transcoder = LiveTranscoder()
+
 user_config_json = None
+log_file = "/var/log/streamkit/live_transcoder_%s.log" % \
+           (datetime.datetime.fromtimestamp(time.time()).strftime('%Y-%m-%d_%H_%M_%S'))
 if __name__ == '__main__':
     parser = argparse.ArgumentParser()
     parser.add_argument('-u', '--user-config-json', dest='user_config_json')
+    parser.add_argument('-l', '--log-file', dest='log_file')
     args = parser.parse_args()
     user_config_json = args.user_config_json
+    log_file = args.log_file or log_file
 
+transcoder = LiveTranscoder(log_file)
 transcoder.startLiveTranscoding(user_config_json)