onRequestSuccess never called, although cached.

[anodynos]

Sometimes onRequestSuccess is never called after pressing Go.

The 'Already cached' Toast and the indeterminate progress bar both appear, but it seems as if onRequestSuccess is never called.

This especially occurs if you press Go repeatedly or right after it refreshes from a previous request - but it can happen anytime.

I tested SpiceAnnotations on two real devices [Galaxy Tab Pro 3 v4.4.2 & LG P880 v4.4.4 cyanogenmod11] with the exact same behavior.

I took some logs which show that DefaultRequestListenerNotifier at the end of the process is never called, but no error is ever thrown:

a) Normal execution

D//SpiceManager.java:1245﹕ 20:02:13.836 Thread-8514 Waiting for service to be bound.
D//SpiceManager.java:1252﹕ 20:02:13.837 Thread-8514 Bound ok.
D//SpiceManager.java:489﹕ 20:02:13.844 main adding request to request queue
D//SpiceManager.java:286﹕ 20:02:13.851 SpiceManagerThread 3 Sending request to service : CachedSpiceRequest
D//RequestProcessor.java:63﹕ 20:02:13.853 SpiceManagerThread 3 Adding request to queue 1103815664: CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518] size is 30
D//RequestProcessor.java:85﹕ 20:02:13.856 SpiceManagerThread 3 Adding entry for type class com.github.ddekanski.spiceannotations.model.FacebookPage and cacheKey Goyello.
D//RequestProgressManager.java:61﹕ 20:02:13.857 SpiceManagerThread 3 Request was added to queue.
D//SpiceServiceListenerNotifier.java:146﹕ 20:02:13.859 SpiceManagerThread 3 Message queue is Handler (android.os.Handler) {41cbc430}
D//RequestProgressManager.java:82﹕ 20:02:13.861 SpiceManagerThread 3 Sending progress READING_FROM_CACHE
D//SpiceServiceListenerNotifier.java:146﹕ 20:02:13.863 SpiceManagerThread 3 Message queue is Handler (android.os.Handler) {41cbc430}
V//SpiceService.java:506﹕ 20:02:13.869 SpiceManagerThread 3 Pending requests : 43
V//SpiceService.java:508﹕ 20:02:13.870 SpiceManagerThread 3 Stop foreground
D//DefaultRequestRunner.java:83﹕ 20:02:13.871 Thread-8500 Processing request : CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518]
D//DefaultRequestRunner.java:97﹕ 20:02:13.872 Thread-8500 Loading request from cache : CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518]
D//RequestProgressManager.java:82﹕ 20:02:13.873 Thread-8500 Sending progress READING_FROM_CACHE
D//SpiceServiceListenerNotifier.java:146﹕ 20:02:13.874 Thread-8500 Message queue is Handler (android.os.Handler) {41cbc430}
D//DefaultRequestRunner.java:103﹕ 20:02:13.876 Thread-8500 Request loaded from cache : CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518] result=com.github.ddekanski.spiceannotations.model.FacebookPage@4229c1e8
D//RequestProgressManager.java:82﹕ 20:02:13.877 Thread-8500 Sending progress COMPLETE
D//SpiceServiceListenerNotifier.java:146﹕ 20:02:13.878 Thread-8500 Message queue is Handler (android.os.Handler) {41cbc430}
D//SpiceServiceListenerNotifier.java:146﹕ 20:02:13.879 Thread-8500 Message queue is Handler (android.os.Handler) {41cbc430}
V//RequestProgressManager.java:161﹕ 20:02:13.879 Thread-8500 Removing CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518]  size is 31
D//SpiceServiceListenerNotifier.java:146﹕ 20:02:13.880 Thread-8500 Message queue is Handler (android.os.Handler) {41cbc430}
D//DefaultRequestRunner.java:295﹕ 20:02:13.882 Thread-8500 It tooks 11 ms to process request CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518].
D//SpiceServiceListenerNotifier.java:175﹕ 20:02:13.890 main Processing request added: CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518]
V//DefaultRequestListenerNotifier.java:131﹕ 20:02:13.906 main Notifying 1 listeners of progress com.octo.android.robospice.request.listener.RequestProgress@41f6efa8
V//DefaultRequestListenerNotifier.java:131﹕ 20:02:13.907 main Notifying 1 listeners of progress com.octo.android.robospice.request.listener.RequestProgress@41f8c620
V//DefaultRequestListenerNotifier.java:131﹕ 20:02:13.908 main Notifying 1 listeners of progress com.octo.android.robospice.request.listener.RequestProgress@41da94d8
V//DefaultRequestListenerNotifier.java:166﹕ 20:02:13.909 main Notifying 1 listeners of request success
V//DefaultRequestListenerNotifier.java:172﹕ 20:02:13.910 main Notifying MainActivity_

b) Faulty execution

D//SpiceManager.java:1245﹕ 19:59:07.127 Thread-8509 Waiting for service to be bound.
D//SpiceManager.java:1252﹕ 19:59:07.176 Thread-8509 Bound ok.
D//SpiceManager.java:489﹕ 19:59:07.203 main adding request to request queue
D//SpiceManager.java:286﹕ 19:59:07.205 SpiceManagerThread 2 Sending request to service : CachedSpiceRequest
D//RequestProcessor.java:63﹕ 19:59:07.207 SpiceManagerThread 2 Adding request to queue 1103815664: CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518] size is 27
D//RequestProcessor.java:85﹕ 19:59:07.208 SpiceManagerThread 2 Adding entry for type class com.github.ddekanski.spiceannotations.model.FacebookPage and cacheKey Goyello.
D//RequestProgressManager.java:61﹕ 19:59:07.210 SpiceManagerThread 2 Request was added to queue.
D//SpiceServiceListenerNotifier.java:146﹕ 19:59:07.239 SpiceManagerThread 2 Message queue is Handler (android.os.Handler) {41cbc430}
D//SpiceServiceListenerNotifier.java:175﹕ 19:59:07.241 main Processing request added: CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518]
D//RequestProgressManager.java:82﹕ 19:59:07.244 SpiceManagerThread 2 Sending progress READING_FROM_CACHE
D//SpiceServiceListenerNotifier.java:146﹕ 19:59:07.255 SpiceManagerThread 2 Message queue is Handler (android.os.Handler) {41cbc430}
V//DefaultRequestListenerNotifier.java:131﹕ 19:59:07.257 main Notifying 1 listeners of progress com.octo.android.robospice.request.listener.RequestProgress@41b26178
D//DefaultRequestRunner.java:83﹕ 19:59:07.258 Thread-8500 Processing request : CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518]
V//SpiceService.java:506﹕ 19:59:07.260 SpiceManagerThread 2 Pending requests : 39
D//DefaultRequestRunner.java:97﹕ 19:59:07.274 Thread-8500 Loading request from cache : CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518]
V//SpiceService.java:508﹕ 19:59:07.274 SpiceManagerThread 2 Stop foreground
D//RequestProgressManager.java:82﹕ 19:59:07.277 Thread-8500 Sending progress READING_FROM_CACHE
D//SpiceServiceListenerNotifier.java:146﹕ 19:59:07.289 Thread-8500 Message queue is Handler (android.os.Handler) {41cbc430}
D//DefaultRequestRunner.java:103﹕ 19:59:07.293 Thread-8500 Request loaded from cache : CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518] result=com.github.ddekanski.spiceannotations.model.FacebookPage@41e62cf0
D//RequestProgressManager.java:82﹕ 19:59:07.306 Thread-8500 Sending progress COMPLETE
D//SpiceServiceListenerNotifier.java:146﹕ 19:59:07.307 Thread-8500 Message queue is Handler (android.os.Handler) {41cbc430}
D//SpiceServiceListenerNotifier.java:146﹕ 19:59:07.309 Thread-8500 Message queue is Handler (android.os.Handler) {41cbc430}
V//RequestProgressManager.java:161﹕ 19:59:07.310 Thread-8500 Removing CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518]  size is 28
D//SpiceServiceListenerNotifier.java:146﹕ 19:59:07.323 Thread-8500 Message queue is Handler (android.os.Handler) {41cbc430}
D//DefaultRequestRunner.java:295﹕ 19:59:07.325 Thread-8500 It tooks 65 ms to process request CachedSpiceRequest [requestCacheKey=Goyello, cacheDuration=0, spiceRequest=com.github.ddekanski.spiceannotations.controller.FacebookPageRequest_@41b30518].

[kubido]

seems you forgot to implement the spiceManager.start & spiceManager.shouldStop

 @Override
    protected void onStart() {
        spiceManager.start(this);
        super.onStart();
    }

    @Override
    protected void onStop() {
        spiceManager.shouldStop();
        super.onStop();
    }