Skip to content

Commit a8c40bb

Browse files
committed
Remove NumberBadge component
1 parent 27a1c59 commit a8c40bb

File tree

5 files changed

+17
-21
lines changed

5 files changed

+17
-21
lines changed

web/app/components/number-badge.gts

Lines changed: 0 additions & 13 deletions
This file was deleted.

web/app/components/validation-detail.gts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { LinkTo } from '@ember/routing';
22

3-
import NumberBadge from 'repository/components/number-badge';
43
import ProgressLabel from 'repository/components/progress-label';
54
import Results from 'repository/components/validation-detail/results';
65
import SubmitForm from 'repository/components/validation-detail/submit-form';
@@ -80,7 +79,12 @@ export default <template>
8079

8180
<dd>
8281
<ValidityBadge @validity={{@validation.validity}} />
83-
<NumberBadge @number={{detailsCount @validation.results}} />
82+
83+
{{#let (detailsCount @validation.results) as |count|}}
84+
{{#if count}}
85+
<span class="badge bg-secondary">{{count}}</span>
86+
{{/if}}
87+
{{/let}}
8488
</dd>
8589
</div>
8690

web/app/components/validations-table.gts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { LinkTo } from '@ember/routing';
22

33
import { notEq } from 'ember-truth-helpers';
4-
import NumberBadge from 'repository/components/number-badge';
54
import Pagination from 'repository/components/pagination';
65
import ProgressLabel from 'repository/components/progress-label';
76
import Table from 'repository/components/table';
@@ -81,7 +80,11 @@ export default <template>
8180

8281
<td>
8382
<ValidityBadge @validity={{validation.validity}} />
84-
<NumberBadge @number={{detailsCount validation.results}} />
83+
{{#let (detailsCount validation.results) as |count|}}
84+
{{#if count}}
85+
<span class="badge bg-secondary">{{count}}</span>
86+
{{/if}}
87+
{{/let}}
8588
</td>
8689

8790
<td class="position-relative">

web/app/templates/accession-renewal.gts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { fn } from '@ember/helper';
55
import { on } from '@ember/modifier';
66
import { service } from '@ember/service';
77

8-
import NumberBadge from 'repository/components/number-badge';
98
import ProgressLabel from 'repository/components/progress-label';
109
import ValidityBadge from 'repository/components/validity-badge';
1110

@@ -94,7 +93,9 @@ export default class extends Component<Signature> {
9493

9594
<dd>
9695
<ValidityBadge @validity={{@model.renewal.validity}} />
97-
<NumberBadge @number={{@model.renewal.validation_details.length}} />
96+
{{#if @model.renewal.validation_details.length}}
97+
<span class="badge bg-secondary">{{@model.renewal.validation_details.length}}</span>
98+
{{/if}}
9899
</dd>
99100
</div>
100101
</dl>

web/app/templates/accession/index.gts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import Component from '@glimmer/component';
22
import { LinkTo } from '@ember/routing';
33

44
import AccessionSummary from 'repository/components/accession-summary';
5-
import NumberBadge from 'repository/components/number-badge';
65
import ProgressLabel from 'repository/components/progress-label';
76
import ValidityBadge from 'repository/components/validity-badge';
87
import formatDate from 'repository/helpers/format-datetime';
@@ -85,7 +84,9 @@ export default class extends Component<Signature> {
8584

8685
<td>
8786
<ValidityBadge @validity={{renewal.validity}} />
88-
<NumberBadge @number={{renewal.validation_details.length}} />
87+
{{#if renewal.validation_details.length}}
88+
<span class="badge bg-secondary">{{renewal.validation_details.length}}</span>
89+
{{/if}}
8990
</td>
9091
</tr>
9192
{{/each}}

0 commit comments

Comments
 (0)