Skip to content

Commit 4528643

Browse files
authored
fix: use 258 tag for sets (#365)
Resolves #364
1 parent c6a6d11 commit 4528643

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

chain/rust/src/builders/tx_builder.rs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2287,7 +2287,7 @@ mod tests {
22872287
.checked_add(&Value::from(tx_builder.get_fee_if_set().unwrap()))
22882288
.unwrap()
22892289
);
2290-
assert_eq!(tx_builder.full_size().unwrap(), 285);
2290+
assert_eq!(tx_builder.full_size().unwrap(), 291);
22912291
assert_eq!(tx_builder.output_sizes(), vec![62, 65]);
22922292
let _final_tx = tx_builder.build(ChangeSelectionAlgo::Default, &change_addr);
22932293
// just test that it doesn't throw
@@ -2393,8 +2393,8 @@ mod tests {
23932393
tx_builder
23942394
.add_change_if_needed_for_tests(&change_addr)
23952395
.unwrap();
2396-
assert_eq!(tx_builder.min_fee(false).unwrap(), 214002);
2397-
assert_eq!(tx_builder.get_fee_if_set().unwrap(), 214002);
2396+
assert_eq!(tx_builder.min_fee(false).unwrap(), 218502);
2397+
assert_eq!(tx_builder.get_fee_if_set().unwrap(), 218502);
23982398
assert_eq!(tx_builder.get_deposit().unwrap(), 1000000);
23992399
assert_eq!(tx_builder.outputs.len(), 1);
24002400
assert_eq!(
@@ -2582,7 +2582,7 @@ mod tests {
25822582
.payment_key()
25832583
.unwrap()
25842584
};
2585-
assert_eq!(tx_builder.fee_for_input(&input).unwrap(), 69500);
2585+
assert_eq!(tx_builder.fee_for_input(&input).unwrap(), 71000);
25862586
tx_builder.add_input(input).unwrap();
25872587

25882588
let input = {
@@ -3049,7 +3049,7 @@ mod tests {
30493049
);
30503050
// The single change output contains more Coin then minimal utxo value
30513051
// But not enough to cover the additional fee for a separate output
3052-
assert_eq!(final_tx.outputs[1].amount().coin, 336);
3052+
assert_eq!(final_tx.outputs[1].amount().coin, 330);
30533053
}
30543054

30553055
#[test]
@@ -4023,13 +4023,13 @@ mod tests {
40234023
.unwrap(),
40244024
)
40254025
.unwrap();
4026-
assert_eq!(tx_builder.min_fee(false).unwrap(), 53);
4026+
assert_eq!(tx_builder.min_fee(false).unwrap(), 56);
40274027
tx_builder.add_utxo(make_input(1u8, Value::from(150)));
40284028
tx_builder.add_utxo(make_input(2u8, Value::from(150)));
40294029
tx_builder.add_utxo(make_input(3u8, Value::from(150)));
40304030
let add_inputs_res = tx_builder.select_utxos(CoinSelectionStrategyCIP2::RandomImprove);
40314031
assert!(add_inputs_res.is_ok(), "{:?}", add_inputs_res.err());
4032-
assert_eq!(tx_builder.min_fee(false).unwrap(), 264);
4032+
assert_eq!(tx_builder.min_fee(false).unwrap(), 270);
40334033
let change_addr = ByronAddress::from_base58(
40344034
"Ae2tdPwUPEZGUEsuMAhvDcy94LKsZxDjCbgaiBBMgYpR8sKf96xJmit7Eho",
40354035
)
@@ -4832,7 +4832,7 @@ mod tests {
48324832
tx_builder.add_input(input).unwrap();
48334833

48344834
let original_tx_fee = tx_builder.min_fee(false).unwrap();
4835-
assert_eq!(original_tx_fee, 164502);
4835+
assert_eq!(original_tx_fee, 169002);
48364836

48374837
let result = SingleMintBuilder::new_single_asset(name1, amount).native_script(
48384838
mint_script1,
@@ -5368,7 +5368,7 @@ mod tests {
53685368
}
53695369

53705370
let original_tx_fee = tx_builder.min_fee(false).unwrap();
5371-
assert_eq!(original_tx_fee, 469629);
5371+
assert_eq!(original_tx_fee, 470421);
53725372
tx_builder.set_fee(897753);
53735373

53745374
{
@@ -5378,7 +5378,7 @@ mod tests {
53785378
);
53795379
}
53805380
let tx = tx_builder.build(ChangeSelectionAlgo::Default, &Address::from_bech32("addr1q9tzwgthsm4hs8alk5v3rgjn7nf9pldlmnc3nrns6dvct2dqzvgjxvajrmzsvwh9fucmp65gxc6mv3fskurctfyuj5zqc7q30l").unwrap()).unwrap();
5381-
assert_eq!(hex::encode(tx.body.to_cbor_bytes()), "a70081825820473899cb48414442ea107735f7fc3e020f0293122e9d05e4be6f03ffafde5a0c00018283581d71aba3c2914116298a146af57d8156b1583f183fc05c0aa48ee95bec71821a001c41caa1581c6bec713b08a2d7c64baa3596d200b41b560850919d72e634944f2d52a14f537061636542756442696433303533015820f7f2f57c58b5e4872201ab678928b0d63935e82d022d385e1bad5bfe347e89d8825839015627217786eb781fbfb51911a253f4d250fdbfdcf1198e70d35985a9a013112333b21ec5063ae54f31b0ea883635b64530b70785a49c95041a040228dd021a000db2d907582029ed935cc80249c4de9f3e96fdcea6b7da123a543bbe75fffe9e2c66119e426d0b58201907c235a0df870e95152669f7c147d6e3a7e251b57e4d5227556d1fd0caca0b0d81825820a90a895d07049afc725a0d6a38c6b82218b8d1de60e7bd70ecdd58f1d9e1218b000e81581c1c616f1acb460668a9b2f123c80372c2adad3583b9c6cd2b1deeed1c");
5381+
assert_eq!(hex::encode(tx.body.to_cbor_bytes()), "a700d9010281825820473899cb48414442ea107735f7fc3e020f0293122e9d05e4be6f03ffafde5a0c00018283581d71aba3c2914116298a146af57d8156b1583f183fc05c0aa48ee95bec71821a001c41caa1581c6bec713b08a2d7c64baa3596d200b41b560850919d72e634944f2d52a14f537061636542756442696433303533015820f7f2f57c58b5e4872201ab678928b0d63935e82d022d385e1bad5bfe347e89d8825839015627217786eb781fbfb51911a253f4d250fdbfdcf1198e70d35985a9a013112333b21ec5063ae54f31b0ea883635b64530b70785a49c95041a040228dd021a000db2d907582029ed935cc80249c4de9f3e96fdcea6b7da123a543bbe75fffe9e2c66119e426d0b58205d5863643ea0687f9ca3ea903e9d86d81787373da1ebf196206c31f29608ce9b0dd9010281825820a90a895d07049afc725a0d6a38c6b82218b8d1de60e7bd70ecdd58f1d9e1218b000ed9010281581c1c616f1acb460668a9b2f123c80372c2adad3583b9c6cd2b1deeed1c");
53825382
}
53835383

53845384
#[test]
@@ -5550,11 +5550,11 @@ mod tests {
55505550
let real_script_hash = signed_tx_builder.body.script_data_hash.as_ref().unwrap();
55515551
assert_eq!(
55525552
real_script_hash.to_hex(),
5553-
"1907c235a0df870e95152669f7c147d6e3a7e251b57e4d5227556d1fd0caca0b"
5553+
"5d5863643ea0687f9ca3ea903e9d86d81787373da1ebf196206c31f29608ce9b"
55545554
);
55555555

55565556
let tx = &signed_tx_builder.body;
5557-
assert_eq!(hex::encode(tx.to_cbor_bytes()), "a70081825820473899cb48414442ea107735f7fc3e020f0293122e9d05e4be6f03ffafde5a0c00018283581d71aba3c2914116298a146af57d8156b1583f183fc05c0aa48ee95bec71821a001c41caa1581c6bec713b08a2d7c64baa3596d200b41b560850919d72e634944f2d52a14f537061636542756442696433303533015820f7f2f57c58b5e4872201ab678928b0d63935e82d022d385e1bad5bfe347e89d8825839015627217786eb781fbfb51911a253f4d250fdbfdcf1198e70d35985a9a013112333b21ec5063ae54f31b0ea883635b64530b70785a49c95041a040228dd021a000db2d907582029ed935cc80249c4de9f3e96fdcea6b7da123a543bbe75fffe9e2c66119e426d0b58201907c235a0df870e95152669f7c147d6e3a7e251b57e4d5227556d1fd0caca0b0d81825820a90a895d07049afc725a0d6a38c6b82218b8d1de60e7bd70ecdd58f1d9e1218b000e81581c1c616f1acb460668a9b2f123c80372c2adad3583b9c6cd2b1deeed1c");
5557+
assert_eq!(hex::encode(tx.to_cbor_bytes()), "a700d9010281825820473899cb48414442ea107735f7fc3e020f0293122e9d05e4be6f03ffafde5a0c00018283581d71aba3c2914116298a146af57d8156b1583f183fc05c0aa48ee95bec71821a001c41caa1581c6bec713b08a2d7c64baa3596d200b41b560850919d72e634944f2d52a14f537061636542756442696433303533015820f7f2f57c58b5e4872201ab678928b0d63935e82d022d385e1bad5bfe347e89d8825839015627217786eb781fbfb51911a253f4d250fdbfdcf1198e70d35985a9a013112333b21ec5063ae54f31b0ea883635b64530b70785a49c95041a040228dd021a000db2d907582029ed935cc80249c4de9f3e96fdcea6b7da123a543bbe75fffe9e2c66119e426d0b58205d5863643ea0687f9ca3ea903e9d86d81787373da1ebf196206c31f29608ce9b0dd9010281825820a90a895d07049afc725a0d6a38c6b82218b8d1de60e7bd70ecdd58f1d9e1218b000ed9010281581c1c616f1acb460668a9b2f123c80372c2adad3583b9c6cd2b1deeed1c");
55585558
}
55595559

55605560
#[test]

chain/rust/src/utils.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -769,7 +769,7 @@ impl<T> From<Vec<T>> for NonemptySet<T> {
769769
Self {
770770
elems,
771771
len_encoding: LenEncoding::default(),
772-
tag_encoding: None,
772+
tag_encoding: Some(Sz::Two),
773773
}
774774
}
775775
}
@@ -939,7 +939,7 @@ impl<T> From<Vec<T>> for NonemptySetRawBytes<T> {
939939
Self {
940940
elems,
941941
len_encoding: LenEncoding::default(),
942-
tag_encoding: None,
942+
tag_encoding: Some(Sz::Two),
943943
bytes_encodings: Vec::new(),
944944
}
945945
}

0 commit comments

Comments
 (0)