Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Test run results should include failure value, even if not fail or warning #11312

Open
3 tasks done
vglocus opened this issue Feb 15, 2025 · 0 comments · May be fixed by #11313
Open
3 tasks done

[Feature] Test run results should include failure value, even if not fail or warning #11312

vglocus opened this issue Feb 15, 2025 · 0 comments · May be fixed by #11313
Labels
enhancement New feature or request triage

Comments

@vglocus
Copy link

vglocus commented Feb 15, 2025

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Currently the RunResult of data test will report failures at 0 unless there is a warning or error. [code]

The scenario: I have severity: warn and warn_if: '> 10', my data test returns 4 failures, my RunResult shows 0 failures.
I would expect the 4 to go through.

What would be the problem if we always returned the "failures" column of the query?

Describe alternatives you've considered

Alternative to getting the actual failure result is to use the adapter response, get a reference to the job id (BigQuery) and look up the job result manually. A lot of effort for getting number correctly.

Who will this benefit?

Anyone who uses RunResults, either via the produced json file or programmatically, to monitor their data workflows to some degree.

Are you interested in contributing this feature?

Yes

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant