Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Integration Tests #1045

Closed
markussiebert opened this issue Jun 14, 2024 · 0 comments
Closed

Improve Integration Tests #1045

markussiebert opened this issue Jun 14, 2024 · 0 comments

Comments

@markussiebert
Copy link
Contributor

Our integration tests don't test all supported options.

[ ] Use KMS Key for secret
[ ] Version updates with existing secrets
[ ] Use real kms key for encryption (this will be hard)
[ ] ... maybe more?

and we rely on snapshots. It would be great if we could do real deployments in test stage ...
@markussiebert markussiebert mentioned this issue Feb 10, 2025
Merged
markussiebert added a commit that referenced this issue Feb 11, 2025
@markussiebert @derbauer97 @lenderom
feat: sdkv2 (#1111)
dc789a9 
# BREAKING CHANGE: v2.0

Fixes #1090, #1096, #1092, #1043, #1045

# Features

- update Go AWS SDK V2
- Handling of raw secrets
- Handling of binary secrets

## Migrate from V1 to V2

It was required to change some user facing configuration properties. So minor changes are required to make things work again.

### SecretsManager
- Removed property convertToJSON, flatten, stringifiedValues 
- Use property rawOutput instaed:
  - `undefined / not set` => (default) convertToJSON and flatten and stringifiedValues = true
  - `RawOutput.STRING` => convertToJSON and flatten and stringifiedValues = false
  - `RawOutput.BINARY` => convertToJSON and flatten and stringifiedValues = false and Secret is binary

### Parameter
- Removed property convertToJSON, flatten, stringifiedValues => all of them made no sense - now only raw output of decrypted secret

### MultiParameter
- Removed property convertToJSON, flatten, stringifiedValues => most of this combinations made no sense
- Allways convertToJson and flatten (as we have to parse it to create multiple parameters)
- You are allowed to chose the flattenSeperator
---------

Signed-off-by: Florian Fl Bauer <[email protected]>
Signed-off-by: github-actions <[email protected]>
Signed-off-by: lennartrommeiss <[email protected]>
Co-authored-by: Florian Bauer <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: lennartrommeiss <[email protected]>
Co-authored-by: Lennart Rommeiss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markussiebert