spec/cookie_spec: Add tests for cookie order

Author: daurnimator

spec/cookie_spec.lua

@@ -312,6 +312,48 @@ describe("cookie module", function()
 			assert.same(nil, s:get("example.com", "/", "qux"))
 		end)
 	end)
+	describe("cookie order", function()
+		it("returns in order for simple cookies", function() -- used as assumed base case for future tests in this section
+			local s = http_cookie.new_store()
+			assert(s:store("example.com", "/", true, true, nil, http_cookie.parse_setcookie("foo=basic")))
+			assert(s:store("example.com", "/", true, true, nil, http_cookie.parse_setcookie("bar=basic")))
+			assert.same("bar=basic; foo=basic", s:lookup("example.com", "/", true, true))
+		end)
+		it("returns in order for domain differing cookies", function() -- spec doesn't care about this case
+			local s = http_cookie.new_store()
+			assert(s:store("sub.example.com", "/", true, true, nil, http_cookie.parse_setcookie("foo=domain; Domain=sub.example.com")))
+			assert(s:store("sub.example.com", "/", true, true, nil, http_cookie.parse_setcookie("bar=domain; Domain=example.com")))
+			assert.same("bar=domain; foo=domain", s:lookup("sub.example.com", "/", true, true))
+		end)
+		it("returns in order for different length paths", function()
+			local s = http_cookie.new_store()
+			assert(s:store("example.com", "/", true, true, nil, http_cookie.parse_setcookie("foo=path; Path=/path/longerpath")))
+			assert(s:store("example.com", "/", true, true, nil, http_cookie.parse_setcookie("bar=path; Path=/path/")))
+			assert.same("foo=path; bar=path", s:lookup("example.com", "/path/longerpath", true, true))
+		end)
+		it("returns in order for different creation times", function()
+			local s = http_cookie.new_store()
+			s.time = function() return 0 end
+			assert(s:store("example.com", "/", true, true, nil, http_cookie.parse_setcookie("foo=time")))
+			s.time = function() return 50 end
+			assert(s:store("example.com", "/", true, true, nil, http_cookie.parse_setcookie("bar=time")))
+			assert.same("foo=time; bar=time", s:lookup("example.com", "/path/longerpath", true, true))
+		end)
+		it("returns in order when all together!", function()
+			local s = http_cookie.new_store()
+			assert(s:store("sub.example.com", "/", true, true, nil, http_cookie.parse_setcookie("foo=basic")))
+			assert(s:store("sub.example.com", "/", true, true, nil, http_cookie.parse_setcookie("bar=basic")))
+			assert(s:store("sub.example.com", "/", true, true, nil, http_cookie.parse_setcookie("foo=path; Path=/path/longerpath")))
+			assert(s:store("sub.example.com", "/", true, true, nil, http_cookie.parse_setcookie("bar=path; Path=/path/")))
+			-- foo=domain case would get overridden below
+			assert(s:store("sub.example.com", "/", true, true, nil, http_cookie.parse_setcookie("bar=domain; Domain=example.com")))
+			s.time = function() return 0 end
+			assert(s:store("sub.example.com", "/", true, true, nil, http_cookie.parse_setcookie("foo=time")))
+			s.time = function() return 50 end
+			assert(s:store("sub.example.com", "/", true, true, nil, http_cookie.parse_setcookie("bar=time")))
+			assert.same("foo=path; bar=path; bar=domain; bar=time; foo=time", s:lookup("sub.example.com", "/path/longerpath", true, true))
+		end)
+	end)
 	it("can bake cookies", function()
 		assert.same("foo=bar", http_cookie.bake("foo", "bar"))
 		assert.same("foo=bar; Max-Age=0", http_cookie.bake("foo", "bar", -math.huge))