http/request: do not handle 304 Not Modified as a redirect code.

Author: menakite

http/request.lua

@@ -623,7 +623,7 @@ function request_methods:go(timeout)
 		self.cookie_store:store_from_request(request_headers, headers, self.host, self.site_for_cookies)
 	end
 
-	if self.follow_redirects and headers:get(":status"):sub(1,1) == "3" then
+	if self.follow_redirects and headers:get(":status"):sub(1,1) == "3" and headers:get(":status") ~= "304" then
 		stream:shutdown()
 		local new_req, err2, errno2 = self:handle_redirect(headers)
 		if not new_req then

spec/request_spec.lua

@@ -606,6 +606,18 @@ describe("http.request module", function()
 				stream:shutdown()
 			end)
 		end)
+		it("does not consider 304 a redirect response", function()
+			test(function(stream)
+				assert(stream:get_headers())
+				local resp_headers = new_headers()
+				resp_headers:append(":status", "304")
+				assert(stream:write_headers(resp_headers, true))
+			end, function(req)
+				local headers, stream = assert(req:go())
+				assert.same("304", headers:get(":status"))
+				stream:shutdown()
+			end)
+		end)
 		it("works with a proxy server", function()
 			test(function(stream)
 				local h = assert(stream:get_headers())