-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TERRA-116: PrivateLink affected when attempting to flip deletion_protection flag #400
Comments
@emerkle826 Do you have an ETA on this? |
@StevenLacerda I just tried to reproduce this issue and I'm not able to. With the following : terraform {
required_providers {
astra = {
source = "datastax/astra"
version = "2.3.11"
}
}
}
resource "astra_database" "terra116" {
name = "terra116"
keyspace = "testks"
cloud_provider = "gcp"
regions = ["us-east1"]
deletion_protection = "false"
}
resource "astra_private_link" "privatelink" {
allowed_principals = ["<my_principal>"]
database_id = astra_database.terra116.id
datacenter_id = astra_database.terra116.datacenters["${astra_database.terra116.cloud_provider}.${astra_database.terra116.regions[0]}"]
} I am able to create a DB and a private link for it. If I then change terraform apply
astra_database.terra116: Refreshing state... [id=862b6fac-746a-4313-838e-a6e0bcd59376]
astra_private_link.privatelink: Refreshing state... [id=862b6fac-746a-4313-838e-a6e0bcd59376/datacenter/862b6fac-746a-4313-838e-a6e0bcd59376-1/serviceNames/projects/astra-fwd-prod-66/regions/us-east1/serviceAttachments/pl-prod]
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# astra_database.terra116 will be updated in-place
~ resource "astra_database" "terra116" {
~ deletion_protection = false -> true
id = "862b6fac-746a-4313-838e-a6e0bcd59376"
name = "terra116"
# (15 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Do you want to perform these actions?
Terraform will perform the actions described above.
Only 'yes' will be accepted to approve.
Enter a value: And the private link isn't modified. This is with the latest version |
Sandeep from Sony confirmed this issue is resolved: This was an issue on our end. We were getting the datacenter id from the astradb data resource and it was causing the issue:
We fixed it so you can go ahead and close the issue as well |
Thanks for the update @StevenLacerda |
Attempting to enable deletion protection - dry-run indicates that the private link would be affected:
The text was updated successfully, but these errors were encountered: