Changed usage of be_true and be_false to be(true) and be(false) in specs

* This is due to a somewhat recent change in rspec, where be_true now
  passes if the value is anything other than nil or false. Previously
  it would only pass if the value was a TrueClass instance; but now it's
  based on whether the object would return true in boolean context.

  Likewise be_false now passes if the value is nil or false, and previously
  it would only pass if the value was a FalseClass instance.

  I'm not a big fan of methods that are expected to return boolean
  returning anything other than those values. It's not enough that
  it return something that evaluates to true or false in boolean
  context.

Author: dkubb

spec/hash_spec.rb

@@ -141,12 +141,12 @@
 
   it "should typecast a true boolean" do
     xml = "<tag type='boolean'>true</tag>"
-    Hash.from_xml(xml)['tag'].should be_true
+    Hash.from_xml(xml)['tag'].should be(true)
   end
 
   it "should typecast a false boolean" do
     ["false"].each do |w|
-      Hash.from_xml("<tag type='boolean'>#{w}</tag>")['tag'].should be_false
+      Hash.from_xml("<tag type='boolean'>#{w}</tag>")['tag'].should be(false)
     end
   end
 

spec/lazy_array_spec.rb

@@ -54,13 +54,13 @@ def should_return_copy
 
     def should_return_true
       it 'should return true' do
-        action.should be_true
+        action.should be(true)
       end
     end
 
     def should_return_false
       it 'should return false' do
-        action.should be_false
+        action.should be(false)
       end
     end
 
@@ -151,7 +151,7 @@ def action
     subject { @lazy_array }
 
     it 'should be an Enumerable' do
-      (Enumerable === subject).should be_true
+      (Enumerable === subject).should be(true)
     end
 
     describe 'when frozen', state do
@@ -1948,7 +1948,7 @@ def lazy_spec
       end
 
       it 'should delegate to the Array' do
-        subject.lazy_spec.should be_true
+        subject.lazy_spec.should be(true)
       end
     end
 

spec/mash_spec.rb

@@ -14,7 +14,7 @@ class AwesomeHash < Hash
     it 'converts all keys into strings when param is a Hash' do
       mash = Mash.new(@hash)
 
-      mash.keys.any? { |key| key.is_a?(Symbol) }.should be_false
+      mash.keys.any? { |key| key.is_a?(Symbol) }.should be(false)
     end
 
     it 'converts all pure Hash values into Mashes if param is a Hash' do
@@ -53,7 +53,7 @@ class AwesomeHash < Hash
       mash = Mash.new(@hash)
       mash.update("starry" => "night")
 
-      mash.keys.any? { |key| key.is_a?(Symbol) }.should be_false
+      mash.keys.any? { |key| key.is_a?(Symbol) }.should be(false)
     end
 
     it 'converts all Hash values into Mashes if param is a Hash' do
@@ -71,7 +71,7 @@ class AwesomeHash < Hash
       mash = Mash.new(@hash)
       mash[:hash] = { "starry" => "night" }
 
-      mash.keys.any? { |key| key.is_a?(Symbol) }.should be_false
+      mash.keys.any? { |key| key.is_a?(Symbol) }.should be(false)
     end
 
     it 'converts all Hash value into Mash' do
@@ -90,36 +90,36 @@ class AwesomeHash < Hash
     end
 
     it 'converts key before lookup' do
-      @mash.key?("mash").should be_true
-      @mash.key?(:mash).should be_true
+      @mash.key?("mash").should be(true)
+      @mash.key?(:mash).should be(true)
 
-      @mash.key?("hash").should be_true
-      @mash.key?(:hash).should be_true
+      @mash.key?("hash").should be(true)
+      @mash.key?(:hash).should be(true)
 
-      @mash.key?(:rainclouds).should be_false
-      @mash.key?("rainclouds").should be_false
+      @mash.key?(:rainclouds).should be(false)
+      @mash.key?("rainclouds").should be(false)
     end
 
     it 'is aliased as include?' do
-      @mash.include?("mash").should be_true
-      @mash.include?(:mash).should be_true
+      @mash.include?("mash").should be(true)
+      @mash.include?(:mash).should be(true)
 
-      @mash.include?("hash").should be_true
-      @mash.include?(:hash).should be_true
+      @mash.include?("hash").should be(true)
+      @mash.include?(:hash).should be(true)
 
-      @mash.include?(:rainclouds).should be_false
-      @mash.include?("rainclouds").should be_false
+      @mash.include?(:rainclouds).should be(false)
+      @mash.include?("rainclouds").should be(false)
     end
 
     it 'is aliased as member?' do
-      @mash.member?("mash").should be_true
-      @mash.member?(:mash).should be_true
+      @mash.member?("mash").should be(true)
+      @mash.member?(:mash).should be(true)
 
-      @mash.member?("hash").should be_true
-      @mash.member?(:hash).should be_true
+      @mash.member?("hash").should be(true)
+      @mash.member?(:hash).should be(true)
 
-      @mash.member?(:rainclouds).should be_false
-      @mash.member?("rainclouds").should be_false
+      @mash.member?(:rainclouds).should be(false)
+      @mash.member?("rainclouds").should be(false)
     end
   end # describe "#key?"
 
@@ -198,14 +198,14 @@ class AwesomeHash < Hash
       mash = Mash.new(@hash)
 
       mash.delete(:hash)
-      mash.key?("hash").should be_false
+      mash.key?("hash").should be(false)
     end
 
     it 'works with String keys as well' do
       mash = Mash.new(@hash)
 
       mash.delete("mash")
-      mash.key?("mash").should be_false
+      mash.key?("mash").should be(false)
     end
   end
 
@@ -216,22 +216,22 @@ class AwesomeHash < Hash
       mash = Mash.new(@hash)
 
       hashless_mash = mash.except(:hash)
-      hashless_mash.key?("hash").should be_false
+      hashless_mash.key?("hash").should be(false)
     end
 
     it "works with String keys as well" do
       mash = Mash.new(@hash)
 
       mashless_mash = mash.except("mash")
-      mashless_mash.key?("mash").should be_false
+      mashless_mash.key?("mash").should be(false)
     end
 
     it "works with multiple keys" do
       mash = Mash.new(@hash)
 
       mashless = mash.except("hash", :mash)
-      mashless.key?(:hash).should be_false
-      mashless.key?("mash").should be_false
+      mashless.key?(:hash).should be(false)
+      mashless.key?("mash").should be(false)
     end
 
     it "should return a mash" do

spec/object_spec.rb

@@ -62,35 +62,35 @@ class Oi
 
   describe "#quacks_like?" do
     it 'returns true if duck is a Symbol and receiver responds to it' do
-      SymbolicDuck.new.quacks_like?(:quack).should be_true
+      SymbolicDuck.new.quacks_like?(:quack).should be(true)
     end
 
     it 'returns false if duck is a Symbol and receiver DOES NOT respond to it' do
-      SymbolicDuck.new.quacks_like?(:wtf).should be_false
+      SymbolicDuck.new.quacks_like?(:wtf).should be(false)
     end
 
     it 'returns true if duck is a class and receiver is its instance' do
       receiver = ClassyDuck.new
-      receiver.quacks_like?(ClassyDuck).should be_true
+      receiver.quacks_like?(ClassyDuck).should be(true)
     end
 
     it 'returns false if duck is a class and receiver IS NOT its instance' do
       receiver = ClassyDuck.new
-      receiver.quacks_like?(SymbolicDuck).should be_false
+      receiver.quacks_like?(SymbolicDuck).should be(false)
     end
 
     it 'returns true if duck is an array and at least one of its members quacks like this duck' do
       receiver = ClassyDuck.new
       ary      = [ClassyDuck, SymbolicDuck]
 
-      receiver.quacks_like?(ary).should be_true
+      receiver.quacks_like?(ary).should be(true)
     end
 
     it 'returns false if duck is an array and none of its members quacks like this duck' do
       receiver = ClassyDuck.new
       ary      = [SymbolicDuck.new, SymbolicDuck]
 
-      receiver.quacks_like?(ary).should be_false
+      receiver.quacks_like?(ary).should be(false)
     end
   end
 
@@ -99,16 +99,16 @@ class Oi
       @ary = [1, 2, 3]
       @set = Set.new([2, 3, 5])
 
-      1.in?(@ary).should be_true
-      2.in?(@ary).should be_true
-      3.in?(@ary).should be_true
-      4.in?(@ary).should be_false
+      1.in?(@ary).should be(true)
+      2.in?(@ary).should be(true)
+      3.in?(@ary).should be(true)
+      4.in?(@ary).should be(false)
 
-      1.in?(@set).should be_false
-      2.in?(@set).should be_true
-      3.in?(@set).should be_true
-      4.in?(@set).should be_false
-      5.in?(@set).should be_true
+      1.in?(@set).should be(false)
+      2.in?(@set).should be(true)
+      3.in?(@set).should be(true)
+      4.in?(@set).should be(false)
+      5.in?(@set).should be(true)
     end
   end
 end

spec/pooling_spec.rb

@@ -156,7 +156,7 @@ def dispose
     bob.release
     Extlib.exiting = true
     sleep(0.1)
-    Extlib::Pooling.scavenger?.should be_false
+    Extlib::Pooling.scavenger?.should be(false)
   end
 
   it "should be able to detach an instance from the pool" do
@@ -431,7 +431,7 @@ def dispose
 #   it "acquires new instances from pool" do
 #     @instance_one = DisposableResource.new
 #
-#     DisposableResource.pool.acquired?(@instance_one).should be_true
+#     DisposableResource.pool.acquired?(@instance_one).should be(true)
 #   end
 #
 #   it "flushed existing pool on re-initialization" do
@@ -483,10 +483,10 @@ def dispose
 #
 #   it "returns true when object's last aquisition time is greater than limit" do
 #     @t1 = DisposableResource.new
-#     DisposableResource.pool.time_to_release?(@t1).should be_false
+#     DisposableResource.pool.time_to_release?(@t1).should be(false)
 #
 #     sleep 3
-#     DisposableResource.pool.time_to_release?(@t1).should be_true
+#     DisposableResource.pool.time_to_release?(@t1).should be(true)
 #   end
 # end
 #

spec/simple_set_spec.rb

@@ -25,7 +25,7 @@
 
     it 'sets true mark on the key' do
       @s << "Fun"
-      @s["Fun"].should be_true
+      @s["Fun"].should be(true)
     end
   end