Skip to content

Commit fbb039f

Browse files
authored
minor: add ticket references to upstream tickets (#156)
I just filed a bunch of improvements in Datafusion as part of apache/datafusion#12550 and I want to add links to the code to remember when I can remove the workarounds in dft
1 parent a155b75 commit fbb039f

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/extensions/builder.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,15 @@ use std::sync::Arc;
3434
///
3535
/// List of things that would be nice to add upstream:
3636
/// TODO: Implement Debug for SessionStateBuilder upstream
37-
/// TODO: Implement with_table_factory to add a single TableProviderFactory to the list of factories
37+
/// <https://github.com/apache/datafusion/issues/12555>
3838
/// TODO: Implement some way to get access to the current RuntimeEnv (to register object stores)
39+
/// <https://github.com/apache/datafusion/issues/12553>
3940
/// TODO: Implement a way to add just a single TableProviderFactory
41+
/// <https://github.com/apache/datafusion/issues/12552>
4042
/// TODO: Make TableFactoryProvider implement Debug
41-
/// TODO: rename RuntimeEnv::new() to RuntimeEnv::try_new() as it returns a Result
43+
/// <https://github.com/apache/datafusion/pull/12557>
44+
/// TODO: rename RuntimeEnv::new() to RuntimeEnv::try_new() as it returns a Result:
45+
/// <https://github.com/apache/datafusion/issues/12554>
4246
//#[derive(Debug)]
4347
pub struct DftSessionStateBuilder {
4448
session_config: SessionConfig,

0 commit comments

Comments
 (0)