-
Notifications
You must be signed in to change notification settings - Fork 114
Complete Fetch Phase (EXTERNAL_LINKS
disposition and ARROW
format)
#598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
329 commits
Select commit
Hold shift + click to select a range
e96e5b8
large query results
varun-edachali-dbx 787f1f7
Merge branch 'sea-migration' into sea-test-scripts
varun-edachali-dbx 165c4f3
remove un-necessary changes
varun-edachali-dbx a6e40d0
simplify test module
varun-edachali-dbx 52e3088
logging -> debug level
varun-edachali-dbx 641c09b
change table name in log
varun-edachali-dbx 8bd12d8
Merge branch 'sea-migration' into exec-models-sea
varun-edachali-dbx ffded6e
remove un-necessary changes
varun-edachali-dbx 227f6b3
remove un-necessary backend cahnges
varun-edachali-dbx 68657a3
remove un-needed GetChunksResponse
varun-edachali-dbx 3940eec
remove un-needed GetChunksResponse
varun-edachali-dbx 37813ba
reduce code duplication in response parsing
varun-edachali-dbx 267c9f4
reduce code duplication
varun-edachali-dbx 2967119
more clear docstrings
varun-edachali-dbx 47fd60d
introduce strongly typed ChunkInfo
varun-edachali-dbx 982fdf2
remove is_volume_operation from response
varun-edachali-dbx 9e14d48
add is_volume_op and more ResultData fields
varun-edachali-dbx be1997e
Merge branch 'exec-models-sea' into exec-phase-sea
varun-edachali-dbx e8e8ee7
Merge branch 'sea-test-scripts' into exec-phase-sea
varun-edachali-dbx 05ee4e7
add test scripts
varun-edachali-dbx 3ffa898
Merge branch 'exec-models-sea' into metadata-sea
varun-edachali-dbx 2952d8d
Revert "Merge branch 'sea-migration' into exec-models-sea"
varun-edachali-dbx 89e2aa0
Merge branch 'exec-phase-sea' into metadata-sea
varun-edachali-dbx cbace3f
Revert "Merge branch 'exec-models-sea' into exec-phase-sea"
varun-edachali-dbx c075b07
change logging level
varun-edachali-dbx c62f76d
remove un-necessary changes
varun-edachali-dbx 199402e
remove excess changes
varun-edachali-dbx 8ac574b
remove excess changes
varun-edachali-dbx 398ca70
Merge branch 'sea-migration' into exec-phase-sea
varun-edachali-dbx b1acc5b
remove _get_schema_bytes (for now)
varun-edachali-dbx ef2a7ee
redundant comments
varun-edachali-dbx 699942d
Merge branch 'sea-migration' into exec-phase-sea
varun-edachali-dbx af8f74e
remove fetch phase methods
varun-edachali-dbx 5540c5c
reduce code repetititon + introduce gaps after multi line pydocs
varun-edachali-dbx efe3881
remove unused imports
varun-edachali-dbx 36ab59b
move description extraction to helper func
varun-edachali-dbx 1d57c99
formatting (black)
varun-edachali-dbx df6dac2
add more unit tests
varun-edachali-dbx ad0e527
streamline unit tests
varun-edachali-dbx ed446a0
test getting the list of allowed configurations
varun-edachali-dbx 38e4b5c
reduce diff
varun-edachali-dbx 94879c0
reduce diff
varun-edachali-dbx 1809956
house constants in enums for readability and immutability
varun-edachali-dbx da5260c
add note on hybrid disposition
varun-edachali-dbx 6ec265f
[squashed from cloudfetch-sea] introduce external links + arrow funct…
varun-edachali-dbx b2ad5e6
reduce responsibility of Queue
varun-edachali-dbx 66d0df6
reduce repetition in arrow tablee creation
varun-edachali-dbx eb7ec80
reduce redundant code in CloudFetchQueue
varun-edachali-dbx a3a8a4a
move chunk link progression to separate func
varun-edachali-dbx ea79bc8
remove redundant log
varun-edachali-dbx 5b49405
improve logging
varun-edachali-dbx 015fb76
remove reliance on schema_bytes in SEA
varun-edachali-dbx 0385ffb
remove redundant note on arrow_schema_bytes
varun-edachali-dbx 5380c7a
use more fetch methods
varun-edachali-dbx 27b781f
remove redundant schema_bytes from parent constructor
varun-edachali-dbx 238dc0a
only call get_chunk_link with non null chunk index
varun-edachali-dbx b3bb07e
align SeaResultSet structure with ThriftResultSet
varun-edachali-dbx 13e6346
remvoe _fill_result_buffer from SeaResultSet
varun-edachali-dbx f90b4d4
reduce code repetition
varun-edachali-dbx 23963fc
align SeaResultSet with ext-links-sea
varun-edachali-dbx dd43715
remove redundant methods
varun-edachali-dbx 34a7f66
update unit tests
varun-edachali-dbx 715cc13
remove accidental venv changes
varun-edachali-dbx fb53dd9
pre-fetch next chunk link on processing current
varun-edachali-dbx d893877
reduce nesting
varun-edachali-dbx a165f1c
line break after multi line pydoc
varun-edachali-dbx d68e4ea
re-introduce schema_bytes for better abstraction (likely temporary)
varun-edachali-dbx be17812
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx a0705bc
add fetchmany_arrow and fetchall_arrow
varun-edachali-dbx 1b90c4a
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx f7c11b9
remove accidental changes in sea backend tests
varun-edachali-dbx 349c021
Merge branch 'exec-phase-sea' into metadata-sea
varun-edachali-dbx 6229848
remove irrelevant changes
varun-edachali-dbx fd52356
remove un-necessary test changes
varun-edachali-dbx 64e58b0
remove un-necessary changes in thrift backend tests
varun-edachali-dbx 2903473
remove unimplemented methods test
varun-edachali-dbx b300709
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx 021ff4c
remove unimplemented method tests
varun-edachali-dbx adecd53
modify example scripts to include fetch calls
varun-edachali-dbx d33e5fd
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx e3cef5c
add GetChunksResponse
varun-edachali-dbx ac50669
remove changes to sea test
varun-edachali-dbx 03cdc4f
re-introduce accidentally removed description extraction method
varun-edachali-dbx e1842d8
fix type errors (ssl_options, CHUNK_PATH_WITH_ID..., etc.)
varun-edachali-dbx 89a46af
access ssl_options through connection
varun-edachali-dbx 1d0b28b
DEBUG level
varun-edachali-dbx c8820d4
remove explicit multi chunk test
varun-edachali-dbx fe47787
move cloud fetch queues back into utils.py
varun-edachali-dbx 74f59b7
remove excess docstrings
varun-edachali-dbx 4b456b2
move ThriftCloudFetchQueue above SeaCloudFetchQueue
varun-edachali-dbx bfc1f01
fix sea connector tests
varun-edachali-dbx a4447a1
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx 4883aff
correct patch module path in cloud fetch queue tests
varun-edachali-dbx 0a2cdfd
remove unimplemented methods test
varun-edachali-dbx cd3378c
correct add_link docstring
varun-edachali-dbx 90bb09c
Merge branch 'sea-migration' into exec-phase-sea
varun-edachali-dbx cd22389
remove invalid import
varun-edachali-dbx 82e0f8b
Merge branch 'sea-migration' into exec-phase-sea
varun-edachali-dbx e64b81b
Merge branch 'exec-phase-sea' into metadata-sea
varun-edachali-dbx 27564ca
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx bc467d1
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx 5ab9bbe
better align queries with JDBC impl
varun-edachali-dbx 1ab6e87
line breaks after multi-line PRs
varun-edachali-dbx f469c24
remove unused imports
varun-edachali-dbx 68ec65f
fix: introduce ExecuteResponse import
varun-edachali-dbx ffd478e
Merge branch 'sea-migration' into metadata-sea
varun-edachali-dbx f6d873d
remove unimplemented metadata methods test, un-necessary imports
varun-edachali-dbx 28675f5
introduce unit tests for metadata methods
varun-edachali-dbx 3578659
remove verbosity in ResultSetFilter docstring
varun-edachali-dbx 8713023
remove un-necessary info in ResultSetFilter docstring
varun-edachali-dbx 22dc252
remove explicit type checking, string literals around forward annotat…
varun-edachali-dbx 390f592
house SQL commands in constants
varun-edachali-dbx dd7dc6a
convert complex types to string if not _use_arrow_native_complex_types
varun-edachali-dbx 28308fe
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx 2712d1c
introduce unit tests for altered functionality
varun-edachali-dbx dabba55
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx 48ad7b3
Revert "Merge branch 'fetch-json-inline' into ext-links-sea"
varun-edachali-dbx a1f9b9c
reduce verbosity of ResultSetFilter docstring
varun-edachali-dbx 984e8ee
remove unused imports
varun-edachali-dbx 3a999c0
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx c313c2b
Revert "Merge branch 'fetch-json-inline' into ext-links-sea"
varun-edachali-dbx 3bc615e
Revert "reduce verbosity of ResultSetFilter docstring"
varun-edachali-dbx b6e1a10
Reapply "Merge branch 'fetch-json-inline' into ext-links-sea"
varun-edachali-dbx 2df3d39
Revert "Merge branch 'fetch-json-inline' into ext-links-sea"
varun-edachali-dbx 5e75fb5
remove un-necessary filters changes
varun-edachali-dbx 20822e4
remove un-necessary backend changes
varun-edachali-dbx 802d045
remove constants changes
varun-edachali-dbx f3f795a
remove changes in filters tests
varun-edachali-dbx f6c5950
remove unit test backend and JSON queue changes
varun-edachali-dbx d210ccd
remove changes in sea result set testing
varun-edachali-dbx 22a953e
Revert "remove changes in sea result set testing"
varun-edachali-dbx 3aed144
Revert "remove unit test backend and JSON queue changes"
varun-edachali-dbx 0fe4da4
Revert "remove changes in filters tests"
varun-edachali-dbx 0e3c0a1
Revert "remove constants changes"
varun-edachali-dbx 93edb93
Revert "remove un-necessary backend changes"
varun-edachali-dbx 871a44f
Revert "remove un-necessary filters changes"
varun-edachali-dbx 0ce144d
remove unused imports
varun-edachali-dbx 08ca60d
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx 8c5cc77
working version
varun-edachali-dbx 7f5c715
adopy _wait_until_command_done
varun-edachali-dbx 9ef5fad
introduce metadata commands
varun-edachali-dbx 44183db
use new backend structure
varun-edachali-dbx d59b351
constrain backend diff
varun-edachali-dbx 1edc80a
remove changes to filters
varun-edachali-dbx f82658a
make _parse methods in models internal
varun-edachali-dbx 54eb0a4
reduce changes in unit tests
varun-edachali-dbx 50cc1e2
run small queries with SEA during integration tests
varun-edachali-dbx 242307a
run some tests for sea
varun-edachali-dbx 8a138e8
allow empty schema bytes for alignment with SEA
varun-edachali-dbx 82f9d6b
pass is_vl_op to Sea backend ExecuteResponse
varun-edachali-dbx 35f1ef0
remove catalog requirement in get_tables
varun-edachali-dbx a515d26
move filters.py to SEA utils
varun-edachali-dbx 59b1330
ensure SeaResultSet
varun-edachali-dbx 293e356
Merge branch 'sea-migration' into metadata-sea
varun-edachali-dbx dd40beb
prevent circular imports
varun-edachali-dbx 14057ac
remove unused imports
varun-edachali-dbx a4d5bdb
remove cast, throw error if not SeaResultSet
varun-edachali-dbx 156421a
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx eb1a9b4
pass param as TSparkParameterValue
varun-edachali-dbx 9000666
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx a3ca7c7
remove failing test (temp)
varun-edachali-dbx 2c22010
remove SeaResultSet type assertion
varun-edachali-dbx c09508e
change errors to align with spec, instead of arbitrary ValueError
varun-edachali-dbx e9b1314
make SEA backend methods return SeaResultSet
varun-edachali-dbx 8ede414
use spec-aligned Exceptions in SEA backend
varun-edachali-dbx 09a1b11
remove defensive row type check
varun-edachali-dbx 5e01e7b
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx 3becefe
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx a026d31
raise ProgrammingError for invalid id
varun-edachali-dbx 4446a9e
make is_volume_operation strict bool
varun-edachali-dbx 138359d
remove complex types code
varun-edachali-dbx b99d0c4
Revert "remove complex types code"
varun-edachali-dbx 21c389d
introduce type conversion for primitive types for JSON + INLINE
varun-edachali-dbx 734321a
Merge branch 'sea-migration' into fetch-json-inline
varun-edachali-dbx 9f0f969
remove SEA running on metadata queries (known failures
varun-edachali-dbx 04a1936
remove un-necessary docstrings
varun-edachali-dbx 278b8cd
align expected types with databricks sdk
varun-edachali-dbx 91b7f7f
link rest api reference to validate types
varun-edachali-dbx 7a5ae13
remove test_catalogs_returns_arrow_table test
varun-edachali-dbx f1776f3
fix fetchall_arrow and fetchmany_arrow
varun-edachali-dbx 6143331
remove thrift aligned test_cancel_during_execute from SEA tests
varun-edachali-dbx 8949d0c
Merge branch 'sea-migration' into fetch-json-inline
varun-edachali-dbx 5eaded4
remove un-necessary changes in example scripts
varun-edachali-dbx eeed9a1
remove un-necessary chagnes in example scripts
varun-edachali-dbx f233886
_convert_json_table -> _create_json_table
varun-edachali-dbx 68ac437
remove accidentally removed test
varun-edachali-dbx 7fd0845
remove new unit tests (to be re-added based on new arch)
varun-edachali-dbx ea7ff73
remove changes in sea_result_set functionality (to be re-added)
varun-edachali-dbx 563da71
introduce more integration tests
varun-edachali-dbx a018273
remove SEA tests in parameterized queries
varun-edachali-dbx c0e98f4
remove partial parameter fix changes
varun-edachali-dbx 7343035
remove un-necessary timestamp tests
varun-edachali-dbx ec500b6
slightly stronger typing of _convert_json_types
varun-edachali-dbx 0b3e91d
stronger typing of json utility func s
varun-edachali-dbx 7664e44
stronger typing of fetch*_json
varun-edachali-dbx db7b8e5
remove unused helper methods in SqlType
varun-edachali-dbx f75f2b5
line breaks after multi line pydocs, remove excess logs
varun-edachali-dbx e2d4ef5
line breaks after multi line pydocs, reduce diff of redundant changes
varun-edachali-dbx 21e3078
reduce diff of redundant changes
varun-edachali-dbx bb015e6
mandate ResultData in SeaResultSet constructor
varun-edachali-dbx 3944e39
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx b3273c7
remove complex type conversion
varun-edachali-dbx 38c2b88
correct fetch*_arrow
varun-edachali-dbx b77acbe
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx fa2359d
recover old sea tests
varun-edachali-dbx c07f709
move queue and result set into SEA specific dir
varun-edachali-dbx 9e4ef2e
pass ssl_options into CloudFetchQueue
varun-edachali-dbx b00c06c
reduce diff
varun-edachali-dbx 10f55f0
remove redundant conversion.py
varun-edachali-dbx cd119e9
fix type issues
varun-edachali-dbx d79638b
ValueError not ProgrammingError
varun-edachali-dbx f84578a
reduce diff
varun-edachali-dbx c621c0c
introduce SEA cloudfetch e2e tests
varun-edachali-dbx 7958cd9
allow empty cloudfetch result
varun-edachali-dbx e2d17ff
add unit tests for CloudFetchQueue and SeaResultSet
varun-edachali-dbx d348b35
skip pyarrow dependent tests
varun-edachali-dbx 811205e
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx 4bd290e
simplify download process: no pre-fetching
varun-edachali-dbx dfbbf79
correct class name in logs
varun-edachali-dbx ed4d7ab
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx a5e9cdf
align with old impl
varun-edachali-dbx be16634
align next_n_rows with prev imple
varun-edachali-dbx 6ec8656
align remaining_rows with prev impl
varun-edachali-dbx 7ea7b75
remove un-necessary Optional params
varun-edachali-dbx 64be07b
remove un-necessary changes in thrift field if tests
varun-edachali-dbx 165644c
remove unused imports
varun-edachali-dbx abef941
run large queries
varun-edachali-dbx fce324b
move link fetching immediately before table creation so link expiry i…
varun-edachali-dbx 39469fa
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx b2d1579
formatting (black)
varun-edachali-dbx 077a71c
fix types
varun-edachali-dbx 7985639
fix param type in unit tests
varun-edachali-dbx dfc32b4
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx 0a0643b
correct param extraction
varun-edachali-dbx f7fd1d9
remove common constructor for databricks client abc
varun-edachali-dbx 510b0a3
make SEA Http Client instance a private member
varun-edachali-dbx dd2864b
make GetChunksResponse model more robust
varun-edachali-dbx c32b281
add link to doc of GetChunk response model
varun-edachali-dbx 0b1eba5
pass result_data instead of "initial links" into SeaCloudFetchQueue
varun-edachali-dbx 777f7c1
move download_manager init into parent CloudFetchQueue
varun-edachali-dbx 130b0d3
raise ServerOperationError for no 0th chunk
varun-edachali-dbx 1920375
unused iports
varun-edachali-dbx d882c6e
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx 5a43686
return None in case of empty respose
varun-edachali-dbx 28c6bb1
ensure table is empty on no initial link s
varun-edachali-dbx 7ce8745
iterate over chunk indexes instead of link
varun-edachali-dbx c1a9e90
stronger typing
varun-edachali-dbx 54e0570
remove string literals around type defs
varun-edachali-dbx 8f2953e
introduce DownloadManager import
varun-edachali-dbx cc514ad
return None for immediate out of bounds
varun-edachali-dbx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.