fix(apps-mcp): correct template build, dev, and proxy configuration #4011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template's client/package.json used `tsc -p tsconfig.json -b` which has redundant flags. When using TypeScript project references with `-b` (build mode), the `-p tsconfig.json` flag is unnecessary because: - Build mode automatically looks for tsconfig.json in the current directory - The `-p` flag conflicts with the intended behavior of project references This change simplifies the build command to `tsc -b` which correctly handles the project references defined in tsconfig.json. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
keugenek
requested review from
a team,
lennartkats-db and
pietern
as code owners
keugenek
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Fix the server dev script to use correct tsx command syntax. The `watch` is a command, not a flag, so it should come immediately after `tsx`: Correct: tsx watch [flags...] <script path> Wrong: tsx --env-file-if-exists=../.env watch src/index.ts This ensures the template generates apps with proper command structure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
keugenek
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
keugenek
changed the title
Fix the client's vite.config.ts proxy configuration to match the actual server port and endpoint: 1. Port: Changed from 2022 → 8000 (server runs on 8000 by default) 2. Removed rewrite that stripped /api prefix (server expects requests at /api) The server configuration clearly shows: - Default port: 8000 (server/src/index.ts:53) - tRPC mounted at /api (server/src/index.ts:40) - Tests confirm endpoint is /api/healthcheck (server/src/server.test.ts:21) Port 2022 was a remnant from the original template port and doesn't match any actual server configuration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Collaborator
|
Commit: 09b0bdd
46 failing tests:
Top 21 slowest tests (at least 2 minutes):
|
keugenek
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
keugenek
changed the title
keugenek
commented
Nov 26, 2025
igrekun
approved these changes
Nov 27, 2025
Contributor
Author
|
Closing this PR as the tRPC template has been removed and replaced with AppKit template in #4007. The fixes in this PR are no longer applicable since the files being modified no longer exist in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the apps-mcp template's build, dev, and proxy commands by correcting command syntax and configuration issues.
Problems
tsc -p tsconfig.json -bwith redundant flagstsxcommand syntax withwatchin wrong positionSolutions
1. Client build command
Changed from:
To:
When using TypeScript project references with
-b(build mode), the-p tsconfig.jsonflag is unnecessary because build mode automatically discovers tsconfig.json.2. Server dev command
Changed from:
To:
The
watchis a command (not a flag) in tsx, so it must come immediately aftertsxfollowing the syntax:tsx watch [flags...] <script path>3. Client vite proxy configuration
Changed from:
To:
Fixed two issues:
/api(server/src/index.ts:40, server/src/server.test.ts:21), so stripping the prefix breaks routingPort 2022 was a remnant from the original template and doesn't match any server configuration.
Impact
Test plan
tsx --helpshowswatchas a command, not a flagtsx watch --helpconfirms syntax istsx watch [flags...] <script path>-bflag automatically discovers tsconfig.json with project referencesnpm run dev- confirms it starts on port 8000/apiendpoint (server/src/index.ts:40)/api/healthcheck(server/src/server.test.ts:21)