FIX: Use POST for metadata endpoints with symbols

Author: threecgreen

CHANGELOG.md

@@ -8,6 +8,10 @@
 ### Enhancements
 - Added new dataset `EQUS.MINI` and new publishers `EQUS.MINI.EQUS`, `XNYS.TRADES.EQUS`
 
+### Bug fixes
+- Changed historical metadata methods with `symbols` parameter to use a `POST` request
+  to allow for requesting supported maximum of 2000 symbols
+
 ## 0.27.0 - 2025-01-07
 
 ### Breaking changes

src/historical.cpp

@@ -9,8 +9,6 @@
 #include <cstddef>    // size_t
 #include <cstdlib>    // get_env
 #include <exception>  // exception, exception_ptr
-#include <fstream>    // ofstream
-#include <ios>        // ios::binary
 #include <iterator>   // back_inserter
 #include <memory>     // unique_ptr
 #include <string>
@@ -604,7 +602,7 @@ std::uint64_t Historical::MetadataGetRecordCount(
 std::uint64_t Historical::MetadataGetRecordCount(
     const httplib::Params& params) {
   static const std::string kPath = ::BuildMetadataPath(".get_record_count");
-  const nlohmann::json json = client_.GetJson(kPath, params);
+  const nlohmann::json json = client_.PostJson(kPath, params);
   if (!json.is_number_unsigned()) {
     throw JsonResponseError::TypeMismatch("Historical::MetadataGetRecordCount",
                                           "unsigned number", json);
@@ -661,7 +659,7 @@ std::uint64_t Historical::MetadataGetBillableSize(
 std::uint64_t Historical::MetadataGetBillableSize(
     const httplib::Params& params) {
   static const std::string kPath = ::BuildMetadataPath(".get_billable_size");
-  const nlohmann::json json = client_.GetJson(kPath, params);
+  const nlohmann::json json = client_.PostJson(kPath, params);
   if (!json.is_number_unsigned()) {
     throw JsonResponseError::TypeMismatch("Historical::MetadataGetBillableSize",
                                           "unsigned number", json);
@@ -722,7 +720,7 @@ double Historical::MetadataGetCost(
 }
 double Historical::MetadataGetCost(const HttplibParams& params) {
   static const std::string kPath = ::BuildMetadataPath(".get_cost");
-  const nlohmann::json json = client_.GetJson(kPath, params);
+  const nlohmann::json json = client_.PostJson(kPath, params);
   if (!json.is_number()) {
     throw JsonResponseError::TypeMismatch("Historical::MetadataGetCost",
                                           "number", json);

tests/src/historical_tests.cpp

@@ -463,13 +463,13 @@ TEST_F(HistoricalTests, TestMetadataGetDatasetRange) {
 
 TEST_F(HistoricalTests, TestMetadataGetRecordCount) {
   const nlohmann::json kResp = 42;
-  mock_server_.MockGetJson("/v0/metadata.get_record_count",
-                           {{"dataset", dataset::kGlbxMdp3},
-                            {"symbols", "ESZ3,ESH4"},
-                            {"start", "2020-06-06T00:00"},
-                            {"end", "2021-03-02T00:00"},
-                            {"schema", "trades"}},
-                           kResp);
+  mock_server_.MockPostJson("/v0/metadata.get_record_count",
+                            {{"dataset", dataset::kGlbxMdp3},
+                             {"symbols", "ESZ3,ESH4"},
+                             {"start", "2020-06-06T00:00"},
+                             {"end", "2021-03-02T00:00"},
+                             {"schema", "trades"}},
+                            kResp);
   const auto port = mock_server_.ListenOnThread();
 
   databento::Historical target{logger_.get(), kApiKey, "localhost",
@@ -482,13 +482,13 @@ TEST_F(HistoricalTests, TestMetadataGetRecordCount) {
 
 TEST_F(HistoricalTests, TestMetadataGetBillableSize_Simple) {
   const nlohmann::json kResp = 44688;
-  mock_server_.MockGetJson("/v0/metadata.get_billable_size",
-                           {{"dataset", dataset::kGlbxMdp3},
-                            {"start", "2020-06-06T00:00"},
-                            {"symbols", "ALL_SYMBOLS"},
-                            {"end", "2021-03-02T00:00"},
-                            {"schema", "trades"}},
-                           kResp);
+  mock_server_.MockPostJson("/v0/metadata.get_billable_size",
+                            {{"dataset", dataset::kGlbxMdp3},
+                             {"start", "2020-06-06T00:00"},
+                             {"symbols", "ALL_SYMBOLS"},
+                             {"end", "2021-03-02T00:00"},
+                             {"schema", "trades"}},
+                            kResp);
   const auto port = mock_server_.ListenOnThread();
 
   databento::Historical target{logger_.get(), kApiKey, "localhost",
@@ -501,14 +501,14 @@ TEST_F(HistoricalTests, TestMetadataGetBillableSize_Simple) {
 
 TEST_F(HistoricalTests, TestMetadataGetBillableSize_Full) {
   const nlohmann::json kResp = 55238;
-  mock_server_.MockGetJson("/v0/metadata.get_billable_size",
-                           {{"dataset", dataset::kGlbxMdp3},
-                            {"start", "2020-06-06T00:00"},
-                            {"end", "2021-03-02T00:00"},
-                            {"symbols", "NG.FUT,LNG.FUT"},
-                            {"schema", "tbbo"},
-                            {"stype_in", "parent"}},
-                           kResp);
+  mock_server_.MockPostJson("/v0/metadata.get_billable_size",
+                            {{"dataset", dataset::kGlbxMdp3},
+                             {"start", "2020-06-06T00:00"},
+                             {"end", "2021-03-02T00:00"},
+                             {"symbols", "NG.FUT,LNG.FUT"},
+                             {"schema", "tbbo"},
+                             {"stype_in", "parent"}},
+                            kResp);
   const auto port = mock_server_.ListenOnThread();
 
   databento::Historical target{logger_.get(), kApiKey, "localhost",
@@ -521,13 +521,13 @@ TEST_F(HistoricalTests, TestMetadataGetBillableSize_Full) {
 
 TEST_F(HistoricalTests, TestMetadataGetCost_Simple) {
   const nlohmann::json kResp = 0.65783;
-  mock_server_.MockGetJson("/v0/metadata.get_cost",
-                           {{"dataset", dataset::kGlbxMdp3},
-                            {"start", "2020-06-06T00:00"},
-                            {"end", "2021-03-02T00:00"},
-                            {"symbols", "MESN1,MESQ1"},
-                            {"schema", "trades"}},
-                           kResp);
+  mock_server_.MockPostJson("/v0/metadata.get_cost",
+                            {{"dataset", dataset::kGlbxMdp3},
+                             {"start", "2020-06-06T00:00"},
+                             {"end", "2021-03-02T00:00"},
+                             {"symbols", "MESN1,MESQ1"},
+                             {"schema", "trades"}},
+                            kResp);
   const auto port = mock_server_.ListenOnThread();
 
   databento::Historical target{logger_.get(), kApiKey, "localhost",
@@ -540,15 +540,15 @@ TEST_F(HistoricalTests, TestMetadataGetCost_Simple) {
 
 TEST_F(HistoricalTests, TestMetadataGetCost_Full) {
   const nlohmann::json kResp = 0.714;
-  mock_server_.MockGetJson("/v0/metadata.get_cost",
-                           {{"dataset", dataset::kGlbxMdp3},
-                            {"start", "2020-06-06T00:00"},
-                            {"end", "2021-03-02T00:00"},
-                            {"mode", "historical-streaming"},
-                            {"symbols", "MES.OPT,EW.OPT"},
-                            {"schema", "tbbo"},
-                            {"stype_in", "parent"}},
-                           kResp);
+  mock_server_.MockPostJson("/v0/metadata.get_cost",
+                            {{"dataset", dataset::kGlbxMdp3},
+                             {"start", "2020-06-06T00:00"},
+                             {"end", "2021-03-02T00:00"},
+                             {"mode", "historical-streaming"},
+                             {"symbols", "MES.OPT,EW.OPT"},
+                             {"schema", "tbbo"},
+                             {"stype_in", "parent"}},
+                            kResp);
   const auto port = mock_server_.ListenOnThread();
 
   databento::Historical target{logger_.get(), kApiKey, "localhost",