Skip to content

Adds auto encryption if this feature is desired. #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adds auto encryption if this feature is desired. #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60b3026
Adds auto encryption if this feature is desired.
kkapper May 20, 2025
58aeeae
retain original functionality also
kkapper May 20, 2025
3b86fcc
Clarify Docs
kkapper May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/databend-query/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.11.2
version: 0.11.3

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
4 changes: 4 additions & 0 deletions charts/databend-query/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ data:
name = {{ .name | quote }}
auth_type = {{ .authType | quote }}
{{- if eq .authType "sha256_password"}}
{{- if $.Values.config.query.passwords.generateSha256FromPlaintext }}
auth_string = {{ sha256sum .password | quote }}
{{- else }}
auth_string = {{ .authString | quote }}
{{- end }}
{{- else if eq .authType "double_sha1_password"}}
auth_string = {{ .authString | quote }}
{{- end }}
Expand Down
5 changes: 5 additions & 0 deletions charts/databend-query/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,18 @@ config:
max_active_sessions: 256
databend_enterprise_license: ""

passwords:
generateSha256FromPlaintext: false

# NOTE: user `root` is already built-in, will be ignored if defined here
users: []
# - name: databend
# # available type: sha256_password, double_sha1_password, no_password, jwt
# # sha1sum: echo -n "password" | sha1sum | cut -d' ' -f1 | xxd -r -p | sha1sum
# authType: double_sha1_password
# authString: 3081f32caef285c232d066033c89a78d88a6d8a5 # databend
# password: thisIsAnExamplePassword # If generateSha256FromPlaintext is enabled above, this value will be used instead of authString.
Copy link
Member

@everpcpc everpcpc Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How abount forcing sha256_password if password specified?

Copy link
Contributor Author

@kkapper kkapper Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable. I don't know of an easy way to implement a double sha 1 with the helm functions we have available to begin with.


# NOTE: use it for on premise session parameters
settings: {}

Expand Down
Loading