Skip to content

Commit d64eaab

Browse files
parkanparkan
authored
Fix/cascade (#583)
resolves several foreign key constraint/cascade issues, primarily unblocking deletion of preparations: - fix join table blocking deletion of preps with attached wallets - fix mysql refusing to delete preprations due to fk cascade parallelogram (#465) - fix postgres fk cascade deadlocks (same issue as above) with set null + trigger approach this addresses the postgres-specific foreign key constraint violations when deleting preparations by implementing a database-level solution that: 1. makes files.attachment_id nullable 2. changes the fk constraint to ON DELETE SET NULL instead of restrict/no action 3. adds a postgres trigger that immediately deletes files when attachment_id becomes null this approach keeps the application model unchanged (no pointer types) while solving the constraint violation. the trigger ensures the app never sees null attachment_id values so behavior stays consistent. the solution is postgres-specific because: - postgres has stricter fk enforcement that causes the deadlock/violation issues - mysql tests were already passing with the existing restrict behavior - we removed cascade deletes in 640154e to avoid deadlocks, but that created the constraint violation when deleting preparations longer term consideration: files conceptually belong to storages not preparations. attachments are just prep<->storage associations. we might want to remove this fk entirely since files should be storage-scoped and reusable across preparations (expensive to re-scan). this would eliminate the cascade issues entirely while enabling file reuse when recreating preparations with the same storage. this resolves two issues that prevent deletion of preparations. fixes #465
1 parent 6c6c640 commit d64eaab

File tree

8 files changed

+300
-10
lines changed

8 files changed

+300
-10
lines changed

‎cmd/admin/migrate.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ var MigrateCmd = &cli.Command{
101101
if err != nil {
102102
return errors.WithStack(err)
103103
}
104-
fmt.Printf("Current migration: " + last + "\n")
104+
fmt.Printf("Current migration: %s\n", last)
105105
return nil
106106
},
107107
},

‎handler/dataprep/remove_test.go‎

Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@ package dataprep
22

33
import (
44
"context"
5+
"fmt"
56
"os"
67
"path/filepath"
78
"testing"
9+
"time"
810

911
"github.com/data-preservation-programs/singularity/handler/handlererror"
1012
"github.com/data-preservation-programs/singularity/model"
@@ -110,3 +112,70 @@ func TestRemovePreparationHandler_Success(t *testing.T) {
110112
require.Len(t, entries, 0)
111113
})
112114
}
115+
116+
// postgres-only: used to hang on delete due to duplicate cascade paths
117+
// test the handler path and fail fast if it blocks, dialect branch is intentional
118+
func TestRemovePreparationHandler_CascadeCycle_Postgres(t *testing.T) {
119+
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
120+
if db.Dialector.Name() != "postgres" {
121+
t.Skip("Skip non-Postgres dialect")
122+
return
123+
}
124+
prep := model.Preparation{Name: "pg-prep"}
125+
require.NoError(t, db.Create(&prep).Error)
126+
tmpPg := t.TempDir()
127+
stor := model.Storage{Name: "pg-storage", Type: "local", Path: tmpPg}
128+
require.NoError(t, db.Create(&stor).Error)
129+
sa := model.SourceAttachment{PreparationID: prep.ID, StorageID: stor.ID}
130+
require.NoError(t, db.Create(&sa).Error)
131+
root := model.Directory{AttachmentID: sa.ID, Name: "", ParentID: nil}
132+
require.NoError(t, db.Create(&root).Error)
133+
d1 := model.Directory{AttachmentID: sa.ID, Name: "sub", ParentID: &root.ID}
134+
require.NoError(t, db.Create(&d1).Error)
135+
f := model.File{AttachmentID: sa.ID, DirectoryID: &d1.ID, Path: "sub/a.txt", Size: 1}
136+
require.NoError(t, db.Create(&f).Error)
137+
fr := model.FileRange{FileID: f.ID, Offset: 0, Length: 1}
138+
require.NoError(t, db.Create(&fr).Error)
139+
140+
done := make(chan error, 1)
141+
go func() {
142+
done <- Default.RemovePreparationHandler(ctx, db, fmt.Sprintf("%d", prep.ID), RemoveRequest{})
143+
}()
144+
145+
select {
146+
case err := <-done:
147+
require.NoError(t, err)
148+
case <-time.After(3 * time.Second):
149+
t.Fatal("DELETE hung (deadlock) on Postgres")
150+
}
151+
})
152+
}
153+
154+
// mysql-only: innodb used to reject the delete with duplicate cascade paths
155+
// test the handler path and expect success, dialect branch is intentional
156+
func TestRemovePreparationHandler_CascadeCycle_MySQL(t *testing.T) {
157+
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
158+
if db.Dialector.Name() != "mysql" {
159+
t.Skip("Skip non-MySQL dialect")
160+
return
161+
}
162+
prep := model.Preparation{Name: "my-prep"}
163+
require.NoError(t, db.Create(&prep).Error)
164+
tmpMy := t.TempDir()
165+
stor := model.Storage{Name: "my-storage", Type: "local", Path: tmpMy}
166+
require.NoError(t, db.Create(&stor).Error)
167+
sa := model.SourceAttachment{PreparationID: prep.ID, StorageID: stor.ID}
168+
require.NoError(t, db.Create(&sa).Error)
169+
root := model.Directory{AttachmentID: sa.ID, Name: "", ParentID: nil}
170+
require.NoError(t, db.Create(&root).Error)
171+
d1 := model.Directory{AttachmentID: sa.ID, Name: "sub", ParentID: &root.ID}
172+
require.NoError(t, db.Create(&d1).Error)
173+
f := model.File{AttachmentID: sa.ID, DirectoryID: &d1.ID, Path: "sub/a.txt", Size: 1}
174+
require.NoError(t, db.Create(&f).Error)
175+
fr := model.FileRange{FileID: f.ID, Offset: 0, Length: 1}
176+
require.NoError(t, db.Create(&fr).Error)
177+
178+
err := Default.RemovePreparationHandler(ctx, db, fmt.Sprintf("%d", prep.ID), RemoveRequest{})
179+
require.NoError(t, err)
180+
})
181+
}

‎migrate/migrations/202509171710_wallet_assignments_cascade.go‎

Lines changed: 80 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
package migrations
2+
3+
import (
4+
"github.com/go-gormigrate/gormigrate/v2"
5+
"github.com/pkg/errors"
6+
"gorm.io/gorm"
7+
)
8+
9+
func _202509171710_wallet_assignments_cascade() *gormigrate.Migration {
10+
// set wallet_assignments fks to cascade on delete, otherwise preparations with wallets cannot be deleted
11+
return &gormigrate.Migration{
12+
ID: "202509171710",
13+
Migrate: func(tx *gorm.DB) error {
14+
if tx.Dialector.Name() == "postgres" {
15+
// switch to cascade for preparation and wallet fks in postgres
16+
if err := tx.Exec("ALTER TABLE wallet_assignments DROP CONSTRAINT IF EXISTS fk_wallet_assignments_preparation").Error; err != nil {
17+
return errors.Wrap(err, "drop fk_wallet_assignments_preparation")
18+
}
19+
if err := tx.Exec("ALTER TABLE wallet_assignments ADD CONSTRAINT fk_wallet_assignments_preparation FOREIGN KEY (preparation_id) REFERENCES preparations(id) ON DELETE CASCADE").Error; err != nil {
20+
return errors.Wrap(err, "add fk_wallet_assignments_preparation cascade")
21+
}
22+
if err := tx.Exec("ALTER TABLE wallet_assignments DROP CONSTRAINT IF EXISTS fk_wallet_assignments_wallet").Error; err != nil {
23+
return errors.Wrap(err, "drop fk_wallet_assignments_wallet")
24+
}
25+
if err := tx.Exec("ALTER TABLE wallet_assignments ADD CONSTRAINT fk_wallet_assignments_wallet FOREIGN KEY (wallet_id) REFERENCES wallets(id) ON DELETE CASCADE").Error; err != nil {
26+
return errors.Wrap(err, "add fk_wallet_assignments_wallet cascade")
27+
}
28+
return nil
29+
}
30+
if tx.Dialector.Name() == "mysql" {
31+
// align mysql fks to cascade semantics
32+
if err := tx.Exec("ALTER TABLE wallet_assignments DROP FOREIGN KEY fk_wallet_assignments_preparation").Error; err != nil {
33+
}
34+
if err := tx.Exec("ALTER TABLE wallet_assignments ADD CONSTRAINT fk_wallet_assignments_preparation FOREIGN KEY (preparation_id) REFERENCES preparations(id) ON DELETE CASCADE").Error; err != nil {
35+
return errors.Wrap(err, "add fk_wallet_assignments_preparation cascade (mysql)")
36+
}
37+
if err := tx.Exec("ALTER TABLE wallet_assignments DROP FOREIGN KEY fk_wallet_assignments_wallet").Error; err != nil {
38+
}
39+
if err := tx.Exec("ALTER TABLE wallet_assignments ADD CONSTRAINT fk_wallet_assignments_wallet FOREIGN KEY (wallet_id) REFERENCES wallets(id) ON DELETE CASCADE").Error; err != nil {
40+
return errors.Wrap(err, "add fk_wallet_assignments_wallet cascade (mysql)")
41+
}
42+
return nil
43+
}
44+
return nil
45+
},
46+
Rollback: func(tx *gorm.DB) error {
47+
if tx.Dialector.Name() == "postgres" {
48+
// revert to no action to match previous behavior
49+
if err := tx.Exec("ALTER TABLE wallet_assignments DROP CONSTRAINT IF EXISTS fk_wallet_assignments_preparation").Error; err != nil {
50+
return errors.Wrap(err, "drop fk_wallet_assignments_preparation (rollback)")
51+
}
52+
if err := tx.Exec("ALTER TABLE wallet_assignments ADD CONSTRAINT fk_wallet_assignments_preparation FOREIGN KEY (preparation_id) REFERENCES preparations(id) ON DELETE NO ACTION").Error; err != nil {
53+
return errors.Wrap(err, "add fk_wallet_assignments_preparation no action (rollback)")
54+
}
55+
if err := tx.Exec("ALTER TABLE wallet_assignments DROP CONSTRAINT IF EXISTS fk_wallet_assignments_wallet").Error; err != nil {
56+
return errors.Wrap(err, "drop fk_wallet_assignments_wallet (rollback)")
57+
}
58+
if err := tx.Exec("ALTER TABLE wallet_assignments ADD CONSTRAINT fk_wallet_assignments_wallet FOREIGN KEY (wallet_id) REFERENCES wallets(id) ON DELETE NO ACTION").Error; err != nil {
59+
return errors.Wrap(err, "add fk_wallet_assignments_wallet no action (rollback)")
60+
}
61+
return nil
62+
}
63+
if tx.Dialector.Name() == "mysql" {
64+
// revert mysql fks back to no action equivalent
65+
if err := tx.Exec("ALTER TABLE wallet_assignments DROP FOREIGN KEY fk_wallet_assignments_preparation").Error; err != nil {
66+
}
67+
if err := tx.Exec("ALTER TABLE wallet_assignments ADD CONSTRAINT fk_wallet_assignments_preparation FOREIGN KEY (preparation_id) REFERENCES preparations(id)").Error; err != nil {
68+
return errors.Wrap(err, "add fk_wallet_assignments_preparation no action (mysql rollback)")
69+
}
70+
if err := tx.Exec("ALTER TABLE wallet_assignments DROP FOREIGN KEY fk_wallet_assignments_wallet").Error; err != nil {
71+
}
72+
if err := tx.Exec("ALTER TABLE wallet_assignments ADD CONSTRAINT fk_wallet_assignments_wallet FOREIGN KEY (wallet_id) REFERENCES wallets(id)").Error; err != nil {
73+
return errors.Wrap(err, "add fk_wallet_assignments_wallet no action (mysql rollback)")
74+
}
75+
return nil
76+
}
77+
return nil
78+
},
79+
}
80+
}

‎migrate/migrations/202509171745_files_attachment_no_cascade.go‎

Lines changed: 99 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
1+
package migrations
2+
3+
import (
4+
"github.com/go-gormigrate/gormigrate/v2"
5+
"github.com/pkg/errors"
6+
"gorm.io/gorm"
7+
)
8+
9+
func _202509171745_files_attachment_no_cascade() *gormigrate.Migration {
10+
// fixes deadlock that occurs when deleting preparation due to multiple cascade paths
11+
// we do this instead of making files.attachment_id nullable to keep value types (NULLABLE implies pointer in gorm)
12+
return &gormigrate.Migration{
13+
ID: "202509171745",
14+
Migrate: func(tx *gorm.DB) error {
15+
if tx.Dialector.Name() == "postgres" {
16+
// set null on fk then rely on trigger to clean up orphans
17+
// postgres is more restrictive than InnoDB so we have to do this manually
18+
if err := tx.Exec("ALTER TABLE files ALTER COLUMN attachment_id DROP NOT NULL").Error; err != nil {
19+
return errors.Wrap(err, "make files.attachment_id nullable")
20+
}
21+
if err := tx.Exec("ALTER TABLE files DROP CONSTRAINT IF EXISTS fk_files_attachment").Error; err != nil {
22+
return errors.Wrap(err, "drop fk_files_attachment")
23+
}
24+
if err := tx.Exec("ALTER TABLE files ADD CONSTRAINT fk_files_attachment FOREIGN KEY (attachment_id) REFERENCES source_attachments(id) ON DELETE SET NULL").Error; err != nil {
25+
return errors.Wrap(err, "add fk_files_attachment set null")
26+
}
27+
28+
if err := tx.Exec(`
29+
CREATE OR REPLACE FUNCTION delete_orphan_files() RETURNS trigger AS $$
30+
BEGIN
31+
IF NEW.attachment_id IS NULL THEN
32+
DELETE FROM files WHERE id = NEW.id;
33+
END IF;
34+
RETURN NULL;
35+
END; $$ LANGUAGE plpgsql;
36+
`).Error; err != nil {
37+
return errors.Wrap(err, "create delete_orphan_files function")
38+
}
39+
40+
if err := tx.Exec("DROP TRIGGER IF EXISTS trg_delete_orphan_files ON files").Error; err != nil {
41+
return errors.Wrap(err, "drop existing trigger")
42+
}
43+
44+
if err := tx.Exec(`
45+
CREATE TRIGGER trg_delete_orphan_files
46+
AFTER UPDATE OF attachment_id ON files
47+
FOR EACH ROW
48+
WHEN (NEW.attachment_id IS NULL)
49+
EXECUTE FUNCTION delete_orphan_files();
50+
`).Error; err != nil {
51+
return errors.Wrap(err, "create trigger")
52+
}
53+
54+
return nil
55+
}
56+
if tx.Dialector.Name() == "mysql" {
57+
// mysql uses restrict to emulate no cascade behavior here
58+
if err := tx.Exec("ALTER TABLE files DROP FOREIGN KEY fk_files_attachment").Error; err != nil {
59+
}
60+
if err := tx.Exec("ALTER TABLE files ADD CONSTRAINT fk_files_attachment FOREIGN KEY (attachment_id) REFERENCES source_attachments(id) ON DELETE RESTRICT").Error; err != nil {
61+
return errors.Wrap(err, "add fk_files_attachment restrict")
62+
}
63+
return nil
64+
}
65+
return nil
66+
},
67+
Rollback: func(tx *gorm.DB) error {
68+
if tx.Dialector.Name() == "postgres" {
69+
// remove trigger and function then restore previous not null and no action fk
70+
if err := tx.Exec("DROP TRIGGER IF EXISTS trg_delete_orphan_files ON files").Error; err != nil {
71+
return errors.Wrap(err, "drop trigger (rollback)")
72+
}
73+
if err := tx.Exec("DROP FUNCTION IF EXISTS delete_orphan_files()").Error; err != nil {
74+
return errors.Wrap(err, "drop function (rollback)")
75+
}
76+
if err := tx.Exec("ALTER TABLE files DROP CONSTRAINT IF EXISTS fk_files_attachment").Error; err != nil {
77+
return errors.Wrap(err, "drop fk_files_attachment (rollback)")
78+
}
79+
if err := tx.Exec("ALTER TABLE files ALTER COLUMN attachment_id SET NOT NULL").Error; err != nil {
80+
return errors.Wrap(err, "make files.attachment_id not null (rollback)")
81+
}
82+
if err := tx.Exec("ALTER TABLE files ADD CONSTRAINT fk_files_attachment FOREIGN KEY (attachment_id) REFERENCES source_attachments(id) ON DELETE NO ACTION").Error; err != nil {
83+
return errors.Wrap(err, "add fk_files_attachment no action (rollback)")
84+
}
85+
return nil
86+
}
87+
if tx.Dialector.Name() == "mysql" {
88+
// restore mysql cascade to match previous behavior on rollback
89+
if err := tx.Exec("ALTER TABLE files DROP FOREIGN KEY fk_files_attachment").Error; err != nil {
90+
}
91+
if err := tx.Exec("ALTER TABLE files ADD CONSTRAINT fk_files_attachment FOREIGN KEY (attachment_id) REFERENCES source_attachments(id) ON DELETE CASCADE").Error; err != nil {
92+
return errors.Wrap(err, "add fk_files_attachment cascade (mysql rollback)")
93+
}
94+
return nil
95+
}
96+
return nil
97+
},
98+
}
99+
}

‎migrate/migrations/migrations.go‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,7 @@ func GetMigrations() []*gormigrate.Migration {
1717
_202507091100_add_tracked_wallet_type(),
1818
_202507180900_create_deal_state_changes(),
1919
_202507180930_create_error_logs(),
20+
_202509171710_wallet_assignments_cascade(),
21+
_202509171745_files_attachment_no_cascade(),
2022
}
2123
}

‎model/migrate.go‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,41 @@ func _init(db *gorm.DB) error {
9797
if err != nil {
9898
return errors.Wrap(err, "failed to auto migrate")
9999
}
100+
101+
// apply postgres-specific fk fixes for clean databases
102+
if db.Dialector.Name() == "postgres" {
103+
if err := db.Exec("ALTER TABLE files ALTER COLUMN attachment_id DROP NOT NULL").Error; err != nil {
104+
return errors.Wrap(err, "make files.attachment_id nullable")
105+
}
106+
if err := db.Exec("ALTER TABLE files DROP CONSTRAINT IF EXISTS fk_files_attachment").Error; err != nil {
107+
return errors.Wrap(err, "drop fk_files_attachment")
108+
}
109+
if err := db.Exec("ALTER TABLE files ADD CONSTRAINT fk_files_attachment FOREIGN KEY (attachment_id) REFERENCES source_attachments(id) ON DELETE SET NULL").Error; err != nil {
110+
return errors.Wrap(err, "add fk_files_attachment set null")
111+
}
112+
113+
if err := db.Exec(`
114+
CREATE OR REPLACE FUNCTION delete_orphan_files() RETURNS trigger AS $$
115+
BEGIN
116+
IF NEW.attachment_id IS NULL THEN
117+
DELETE FROM files WHERE id = NEW.id;
118+
END IF;
119+
RETURN NULL;
120+
END; $$ LANGUAGE plpgsql;
121+
`).Error; err != nil {
122+
return errors.Wrap(err, "create delete_orphan_files function")
123+
}
124+
125+
if err := db.Exec(`
126+
CREATE TRIGGER trg_delete_orphan_files
127+
AFTER UPDATE OF attachment_id ON files
128+
FOR EACH ROW
129+
WHEN (NEW.attachment_id IS NULL)
130+
EXECUTE FUNCTION delete_orphan_files();
131+
`).Error; err != nil {
132+
return errors.Wrap(err, "create trigger")
133+
}
134+
}
100135

101136
logger.Debug("Creating instance id")
102137
err = db.Clauses(clause.OnConflict{

‎model/preparation.go‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"time"
88

99
"encoding/json"
10+
1011
"github.com/cockroachdb/errors"
1112
"github.com/ipfs/go-cid"
1213
"gorm.io/gorm"
@@ -142,7 +143,7 @@ type Preparation struct {
142143

143144
// Associations
144145
DealTemplate *DealTemplate `gorm:"foreignKey:DealTemplateID;constraint:OnDelete:SET NULL" json:"dealTemplate,omitempty" swaggerignore:"true" table:"expand"`
145-
Wallets []Wallet `gorm:"many2many:wallet_assignments" json:"wallets,omitempty" swaggerignore:"true" table:"expand"`
146+
Wallets []Wallet `gorm:"many2many:wallet_assignments;constraint:OnDelete:CASCADE" json:"wallets,omitempty" swaggerignore:"true" table:"expand"`
146147
SourceStorages []Storage `gorm:"many2many:source_attachments;constraint:OnDelete:CASCADE" json:"sourceStorages,omitempty" table:"expand;header:Source Storages:"`
147148
OutputStorages []Storage `gorm:"many2many:output_attachments;constraint:OnDelete:CASCADE" json:"outputStorages,omitempty" table:"expand;header:Output Storages:"`
148149
}
@@ -301,10 +302,10 @@ type File struct {
301302

302303
// Associations
303304
AttachmentID SourceAttachmentID `cbor:"-" json:"attachmentId"`
304-
Attachment *SourceAttachment `cbor:"-" gorm:"foreignKey:AttachmentID;constraint:OnDelete:CASCADE" json:"attachment,omitempty" swaggerignore:"true"`
305-
DirectoryID *DirectoryID `cbor:"-" gorm:"index" json:"directoryId"`
306-
Directory *Directory `cbor:"-" gorm:"foreignKey:DirectoryID;constraint:OnDelete:CASCADE" json:"directory,omitempty" swaggerignore:"true"`
307-
FileRanges []FileRange `cbor:"-" gorm:"constraint:OnDelete:CASCADE" json:"fileRanges,omitempty"`
305+
Attachment *SourceAttachment `cbor:"-" gorm:"foreignKey:AttachmentID" json:"attachment,omitempty" swaggerignore:"true"`
306+
DirectoryID *DirectoryID `cbor:"-" gorm:"index" json:"directoryId"`
307+
Directory *Directory `cbor:"-" gorm:"foreignKey:DirectoryID;constraint:OnDelete:CASCADE" json:"directory,omitempty" swaggerignore:"true"`
308+
FileRanges []FileRange `cbor:"-" gorm:"constraint:OnDelete:CASCADE" json:"fileRanges,omitempty"`
308309
}
309310

310311
func (i File) FileName() string {

‎util/testutil/testutils.go‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,13 @@ func getTestDB(t *testing.T, dialect string) (db *gorm.DB, closer io.Closer, con
9292
var opError *net.OpError
9393
switch dialect {
9494
case "mysql":
95-
connStr = "mysql://singularity:singularity@tcp(localhost:3306)/singularity?parseTime=true"
95+
if socket := os.Getenv("MYSQL_SOCKET"); socket != "" {
96+
connStr = "mysql://singularity:singularity@unix(" + socket + ")/singularity?parseTime=true"
97+
} else {
98+
connStr = "mysql://singularity:singularity@tcp(localhost:3306)/singularity?parseTime=true"
99+
}
96100
case "postgres":
97-
connStr = "postgres://singularity:singularity@localhost:5432/singularity?sslmode=disable"
101+
connStr = "postgres://postgres@localhost:5432/postgres?sslmode=disable"
98102
default:
99103
require.Fail(t, "Unsupported dialect: "+dialect)
100104
}
@@ -183,7 +187,7 @@ func doOne(t *testing.T, backend string, testFunc func(ctx context.Context, t *t
183187
// Clear any existing data from tables with unique constraints
184188
tables := []string{
185189
"output_attachments",
186-
"source_attachments",
190+
"source_attachments",
187191
"storages",
188192
"wallets",
189193
"deal_schedules",
@@ -200,7 +204,7 @@ func doOne(t *testing.T, backend string, testFunc func(ctx context.Context, t *t
200204
err = db.Exec("DELETE FROM " + table).Error
201205
}
202206
if err != nil {
203-
t.Logf("Warning: Failed to clear table %s: %v", table, err)
207+
t.Logf("Warning: Failed to clear table %s: %v", table, err)
204208
// Don't fail the test, as table may not exist yet
205209
}
206210
}

0 commit comments

Comments
 (0)