Skip to content

Commit a851301

Browse files
authored
Apply suggestions from code review
1 parent 809a448 commit a851301

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

spec/draft/design_topics/data_interchange.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,11 @@ While initially intended to target file formats, binsparse has relatively few re
9898
back-ends:
9999

100100
1. The ability to represent and parse JSON.
101-
2. To be able to represent/store a key-value store of 1-dimensional (and optionally 2-dimensional)
101+
2. The ability to represent/store a key-value store of 1-dimensional (and optionally 2-dimensional)
102102
arrays.
103103

104104
It is the only such specification for sparse representations to have these minimal requirements.
105-
We can satisfy both: The former with the ``json`` built-in Python module or a Python ``dict`` and
105+
We can satisfy both: the former with the ``json`` built-in Python module or a Python ``dict`` and
106106
the latter with the DLPack protocol.
107107

108108
.. note::

src/array_api_stubs/_draft/array_object.py

-6
Original file line numberDiff line numberDiff line change
@@ -1259,9 +1259,6 @@ def __binsparse_descriptor__(self) -> dict:
12591259
-------
12601260
out: dict
12611261
A ``dict`` equivalent to a parsed JSON binsparse descriptor of an array. See :ref:`sparse_interchange` for details.
1262-
1263-
1264-
.. versionadded:: 2025.12
12651262
"""
12661263

12671264
def __binsparse__(self) -> dict[str, array]:
@@ -1277,9 +1274,6 @@ def __binsparse__(self) -> dict[str, array]:
12771274
-------
12781275
out: dict[str, array]
12791276
A ``dict`` equivalent to a parsed JSON binsparse descriptor of an array. See :ref:`sparse_interchange` for details.
1280-
1281-
1282-
.. versionadded:: 2025.12
12831277
"""
12841278

12851279

src/array_api_stubs/_draft/creation_functions.py

+1-4
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ def from_binsparse(arrays: dict[str, array], descriptor: dict, /) -> array:
657657
arrays: dict[str, array]
658658
input constituent arrays.
659659
descriptor: dict
660-
The parsed binsparse descriptor of the array.
660+
the parsed binsparse descriptor of the array.
661661
662662
Returns
663663
-------
@@ -668,7 +668,4 @@ def from_binsparse(arrays: dict[str, array], descriptor: dict, /) -> array:
668668
:class: note
669669
670670
The returned array may be either a copy or a view. See :ref:`data-interchange` for details.
671-
672-
673-
.. versionadded:: 2025.12
674671
"""

0 commit comments

Comments
 (0)