Skip to content

Commit 8cc69e4

Browse files
committed
TST: dask tests are extremely flaky
1 parent 289203e commit 8cc69e4

File tree

4 files changed

+12
-20
lines changed

4 files changed

+12
-20
lines changed

.github/workflows/array-api-tests-dask.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,5 @@ jobs:
1010
package-version: '>= 2024.9.0'
1111
module-name: dask.array
1212
extra-requires: numpy
13-
pytest-extra-args: --disable-deadline --max-examples=5
13+
# Remove thread synchronization overhead to speed up tests
14+
extra-env-vars: DASK_SCHEDULER=sync

.github/workflows/array-api-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ on:
3333
description: "Multiline string of environment variables to set for the test run."
3434

3535
env:
36-
PYTEST_ARGS: "--max-examples 200 -v -rxXfE --ci ${{ inputs.pytest-extra-args }} --hypothesis-disable-deadline"
36+
PYTEST_ARGS: "--max-examples 200 -v -rxXfE --ci ${{ inputs.pytest-extra-args }} --hypothesis-disable-deadline --durations 10"
3737

3838
jobs:
3939
tests:

dask-skips.txt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,2 @@
1-
# slow and not implemented in dask
2-
array_api_tests/test_linalg.py::test_matrix_power
3-
4-
# hangs on 2024.12
5-
array_api_tests/test_creation_functions.py::test_eye
1+
# Passes, but extremely slow
2+
array_api_tests/test_linalg.py::test_outer

dask-xfails.txt

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# Shape mismatch; needs high priority investigation
2+
array_api_tests/test_array_object.py::test_setitem
3+
array_api_tests/test_indexing_functions.py::test_take
4+
15
# Various indexing errors
26
array_api_tests/test_array_object.py::test_getitem_masking
37

@@ -85,32 +89,24 @@ array_api_tests/test_has_names.py::test_has_names[array_method-__dlpack_device__
8589
# No mT on dask array
8690
array_api_tests/meta/test_hypothesis_helpers.py::test_symmetric_matrices
8791

88-
# Edge case of args near 2**63
89-
# https://github.com/dask/dask/issues/11706
90-
array_api_tests/test_creation_functions.py::test_arange
92+
# da.searchsorted with a sorter argument is not supported
93+
array_api_tests/test_searching_functions.py::test_searchsorted
9194

9295
# 2023.12 support
9396
array_api_tests/test_manipulation_functions.py::test_repeat
9497

9598
# 2024.12 support
96-
array_api_tests/test_array_object.py::test_setitem
9799
array_api_tests/test_array_object.py::test_getitem_arrays_and_ints_1[1]
98100
array_api_tests/test_array_object.py::test_getitem_arrays_and_ints_1[None]
99101
array_api_tests/test_array_object.py::test_getitem_arrays_and_ints_2[1]
100102
array_api_tests/test_array_object.py::test_getitem_arrays_and_ints_2[None]
101103
array_api_tests/test_has_names.py::test_has_names[indexing-take_along_axis]
102104
array_api_tests/test_signatures.py::test_func_signature[take_along_axis]
103-
104105
array_api_tests/test_linalg.py::test_cholesky
105106
array_api_tests/test_linalg.py::test_linalg_matmul
107+
array_api_tests/test_linalg.py::test_matmul
106108
array_api_tests/test_linalg.py::test_matrix_norm
107109
array_api_tests/test_linalg.py::test_qr
108-
array_api_tests/test_manipulation_functions.py::test_concat
109-
array_api_tests/test_manipulation_functions.py::test_roll
110-
array_api_tests/test_operators_and_elementwise_functions.py::test_add[add(x1, x2)]
111-
array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_left_shift[bitwise_left_shift(x1, x2)]
112-
array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_right_shift[bitwise_right_shift(x1, x2)]
113-
array_api_tests/test_operators_and_elementwise_functions.py::test_greater[__gt__(x1, x2)]
114110
array_api_tests/test_signatures.py::test_func_signature[count_nonzero]
115111
array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is +infinity and isfinite(x2_i) and x2_i > 0) -> +infinity]
116112
array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is +infinity and isfinite(x2_i) and x2_i < 0) -> -infinity]
@@ -131,5 +127,3 @@ array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(x1_i is -infinity
131127
array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(isfinite(x1_i) and x1_i > 0 and x2_i is -infinity) -> -0]
132128
array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(isfinite(x1_i) and x1_i < 0 and x2_i is +infinity) -> -0]
133129
array_api_tests/test_special_cases.py::test_nan_propagation[cumulative_prod]
134-
135-

0 commit comments

Comments
 (0)