Skip to content

Commit 1c29125

Browse files
authored
[ DWDS ] Disconnect non-DDS clients when DDS connects (#2671)
The native VM service disconnects all non-DDS clients when DDS connects in order to keep state consistent. DWDS was never configured to work this way and, instead, would not let DDS connect if there were already existing clients. This is fine most of the time, as DDS is typically the first client, but in cases where multiple DDS instances attempt to start at once (e.g., a simultaneous `flutter run` and `flutter attach`), this inconsistency prevents tools from falling back to using an already connected DDS instance, as seen in flutter/flutter#171758. Fixes #2399
1 parent b947357 commit 1c29125

File tree

7 files changed

+1229
-819
lines changed

7 files changed

+1229
-819
lines changed

dwds/CHANGELOG.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
## 25.0.2
2+
3+
### Bug Fixes:
4+
5+
- Fix issue where DDS would fail to initialize if DWDS already had existing
6+
clients.
7+
18
## 25.0.1
29

310
### Bug Fixes:
@@ -73,6 +80,7 @@
7380
libraries instead of assuming it exists in the global `window`.
7481

7582
## 24.3.5
83+
7684
- Allow clients to specify the `packageConfigPath` in `LoadStrategy` class and associated providers.
7785

7886
## 24.3.4
@@ -157,7 +165,7 @@
157165

158166
## 23.1.1
159167

160-
- Loosen `package:vm_service` constraints to allow `>=13.0.0 <15.0.0`. - [#2329](https://github.com/dart-lang/webdev/pull/2329)
168+
- Loosen `package:vm_service` constraints to allow `>=13.0.0 <15.0.0`. - [#2329](https://github.com/dart-lang/webdev/pull/2329)
161169

162170
## 23.1.0
163171

0 commit comments

Comments
 (0)