-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Language tests for the Q1 2021 small features release. #44926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Making a note that we may need additional test coverage for any spec updates based on this issue. |
cc @srawlins @stefantsov @johnniwinther @scheglov @devoncarew for visibility on anything landed here. |
Note that @lrhn did much of this work already: Landed: https://dart-review.googlesource.com/c/sdk/+/180844 adds tests for dart-lang/language#496, https://dart-review.googlesource.com/c/sdk/+/180843 adds tests for dart-lang/language#120. Under review: https://dart-review.googlesource.com/c/sdk/+/185583 adds tests for dart-lang/language#1297. |
I think we seriously need some more test coverage here. There are no static error tests at all that I see in the language directory for this. c.f. #45394 for an issue found accidentally. |
It would also be good to get more runtime type test coverage for this, e.g. tests that casts to generic type parameters work correctly (both pass when appropriate, and throw when appropriate) when the parameter is instantiated with a generic function. |
…ing bounds. Bug: #44926 Change-Id: I92209fc4839c7d286f5efc5d9deb05e47e6cf017 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192280 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
This tracks writing language tests for this feature set.
cc @lrhn @eernstg @franklinyow
The text was updated successfully, but these errors were encountered: