Skip to content

Commit ebcae76

Browse files
davidmorganCommit Queue
authored andcommitted
[macros] Replace hardcoded skip with status file skip.
[email protected] Change-Id: I50a41ebadd71b65761613e2ac2259152d1433ddd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355923 Auto-Submit: Morgan :) <[email protected]> Reviewed-by: William Hesse <[email protected]> Commit-Queue: Morgan :) <[email protected]>
1 parent 9293d2f commit ebcae76

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

tests/macro_build/macro_build.status

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
11
# Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
22
# for details. All rights reserved. Use of this source code is governed by a
33
# BSD-style license that can be found in the LICENSE file.
4+
5+
[ $arch != x64 || $mode != debug || $system != linux ]
6+
*: Skip # linux-debug-x64 is enough coverage for now.
7+
8+
[ $compiler != dartk || $runtime != vm ]
9+
*: SkipByDesign # Actual tests are launched in subprocesses.

tests/macro_build/tester/tester.dart

100755100644
Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@ runner to ensure they are built and not stale:
4343
./tools/test.py -v -nunittest-asserts-release-linux-x64 \
4444
--build 'tests/macro_build/*'
4545
''');
46-
} else if (configuration != 'unittest-asserts-release-linux-x64') {
47-
print('Skipping test, not yet supported on '
48-
'-Dtest_runner.configuration=$configuration, '
49-
'use unittest-asserts-release-linux-x64.');
50-
return;
5146
}
5247

5348
_fixPubspec(

0 commit comments

Comments
 (0)