Remove (most) uses of the "non-nullable" experiment flag.

Since the flag is now enabled by default, there should be no mention of it.
There are still some uses in front_end/testcases that are not just removable
(it also uses `no-non-nullable`). There migth be more uses that are not
as easily found as grepping for `--enable-experiment

Removes two VM tests where fixing them meant they were just duplicating
the corresponding non *_2/ tests.
Fixes #44941

TEST= Large number of tests chaged.=(no-)?non-nullable`.

Change-Id: Ief755981ccde9a5482fcdf408c2929c74433a710
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183688
Commit-Queue: Lasse R.H. Nielsen <[email protected]>
Reviewed-by: Nate Bosch <[email protected]>

Author: lrhn

pkg/compiler/test/codegen/codegen_test_helper.dart

@@ -33,7 +33,7 @@ runTests(List<String> args, [int shardIndex]) {
       shards: 2,
       directory: 'data',
       skip: skip,
-      options: ['--enable-experiment=non-nullable', Flags.soundNullSafety]);
+      options: [Flags.soundNullSafety]);
 }
 
 runTests2(List<String> args, [int shardIndex]) {

pkg/compiler/tool/modular_test_suite.dart

@@ -219,7 +219,6 @@ class SourceToDillStep implements IOModularStep {
           .expand((m) => ['--input-linked', '${toUri(m, dillId)}'])),
       ...(sources.expand((String uri) => ['--source', uri])),
       ...(flags.expand((String flag) => ['--enable-experiment', flag])),
-      '--enable-experiment=non-nullable',
     ];
 
     var result =

pkg/dartdev/test/commands/pub_test.dart

@@ -71,26 +71,6 @@ void pub() {
     expect(result.stderr, result2.stderr);
   });
 
-  test('run --enable-experiment', () {
-    p = project();
-    p.file('bin/main.dart',
-        "void main() { int? a; a = null; print('a is \$a.'); }");
-
-    // run 'pub get'
-    p.runSync(['pub', 'get']);
-
-    var result = p.runSync(
-        ['pub', 'run', '--enable-experiment=no-non-nullable', 'main.dart']);
-
-    expect(result.exitCode, 254);
-    expect(result.stdout, isEmpty);
-    expect(
-        result.stderr,
-        contains('bin/main.dart:1:18: Error: This requires the null safety '
-            'language feature, which requires language version of 2.12 or '
-            'higher.\n'));
-  });
-
   test('failure', () {
     p = project(mainSrc: 'int get foo => 1;\n');
     var result = p.runSync(['pub', 'deps']);

pkg/dev_compiler/tool/check_nnbd_sdk.dart

@@ -117,15 +117,12 @@ main() {}
   var result = Process.runSync(dart.toFilePath(), [
     // The NNBD dart binaries / snapshots require this flag to be enabled at
     // VM level.
-    if (analyzerSnapshot.contains('NNBD')) '--enable-experiment=non-nullable',
     analyzerSnapshot,
     '--dart-sdk=${sdkDir}',
     '--format',
     'machine',
     '--sdk-warnings',
     '--no-hints',
-    '--enable-experiment',
-    'non-nullable',
     emptyProgramUri.toFilePath()
   ]);
 

pkg/front_end/test/fasta/testing/suite.dart

@@ -788,7 +788,6 @@ class Run extends Step<ComponentResult, ComponentResult, FastaContext> {
         try {
           var args = <String>[];
           if (experimentalFlags[ExperimentalFlag.nonNullable] == true) {
-            args.add("--enable-experiment=non-nullable");
             if (!context.weak) {
               args.add("--sound-null-safety");
             }

pkg/frontend_server/test/frontend_server_test.dart

@@ -1761,7 +1761,6 @@ class BarState extends State<FizzWidget> {
         '--output-dill=${dillFile.path}',
         '--packages=${package_config.path}',
         '--target=dartdevc',
-        '--enable-experiment=non-nullable',
         file.path,
       ];
 
@@ -1915,7 +1914,6 @@ class BarState extends State<FizzWidget> {
         '--output-dill=${dillFile.path}',
         '--target=dartdevc',
         '--packages=${package_config.path}',
-        '--enable-experiment=non-nullable',
       ];
 
       final StreamController<List<int>> streamController =
@@ -1996,7 +1994,6 @@ class BarState extends State<FizzWidget> {
         '--target=dartdevc',
         '--packages=${package_config.path}',
         '--experimental-emit-debug-metadata',
-        '--enable-experiment=non-nullable',
       ];
 
       final StreamController<List<int>> streamController =
@@ -2243,7 +2240,6 @@ class BarState extends State<FizzWidget> {
         '--output-dill=${dillFile.path}',
         '--target=dartdevc',
         '--packages=${package_config.path}',
-        '--enable-experiment=non-nullable',
       ];
 
       final StreamController<List<int>> streamController =
@@ -2362,7 +2358,6 @@ class BarState extends State<FizzWidget> {
         '--output-dill=${dillFile.path}',
         '--target=dartdevc',
         '--packages=${package_config.path}',
-        '--enable-experiment=non-nullable'
       ];
 
       final StreamController<List<int>> streamController =

runtime/bin/BUILD.gn

@@ -496,7 +496,6 @@ gen_snapshot_action("generate_snapshot_bin") {
     isolate_snapshot_instructions,
   ]
   args = [
-    "--enable-experiment=non-nullable",
     "--sound-null-safety",
     "--deterministic",
     "--snapshot_kind=" + dart_core_snapshot_kind,

runtime/tests/vm/dart/null_safety_autodetection_in_kernel_compiler_test.dart

@@ -29,7 +29,6 @@ compileAndRunTest(String comment, String expectedOutput) async {
     await runGenKernelWithoutStandardOptions('BUILD DILL FILE', [
       "--platform",
       platformDill,
-      '--enable-experiment=non-nullable',
       '--output=$testDillPath',
       testScriptPath,
     ]);

runtime/tests/vm/dart/type_casts_with_null_safety_autodetection_test.dart

@@ -22,7 +22,6 @@ runTest(String script, String output, String temp) async {
   // Do not add Platform.executableArguments into arguments to avoid passing
   // --sound-null-safety / --no-sound-null-safety arguments.
   final result = await runBinary("RUN $script", Platform.executable, [
-    '--enable-experiment=non-nullable',
     '--deterministic',
     '--optimization-counter-threshold=10',
     '--packages=${Platform.packageConfig}',

runtime/tests/vm/dart_2/null_safety_autodetection_in_kernel_compiler_test.dart

@@ -29,7 +29,6 @@ compileAndRunTest(String comment, String expectedOutput) async {
     await runGenKernelWithoutStandardOptions('BUILD DILL FILE', [
       "--platform",
       platformDill,
-      '--enable-experiment=non-nullable',
       '--output=$testDillPath',
       testScriptPath,
     ]);