[test] Disable regress_53519_test in obfuscated/dwarf mode

Also reverts https://dart-review.googlesource.com/c/sdk/+/354840,
which attempted the same thing. The vmOptions are not parsed
correctly on the bots.

Fixes: https://github.com/dart-lang/sdk/issues/550599
Change-Id: I05c7184ffb6d303309714a667d209d3621dcc348
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355960
Commit-Queue: Liam Appelbe <[email protected]>
Reviewed-by: Ryan Macnak <[email protected]>

Author: liamappelbe

pkg/expect/lib/config.dart

@@ -31,12 +31,6 @@ bool get isVmJitConfiguration => _configuration.compiler == Compiler.dartk;
 
 bool get isVmAotConfiguration => _configuration.compiler == Compiler.dartkp;
 
-bool get isVmDwarfConfiguration =>
-    _configuration.vmOptions.contains('--dwarf_stack_traces');
-
-bool get isVmObfuscateConfiguration =>
-    _configuration.vmOptions.contains('--obfuscate');
-
 bool get isVmConfiguration => isVmJitConfiguration || isVmAotConfiguration;
 
 bool get isWebConfiguration =>

tests/standalone/regress_53519_test.dart

@@ -6,18 +6,13 @@
 // Regression test for https://github.com/dart-lang/sdk/issues/53519
 
 import 'package:expect/expect.dart';
-import 'package:expect/config.dart';
 
 String destructure(Map<String, dynamic> map) {
   final {'hello': world, 'count': count} = map;
   return 'Hello $world, count: $count';
 }
 
 main() {
-  // Stringification of stack traces is only valid in non-obfuscated & non-dwarf
-  // mode.
-  if (isVmObfuscateConfiguration || isVmDwarfConfiguration) return;
-
   try {
     destructure({
       'hello': 'world',
@@ -26,7 +21,7 @@ main() {
   } catch (e, s) {
     print(s);
     // Expect that the stack trace contains an entry for the destructure
-    // function at line 12.
-    Expect.isTrue(s.toString().contains(RegExp(r'destructure \(.*:12(:3)?\)')));
+    // function at line 11.
+    Expect.isTrue(s.toString().contains(RegExp(r'destructure \(.*:11(:3)?\)')));
   }
 }

tests/standalone/standalone.status

@@ -16,6 +16,7 @@ package/scenarios/invalid/non_existent_packages_file_test: CompileTimeError
 
 [ $builder_tag == dwarf ]
 io/socket_connect_stacktrace_test: SkipByDesign # Assumes stacktrace can be inspected directly, without decoding
+regress_53519_test.dart: SkipByDesign # Relies on symbolic stack traces.
 stack_trace/full1_test: SkipByDesign # Relies on symbolic stack traces.
 stack_trace/full2_test: SkipByDesign # Relies on symbolic stack traces.
 stack_trace/full3_test: SkipByDesign # Relies on symbolic stack traces.
@@ -38,6 +39,7 @@ io/socket_source_address_test: SkipByDesign
 
 [ $builder_tag == obfuscated ]
 no_such_method_error_with_invocation_test: SkipByDesign # Checks the member names in the NSM error message.
+regress_53519_test.dart: SkipByDesign # Relies on symbolic stack traces.
 
 [ $compiler == app_jitk ]
 io/socket_sigpipe_test: SkipByDesign # Spawns server process using Platform.executable