Completion. Move 'allowedIdentifiers' to the top of test methods.

Change-Id: Ibed4bd2c284e3b90f1b5477a22c5559857530e51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357981
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/test/services/completion/dart/location/is_expression_test.dart

@@ -79,12 +79,12 @@ suggestions
   }
 
   Future<void> test_identifierStart() async {
+    allowedIdentifiers = {'isFoo'};
     await computeSuggestions('''
 static void f(bool isFoo) {
   is^
 }
 ''');
-    allowedIdentifiers = {'isFoo'};
     assertResponse(r'''
 replacement
   left: 2
@@ -95,18 +95,19 @@ suggestions
   }
 
   Future<void> test_identifierStart_notAtEndOfIs() async {
+    allowedIdentifiers = {'isFoo'};
     await computeSuggestions('''
 static void f(bool isFoo) {
   is ^
 }
 ''');
-    allowedIdentifiers = {'isFoo'};
     assertResponse(r'''
 suggestions
 ''');
   }
 
   Future<void> test_identifierStart_staticContext() async {
+    allowedIdentifiers = {'isF1', 'isF2'};
     await computeSuggestions('''
 class A {
   static bool get isF1 => false;
@@ -116,7 +117,6 @@ class A {
   }
 }
 ''');
-    allowedIdentifiers = {'isF1', 'isF2'};
     assertResponse(r'''
 replacement
   left: 2
@@ -127,12 +127,12 @@ suggestions
   }
 
   Future<void> test_identifierStart_voidFunction() async {
+    allowedIdentifiers = {'isFoo'};
     await computeSuggestions('''
 static void isFoo() {
   is^
 }
 ''');
-    allowedIdentifiers = {'isFoo'};
     assertResponse(r'''
 replacement
   left: 2

pkg/analysis_server/test/services/completion/dart/location/property_access_expression_test.dart

@@ -17,6 +17,7 @@ class PropertyAccessTest extends AbstractCompletionDriverTest
     with PropertyAccessTestCases {
   @failingTest
   Future<void> test_afterIdentifier_partial_if() async {
+    allowedIdentifiers = {'always', 'ifPresent'};
     await computeSuggestions('''
 enum E {
   always, ifPresent
@@ -25,7 +26,6 @@ void f() {
   E.if^;
 }
 ''');
-    allowedIdentifiers = {'always', 'ifPresent'};
     assertResponse(r'''
 replacement
   left: 2
@@ -94,13 +94,13 @@ suggestions
   }
 
   Future<void> test_afterIdentifier_beforeIdentifier_partial() async {
+    allowedIdentifiers = {'length'};
     await computeSuggestions('''
 void f(String x) {
   x.len^
   foo();
 }
 ''');
-    allowedIdentifiers = {'length'};
     assertResponse(r'''
 replacement
   left: 3