Rename

Author: mosuem

pkgs/code_assets/doc/schema/shared/shared_definitions.generated.schema.json

@@ -42,7 +42,7 @@
                 "$ref": "shared_definitions.schema.json#/definitions/Asset"
               }
             },
-            "assets_for_link": {
+            "assets_for_linking": {
               "type": "object",
               "additionalProperties": {
                 "type": "array",

pkgs/code_assets/test/data/build_output_macos.json

@@ -62,7 +62,7 @@
       "type": "code_assets/code"
     }
   ],
-  "assets_for_link": {
+  "assets_for_linking": {
     "package_with_linker": [
       {
         "encoding": {

pkgs/code_assets/test/json_schema/schema_test.dart

@@ -123,7 +123,7 @@ FieldsFunction _codeFields(AllTestData allTestData) {
           for (final (field, expect) in codeAssetFields)
             for (final path in [
               ['assets_for_build'],
-              ['assets_for_link', 'package_with_linker'],
+              ['assets_for_linking', 'package_with_linker'],
             ])
               ([...path, 0, 'encoding', ...field], expect),
         ],

pkgs/data_assets/doc/schema/shared/shared_definitions.generated.schema.json

@@ -42,7 +42,7 @@
                 "$ref": "shared_definitions.schema.json#/definitions/Asset"
               }
             },
-            "assets_for_link": {
+            "assets_for_linking": {
               "type": "object",
               "additionalProperties": {
                 "type": "array",

pkgs/data_assets/test/data/build_output.json

@@ -36,7 +36,7 @@
       "type": "data_assets/data"
     }
   ],
-  "assets_for_link": {
+  "assets_for_linking": {
     "package_with_linker": [
       {
         "encoding": {

pkgs/data_assets/test/json_schema/schema_test.dart

@@ -55,7 +55,7 @@ List<(List<Object>, void Function(ValidationResults result))> _dataFields({
       for (final field in _dataAssetFields)
         for (final path in [
           ['assets_for_build'],
-          ['assets_for_link', 'package_with_linker'],
+          ['assets_for_linking', 'package_with_linker'],
         ])
           ([...path, 0, 'encoding', field], expectRequiredFieldMissing),
     ],

pkgs/hooks/doc/schema/shared/shared_definitions.schema.json

@@ -197,7 +197,7 @@
             "$ref": "#/definitions/Asset"
           }
         },
-        "assets_for_link": {
+        "assets_for_linking": {
           "type": "object",
           "additionalProperties": {
             "type": "array",

pkgs/hooks/lib/src/config.dart

@@ -479,7 +479,7 @@ sealed class HookOutputBuilder {
     dependencies: null,
     status: OutputStatusSyntax.success,
     failureDetails: null,
-    assetsForLink: {},
+    assetsForLinking: {},
   );
 
   /// The JSON representation of this hook output builder.
@@ -531,7 +531,8 @@ final class BuildOutput extends HookOutput implements BuildOutputMaybeFailure {
   /// bundled with the application, but are sent to the link hook of the package
   /// specified in the key, which can decide if they are bundled or not.
   Map<String, List<EncodedAsset>> get _encodedAssetsForLinking => {
-    for (final MapEntry(:key, :value) in (_syntax.assetsForLink ?? {}).entries)
+    for (final MapEntry(:key, :value)
+        in (_syntax.assetsForLinking ?? {}).entries)
       key: EncodedAssetSyntax._fromSyntax(value),
   };
 
@@ -742,10 +743,12 @@ final class BuildOutputAssetsBuilder {
         _syntax.assetsForBuild = assets;
       case ToLinkHook():
         final packageName = routing.packageName;
-        final assetsForLink = _syntax.assetsForLink ?? {};
-        assetsForLink[packageName] ??= [];
-        assetsForLink[packageName]!.add(AssetSyntax.fromJson(asset.toJson()));
-        _syntax.assetsForLink = assetsForLink;
+        final assetsForLinking = _syntax.assetsForLinking ?? {};
+        assetsForLinking[packageName] ??= [];
+        assetsForLinking[packageName]!.add(
+          AssetSyntax.fromJson(asset.toJson()),
+        );
+        _syntax.assetsForLinking = assetsForLinking;
     }
   }
 
@@ -783,12 +786,12 @@ final class BuildOutputAssetsBuilder {
         _syntax.assetsForBuild = list;
       case ToLinkHook():
         final linkInPackage = routing.packageName;
-        final assetsForLink = _syntax.assetsForLink ?? {};
-        final list = assetsForLink[linkInPackage] ??= [];
+        final assetsForLinking = _syntax.assetsForLinking ?? {};
+        final list = assetsForLinking[linkInPackage] ??= [];
         for (final asset in assets) {
           list.add(AssetSyntax.fromJson(asset.toJson()));
         }
-        _syntax.assetsForLink = assetsForLink;
+        _syntax.assetsForLinking = assetsForLinking;
     }
   }
 
@@ -806,7 +809,8 @@ final class LinkOutput extends HookOutput implements LinkOutputMaybeFailure {
   /// bundled with the application, but are sent to the link hook of the package
   /// specified in the key, which can decide what to do with them.
   Map<String, List<EncodedAsset>> get _encodedAssetsForLink => {
-    for (final MapEntry(:key, :value) in (_syntax.assetsForLink ?? {}).entries)
+    for (final MapEntry(:key, :value)
+        in (_syntax.assetsForLinking ?? {}).entries)
       key: EncodedAssetSyntax._fromSyntax(value),
   };
 
@@ -891,12 +895,12 @@ final class LinkOutputAssetsBuilder {
         _syntax.assets = assets;
       case ToLinkHook():
         final packageName = routing.packageName;
-        final assetsForLinking = _syntax.assetsForLink ?? {};
+        final assetsForLinking = _syntax.assetsForLinking ?? {};
         assetsForLinking[packageName] ??= [];
         assetsForLinking[packageName]!.add(
           AssetSyntax.fromJson(asset.toJson()),
         );
-        _syntax.assetsForLink = assetsForLinking;
+        _syntax.assetsForLinking = assetsForLinking;
     }
   }
 
@@ -926,12 +930,12 @@ final class LinkOutputAssetsBuilder {
         _syntax.assets = list;
       case ToLinkHook():
         final linkInPackage = routing.packageName;
-        final assetsForLinking = _syntax.assetsForLink ?? {};
+        final assetsForLinking = _syntax.assetsForLinking ?? {};
         final list = assetsForLinking[linkInPackage] ??= [];
         for (final asset in assets) {
           list.add(AssetSyntax.fromJson(asset.toJson()));
         }
-        _syntax.assetsForLink = assetsForLinking;
+        _syntax.assetsForLinking = assetsForLinking;
     }
   }
 

pkgs/hooks/lib/src/hooks/syntax.g.dart

@@ -216,7 +216,7 @@ class BuildOutputSyntax extends HookOutputSyntax {
   BuildOutputSyntax({
     required super.assets,
     required List<AssetSyntax>? assetsForBuild,
-    required super.assetsForLink,
+    required super.assetsForLinking,
     required super.dependencies,
     required super.failureDetails,
     required super.status,
@@ -519,14 +519,14 @@ class HookOutputSyntax extends JsonObjectSyntax {
 
   HookOutputSyntax({
     required List<AssetSyntax>? assets,
-    required Map<String, List<AssetSyntax>>? assetsForLink,
+    required Map<String, List<AssetSyntax>>? assetsForLinking,
     required List<Uri>? dependencies,
     required FailureSyntax? failureDetails,
     required OutputStatusSyntax? status,
     required String timestamp,
   }) : super() {
     this.assets = assets;
-    this.assetsForLink = assetsForLink;
+    this.assetsForLinking = assetsForLinking;
     this.dependencies = dependencies;
     this.failureDetails = failureDetails;
     this.status = status;
@@ -569,8 +569,8 @@ class HookOutputSyntax extends JsonObjectSyntax {
     return [for (final element in elements) ...element.validate()];
   }
 
-  Map<String, List<AssetSyntax>>? get assetsForLink {
-    final jsonValue = _reader.optionalMap('assets_for_link');
+  Map<String, List<AssetSyntax>>? get assetsForLinking {
+    final jsonValue = _reader.optionalMap('assets_for_linking');
     if (jsonValue == null) {
       return null;
     }
@@ -587,29 +587,29 @@ class HookOutputSyntax extends JsonObjectSyntax {
     return result;
   }
 
-  set assetsForLink(Map<String, List<AssetSyntax>>? value) {
+  set assetsForLinking(Map<String, List<AssetSyntax>>? value) {
     if (value == null) {
-      json.remove('assets_for_link');
+      json.remove('assets_for_linking');
     } else {
-      json['assets_for_link'] = {
+      json['assets_for_linking'] = {
         for (final MapEntry(:key, :value) in value.entries)
           key: [for (final item in value) item.json],
       };
     }
     json.sortOnKey();
   }
 
-  List<String> _validateAssetsForLink() {
-    final mapErrors = _reader.validateOptionalMap('assets_for_link');
+  List<String> _validateAssetsForLinking() {
+    final mapErrors = _reader.validateOptionalMap('assets_for_linking');
     if (mapErrors.isNotEmpty) {
       return mapErrors;
     }
-    final jsonValue = _reader.optionalMap('assets_for_link');
+    final jsonValue = _reader.optionalMap('assets_for_linking');
     if (jsonValue == null) {
       return [];
     }
     final result = <String>[];
-    for (final list in assetsForLink!.values) {
+    for (final list in assetsForLinking!.values) {
       for (final element in list) {
         result.addAll(element.validate());
       }
@@ -677,7 +677,7 @@ class HookOutputSyntax extends JsonObjectSyntax {
   List<String> validate() => [
     ...super.validate(),
     ..._validateAssets(),
-    ..._validateAssetsForLink(),
+    ..._validateAssetsForLinking(),
     ..._validateDependencies(),
     ..._validateFailureDetails(),
     ..._validateStatus(),
@@ -860,7 +860,7 @@ class LinkOutputSyntax extends HookOutputSyntax {
 
   LinkOutputSyntax({
     required super.assets,
-    required super.assetsForLink,
+    required super.assetsForLinking,
     required super.dependencies,
     required super.failureDetails,
     required super.status,

pkgs/hooks/test/build_output_test.dart

@@ -74,7 +74,7 @@ void main() {
           'type': 'my-asset-type',
         },
       ],
-      'assets_for_link': {
+      'assets_for_linking': {
         'package:linker1': [
           {
             'encoding': {'a-1': 'v-1'},