[native_assets_cli] Replace extension types with classes (#2251)

This PR replaces all extension types with classes.

This PR renames all classes that mostly belong to another class to start with the name of that class.

I'm not entirely satisfied with how this looks, but I think it's a step in the right direction.

The Dart docs can be inspected by `pkgs/native_assets_cli$ dart doc .`.

Open question:

* Should we _not_ export all those helper classes? That would prevent users using these types in their code. But this would be considered a leaked symbol. So this probably doesn't work.
* Should we not generate dartdocs for those helper classes. They usually simply have an `add`, `addAll` or `operator []`. The interesting doc comments are on the accessors that return those classes.

Context:

* Work before splitting up the package: #999

Author: dcharkes

pkgs/native_assets_cli/lib/code_assets.dart

@@ -13,17 +13,17 @@ export 'src/code_assets/code_asset.dart'
 export 'src/code_assets/config.dart'
     show
         AndroidCodeConfig,
-        CodeAssetBuildOutputBuilder,
-        CodeAssetBuildOutputBuilderAdd,
-        CodeAssetHookConfig,
-        CodeAssetLinkInput,
-        CodeAssetLinkOutputBuilder,
-        CodeAssetLinkOutputBuilderAdd,
+        BuildOutputAssetsBuilderCode,
+        BuildOutputCodeAssetBuilder,
+        BuildOutputCodeAssets,
         CodeConfig,
+        HookConfigCodeConfig,
         IOSCodeConfig,
+        LinkInputCodeAssets,
+        LinkOutputAssetsBuilderCode,
+        LinkOutputCodeAssetBuilder,
+        LinkOutputCodeAssets,
         MacOSCodeConfig;
-export 'src/code_assets/config.dart'
-    show CodeAssetBuildOutput, CodeAssetLinkOutput;
 export 'src/code_assets/extension.dart';
 export 'src/code_assets/ios_sdk.dart' show IOSSdk;
 export 'src/code_assets/link_mode.dart'

pkgs/native_assets_cli/lib/data_assets.dart

@@ -7,14 +7,14 @@ library;
 
 export 'src/data_assets/config.dart'
     show
-        AddDataAssetsDirectory,
-        DataAssetBuildOutputBuilder,
-        DataAssetBuildOutputBuilderAdd,
-        DataAssetHookConfig,
-        DataAssetLinkInput,
-        DataAssetLinkOutputBuilder,
-        DataAssetLinkOutputBuilderAdd;
-export 'src/data_assets/config.dart'
-    show DataAssetBuildInputBuilder, DataAssetBuildOutput, DataAssetLinkOutput;
+        BuildOutputAssetsBuilderData,
+        BuildOutputBuilderAddDataAssetsDirectories,
+        BuildOutputDataAssets,
+        BuildOutputDataAssetsBuilder,
+        HookConfigDataConfig,
+        LinkInputDataAssets,
+        LinkOutputAssetsBuilderData,
+        LinkOutputDataAssets,
+        LinkOutputDataAssetsBuilder;
 export 'src/data_assets/data_asset.dart' show DataAsset, EncodedDataAsset;
 export 'src/data_assets/extension.dart';

pkgs/native_assets_cli/lib/native_assets_cli.dart

@@ -15,24 +15,30 @@ export 'src/config.dart'
         AssetRouting,
         BuildConfig,
         BuildConfigBuilder,
-        BuildConfigBuilderSetup,
         BuildInput,
+        BuildInputAssets,
         BuildInputBuilder,
+        BuildInputMetadata,
         BuildOutput,
+        BuildOutputAssets,
+        BuildOutputAssetsBuilder,
         BuildOutputBuilder,
-        EncodedAssetBuildOutputBuilder,
-        EncodedAssetLinkOutputBuilder,
+        BuildOutputMetadataBuilder,
         HookConfig,
         HookConfigBuilder,
         HookInput,
         HookInputBuilder,
+        HookInputUserDefines,
         HookOutput,
         HookOutputBuilder,
         LinkConfig,
         LinkConfigBuilder,
         LinkInput,
+        LinkInputAssets,
         LinkInputBuilder,
         LinkOutput,
+        LinkOutputAssets,
+        LinkOutputAssetsBuilder,
         LinkOutputBuilder,
         PackageMetadata,
         ToAppBundle,

pkgs/native_assets_cli/lib/src/api/builder.dart

@@ -5,9 +5,10 @@
 import 'package:logging/logging.dart';
 
 import '../config.dart';
+import 'build.dart';
 import 'linker.dart';
 
-/// A builder to be run inside `hook/build.dart`.
+/// A builder to be run in [build] in `hook/build.dart`.
 ///
 /// [Builder]s should be used to build native code, download assets, and
 /// transform assets. A build hook is only rerun when its declared

pkgs/native_assets_cli/lib/src/api/linker.dart

@@ -6,8 +6,9 @@ import 'package:logging/logging.dart';
 
 import '../config.dart';
 import 'builder.dart';
+import 'link.dart';
 
-/// A builder to be run inside `hook/link.dart`.
+/// A builder to be run in [link] in `hook/link.dart`.
 ///
 /// [Linker]s should be used to shrink or omit assets based on tree-shaking
 /// information. [Linker]s have access to tree-shaking information in some build

pkgs/native_assets_cli/lib/src/code_assets/code_asset.dart

@@ -129,6 +129,7 @@ extension CodeAssetType on CodeAsset {
   static const String type = NativeCodeAssetNewSyntax.typeValue;
 }
 
+/// Methods on [EncodedAsset] for [CodeAsset]s.
 extension EncodedCodeAsset on EncodedAsset {
   bool get isCodeAsset => type == CodeAssetType.type;
   CodeAsset get asCodeAsset => CodeAsset.fromEncoded(this);

pkgs/native_assets_cli/lib/src/code_assets/config.dart

@@ -14,7 +14,7 @@ import 'syntax.g.dart';
 
 /// Extension to the [HookConfig] providing access to configuration specific
 /// to code assets (only available if code assets are supported).
-extension CodeAssetHookConfig on HookConfig {
+extension HookConfigCodeConfig on HookConfig {
   /// Code asset specific configuration.
   CodeConfig get code => CodeConfig._fromJson(json, path);
 
@@ -24,7 +24,7 @@ extension CodeAssetHookConfig on HookConfig {
 /// Extension to the [LinkInput] providing access to configuration specific to
 /// code assets as well as code asset inputs to the linker (only available if
 /// code assets are supported).
-extension CodeAssetLinkInput on LinkInputAssets {
+extension LinkInputCodeAssets on LinkInputAssets {
   // Returns the code assets that were sent to this linker.
   //
   // NOTE: If the linker implementation depends on the contents of the files the
@@ -138,16 +138,17 @@ final class MacOSCodeConfig {
 }
 
 /// Extension on [BuildOutputBuilder] to add [CodeAsset]s.
-extension CodeAssetBuildOutputBuilder on EncodedAssetBuildOutputBuilder {
+extension BuildOutputAssetsBuilderCode on BuildOutputAssetsBuilder {
   /// Provides access to emitting code assets.
-  CodeAssetBuildOutputBuilderAdd get code =>
-      CodeAssetBuildOutputBuilderAdd._(this);
+  BuildOutputCodeAssetBuilder get code => BuildOutputCodeAssetBuilder._(this);
 }
 
 /// Extension on [BuildOutputBuilder] to add [CodeAsset]s.
-extension type CodeAssetBuildOutputBuilderAdd._(
-  EncodedAssetBuildOutputBuilder _output
-) {
+final class BuildOutputCodeAssetBuilder {
+  final BuildOutputAssetsBuilder _output;
+
+  BuildOutputCodeAssetBuilder._(this._output);
+
   /// Adds the given [asset] to the hook output with [routing].
   void add(CodeAsset asset, {AssetRouting routing = const ToAppBundle()}) =>
       _output.addEncodedAsset(asset.encode(), routing: routing);
@@ -164,16 +165,17 @@ extension type CodeAssetBuildOutputBuilderAdd._(
 }
 
 /// Extension on [LinkOutputBuilder] to add [CodeAsset]s.
-extension CodeAssetLinkOutputBuilder on EncodedAssetLinkOutputBuilder {
+extension LinkOutputAssetsBuilderCode on LinkOutputAssetsBuilder {
   /// Provides access to emitting code assets.
-  CodeAssetLinkOutputBuilderAdd get code =>
-      CodeAssetLinkOutputBuilderAdd._(this);
+  LinkOutputCodeAssetBuilder get code => LinkOutputCodeAssetBuilder._(this);
 }
 
 /// Extension on [LinkOutputBuilder] to add [CodeAsset]s.
-extension type CodeAssetLinkOutputBuilderAdd._(
-  EncodedAssetLinkOutputBuilder _output
-) {
+final class LinkOutputCodeAssetBuilder {
+  final LinkOutputAssetsBuilder _output;
+
+  LinkOutputCodeAssetBuilder._(this._output);
+
   /// Adds the given [asset] to the link hook output.
   void add(CodeAsset asset) => _output.addEncodedAsset(asset.encode());
 
@@ -210,18 +212,19 @@ extension CodeAssetBuildInputBuilder on HookConfigBuilder {
   }
 }
 
-/// Provides access to [CodeAsset]s from a build hook output.
-extension CodeAssetBuildOutput on BuildOutputAssets {
-  /// The code assets emitted by the build hook.
+/// The [CodeAsset]s in [BuildOutputAssets.encodedAssets].
+// TODO: Add access to assetsForBuild or assetsForLinking.
+extension BuildOutputCodeAssets on BuildOutputAssets {
+  /// The [CodeAsset]s in this [BuildOutputAssets.encodedAssets].
   List<CodeAsset> get code => encodedAssets
       .where((asset) => asset.isCodeAsset)
       .map(CodeAsset.fromEncoded)
       .toList();
 }
 
-/// Provides access to [CodeAsset]s from a link hook output.
-extension CodeAssetLinkOutput on LinkOutputAssets {
-  /// The code assets emitted by the link hook.
+/// The [CodeAsset]s in [LinkOutputAssets.encodedAssets].
+extension LinkOutputCodeAssets on LinkOutputAssets {
+  /// The [CodeAsset]s in this [LinkOutputAssets.encodedAssets].
   List<CodeAsset> get code => encodedAssets
       .where((asset) => asset.isCodeAsset)
       .map(CodeAsset.fromEncoded)