Small fixes

Author: mosuem

pkgs/code_assets/lib/src/code_assets/validation.dart

@@ -91,7 +91,7 @@ Future<ValidationErrors> validateCodeAssetBuildOutput(
   output.assets.encodedAssets,
   [
     ...output.assets.encodedAssetsForBuild,
-    ...output.assets.encodedAssetsForLinking.values.expand((l) => l),
+    ...output.assets.encodedAssetsForLinking.values.expand((assets) => assets),
   ],
   output,
   true,
@@ -105,7 +105,7 @@ Future<ValidationErrors> validateCodeAssetLinkOutput(
   input,
   input.config.code,
   output.assets.encodedAssets,
-  output.assets.encodedAssetsForLink.values.expand((l) => l),
+  output.assets.encodedAssetsForLink.values.expand((assets) => assets),
   output,
   false,
 );

pkgs/hooks/lib/hooks.dart

@@ -53,6 +53,7 @@ export 'src/config.dart'
         LinkOutputBuilder,
         LinkOutputFailure,
         LinkOutputMaybeFailure,
+        LinkOutputMetadataBuilder,
         PackageMetadata,
         ToAppBundle,
         ToBuildHooks,

pkgs/hooks/lib/src/config.dart

@@ -354,10 +354,12 @@ final class LinkInput extends HookInput {
   LinkInputAssets get assets => LinkInputAssets._(this);
 
   /// The metadata set to this link hook by dependent link hooks.
-  List<MetadataAsset> get metadata => assets.encodedInternalAssets
-      .where((e) => e.isMetadataAsset)
-      .map((e) => e.asMetadataAsset)
-      .toList();
+  Map<String, Object?> get metadata => Map.fromEntries(
+    assets.assetsFromLinking
+        .where((e) => e.isMetadataAsset)
+        .map((e) => e.asMetadataAsset)
+        .map((e) => MapEntry(e.key, e.value)),
+  );
 }
 
 /// The assets in [LinkInput.assets];
@@ -371,7 +373,7 @@ final class LinkInputAssets {
       EncodedAssetSyntax._fromSyntax(_input._syntaxLinkInput.assets);
 
   /// The encoded assets from direct dependencies.
-  List<EncodedAsset> get encodedInternalAssets =>
+  List<EncodedAsset> get assetsFromLinking =>
       EncodedAssetSyntax._fromSyntax(_input._syntaxLinkInput.assetsFromLinking);
 }
 
@@ -626,7 +628,7 @@ final class BuildOutputMetadataBuilder {
   }
 }
 
-/// The builder for [BuildOutputBuilder.metadata].
+/// The builder for [LinkOutputBuilder.metadata].
 final class LinkOutputMetadataBuilder {
   final LinkOutputBuilder _output;
 

pkgs/hooks_runner/lib/src/build_runner/build_runner.dart

@@ -266,7 +266,7 @@ class NativeAssetsBuildRunner {
     }
     var linkResult = hookResultUserDefines.success;
 
-    /// Key is packageName.
+    /// The key is the package name of the destination package.
     final globalAssetsForBuild = <String, Map<String, List<EncodedAsset>>>{};
     for (final package in buildPlan) {
       final dependencies = packageGraph!

pkgs/hooks_runner/test_data/flag_enthusiast_1/README.md

@@ -1,39 +1 @@
-<!-- 
-This README describes the package. If you publish this package to pub.dev,
-this README's contents appear on the landing page for your package.
-
-For information about how to write a good package README, see the guide for
-[writing package pages](https://dart.dev/tools/pub/writing-package-pages). 
-
-For general information about developing packages, see the Dart guide for
-[creating packages](https://dart.dev/guides/libraries/create-packages)
-and the Flutter guide for
-[developing packages and plugins](https://flutter.dev/to/develop-packages). 
--->
-
-TODO: Put a short description of the package here that helps potential users
-know whether this package might be useful for them.
-
-## Features
-
-TODO: List what your package can do. Maybe include images, gifs, or videos.
-
-## Getting started
-
-TODO: List prerequisites and provide or point to information on how to
-start using the package.
-
-## Usage
-
-TODO: Include short and useful examples for package users. Add longer examples
-to `/example` folder. 
-
-```dart
-const like = 'sample';
-```
-
-## Additional information
-
-TODO: Tell users more about the package: where to find more information, how to 
-contribute to the package, how to file issues, what response they can expect 
-from the package authors, and more.
+A package with a high-level API to load a single flag.

pkgs/hooks_runner/test_data/flag_enthusiast_1/pubspec.yaml

@@ -1,6 +1,5 @@
 name: flag_enthusiast_1
-description: Add and retrieve a data asset.
-
+description: A package with a high-level API to load a single flag.
 
 publish_to: none
 

pkgs/hooks_runner/test_data/flag_enthusiast_2/README.md

@@ -1,39 +1 @@
-<!-- 
-This README describes the package. If you publish this package to pub.dev,
-this README's contents appear on the landing page for your package.
-
-For information about how to write a good package README, see the guide for
-[writing package pages](https://dart.dev/tools/pub/writing-package-pages). 
-
-For general information about developing packages, see the Dart guide for
-[creating packages](https://dart.dev/guides/libraries/create-packages)
-and the Flutter guide for
-[developing packages and plugins](https://flutter.dev/to/develop-packages). 
--->
-
-TODO: Put a short description of the package here that helps potential users
-know whether this package might be useful for them.
-
-## Features
-
-TODO: List what your package can do. Maybe include images, gifs, or videos.
-
-## Getting started
-
-TODO: List prerequisites and provide or point to information on how to
-start using the package.
-
-## Usage
-
-TODO: Include short and useful examples for package users. Add longer examples
-to `/example` folder. 
-
-```dart
-const like = 'sample';
-```
-
-## Additional information
-
-TODO: Tell users more about the package: where to find more information, how to 
-contribute to the package, how to file issues, what response they can expect 
-from the package authors, and more.
+A package with a high-level API to load multiple flags.

pkgs/hooks_runner/test_data/flag_enthusiast_2/pubspec.yaml

@@ -1,5 +1,5 @@
 name: flag_enthusiast_2
-description: Add and retrieve a data asset.
+description: A package with a high-level API to load multiple flags.
 
 publish_to: none
 

pkgs/hooks_runner/test_data/fun_with_flags/README.md

@@ -1,39 +1 @@
-<!-- 
-This README describes the package. If you publish this package to pub.dev,
-this README's contents appear on the landing page for your package.
-
-For information about how to write a good package README, see the guide for
-[writing package pages](https://dart.dev/tools/pub/writing-package-pages). 
-
-For general information about developing packages, see the Dart guide for
-[creating packages](https://dart.dev/guides/libraries/create-packages)
-and the Flutter guide for
-[developing packages and plugins](https://flutter.dev/to/develop-packages). 
--->
-
-TODO: Put a short description of the package here that helps potential users
-know whether this package might be useful for them.
-
-## Features
-
-TODO: List what your package can do. Maybe include images, gifs, or videos.
-
-## Getting started
-
-TODO: List prerequisites and provide or point to information on how to
-start using the package.
-
-## Usage
-
-TODO: Include short and useful examples for package users. Add longer examples
-to `/example` folder. 
-
-```dart
-const like = 'sample';
-```
-
-## Additional information
-
-TODO: Tell users more about the package: where to find more information, how to 
-contribute to the package, how to file issues, what response they can expect 
-from the package authors, and more.
+A package bundling flag txt files, with a low-level API to load the flags.

pkgs/hooks_runner/test_data/fun_with_flags/hook/link.dart

@@ -9,8 +9,8 @@ import 'package:hooks/hooks.dart';
 void main(List<String> args) {
   link(args, (input, output) async {
     print('Metadata: ${input.metadata}');
-    final usedFlags = input.metadata
-        .where((asset) => asset.key.startsWith(prefix))
+    final usedFlags = input.metadata.entries
+        .where((entry) => entry.key.startsWith(prefix))
         .expand((e) => e.value as List)
         .map((e) => e as String)
         .map((country) => 'package:fun_with_flags/assets/$country.txt')