add non-standard payment support

Author: andoanwkm

CHANGELOG.md

@@ -25,4 +25,8 @@
 
 ## 1.0.5
 
-- Add ECPair to index
+- Add ECPair to index
+
+## 1.0.6
+
+- Accept non-standard payment

example/bitcoin_flutter_example.dart

@@ -1,6 +1,5 @@
 import 'package:bitcoin_flutter/bitcoin_flutter.dart';
 import 'package:bip39/bip39.dart' as bip39;
-
 main() {
   var seed = bip39.mnemonicToSeed(
       "praise you muffin lion enable neck grocery crumble super myself license ghost");

lib/src/transaction.dart

@@ -303,7 +303,7 @@ class Input {
   }
   factory Input.expandInput(Uint8List scriptSig) {
     if (_isP2PKHInput(scriptSig) == false) {
-      throw ArgumentError("Invalid or non-support script");
+      return new Input(prevOutScript: scriptSig);
     }
     P2PKH p2pkh = new P2PKH(data: new P2PKHData(input: scriptSig));
     return new Input(

lib/src/transaction_builder.dart

@@ -123,8 +123,6 @@ class TransactionBuilder {
       input.pubkeys = [ourPubKey];
       input.signScript = prevOutScript;
     }
-    if (input.prevOutScript != null && !isValidOutput(input.prevOutScript))
-      throw ArgumentError('PrevOutScript invalid');
     var signatureHash =
         this._tx.hashForSignature(vin, input.signScript, hashType);
     // enforce in order signing of public keys

pubspec.yaml

@@ -1,6 +1,6 @@
 name: bitcoin_flutter
 description: A dart Bitcoin library for Flutter. BIP32, BIP39, P2PKH integration.
-version: 1.0.5
+version: 1.0.6
 homepage: https://github.com/anicdh
 author: andoan <[email protected]>
 

test/fixtures/transaction_builder.json

@@ -556,18 +556,6 @@
             "value": 1000
           }
         ]
-      },
-      {
-        "description": "Transaction w/ invalid scripts",
-        "exception": "Invalid or non-support script",
-        "incomplete": true,
-        "txHex": "010000000100000000171a0000e028f2000000000050178500000000000d0000000e000000000000002009f691b2263260e71f363d1db51ff3100d285956a40cc0e4f8c8c2c4a80559b1ffffffff0110270000000000001976a914aa4d7985c57e011a8b3dd8e0e5a73aaef41629c588ac00000000"
-      },
-      {
-        "description": "Complete transaction w/ non-standard inputs",
-        "exception": "Invalid or non-support script",
-        "incomplete": true,
-        "txHex": "010000000100000000171a0000e028f2000000000050178500000000000d0000000e00000000000000201ff691b2263260e71f363d1db51ff3100d285956a40cc0e4f8c8c2c4a80559b1ffffffff0110270000000000001976a914aa4d7985c57e011a8b3dd8e0e5a73aaef41629c588ac00000000"
       }
     ],
     "sign": [
@@ -620,28 +608,6 @@
           }
         ]
       },
-      {
-        "exception": "PrevOutScript invalid",
-        "inputs": [
-          {
-            "txId": "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff",
-            "vout": 0,
-            "prevTxScript": "OP_RETURN 06deadbeef03f895a2ad89fb6d696497af486cb7c644a27aa568c7a18dd06113401115185474",
-            "signs": [
-              {
-                "keyPair": "KzrA86mCVMGWnLGBQu9yzQa32qbxb5dvSK4XhyjjGAWSBKYX4rHx",
-                "throws": true
-              }
-            ]
-          }
-        ],
-        "outputs": [
-          {
-            "script": "OP_DUP OP_HASH160 aa4d7985c57e011a8b3dd8e0e5a73aaef41629c5 OP_EQUALVERIFY OP_CHECKSIG",
-            "value": 1000
-          }
-        ]
-      },
       {
         "description": "Transaction w/ no outputs (but 1 SIGHASH_NONE)",
         "exception": "Transaction needs outputs",