Enable and fix some more lints (#29)

Rename analysis_options

Author: kevmoo

.analysis_options

@@ -0,0 +1,57 @@
+analyzer:
+ strong-mode: true
+ errors:
+   unused_element: error
+   unused_import: error
+   unused_local_variable: error
+   dead_code: error
+linter:
+  rules:
+    #- always_declare_return_types
+    #- always_specify_types
+    #- annotate_overrides
+    #- avoid_as
+    - avoid_empty_else
+    - avoid_init_to_null
+    - avoid_null_checks_in_equality_operators
+    #- avoid_return_types_on_setters
+    - await_only_futures
+    - camel_case_types
+    - cancel_subscriptions
+    #- close_sinks
+    #- comment_references
+    #- constant_identifier_names
+    - control_flow_in_finally
+    - directives_ordering
+    - empty_catches
+    - empty_constructor_bodies
+    - empty_statements
+    - hash_and_equals
+    - implementation_imports
+    - iterable_contains_unrelated_type
+    - library_names
+    - library_prefixes
+    - list_remove_unrelated_type
+    #- non_constant_identifier_names
+    #- one_member_abstracts
+    #- only_throw_errors
+    - overridden_fields
+    - package_api_docs
+    - package_names
+    - package_prefixed_library_names
+    - prefer_final_fields
+    - prefer_is_not_empty
+    #- public_member_api_docs
+    - slash_for_doc_comments
+    #- sort_constructors_first
+    #- sort_unnamed_constructors_first
+    - super_goes_last
+    - test_types_in_equals
+    - throw_in_finally
+    #- type_annotate_public_apis
+    - type_init_formals
+    #- unawaited_futures
+    - unnecessary_brace_in_string_interps
+    #- unnecessary_getters_setters
+    - unrelated_type_equality_checks
+    - valid_regexps

analysis_options.yaml

@@ -13,11 +13,11 @@ import 'package:angular_components/angular_components.dart';
     MaterialButtonComponent,
     MaterialPopupComponent,
     PopupSourceDirective,
-    defaultPopupSizeProvider,
+    DefaultPopupSizeProvider,
   ],
   providers: const [
     popupBindings,
-    defaultPopupSizeProvider,
+    DefaultPopupSizeProvider,
   ],
 )
 class MaterialPopupDemoComponent {
@@ -39,4 +39,4 @@ PopupSizeProvider createPopupSizeProvider() {
 @Directive(selector: '[defaultPopupSizeProvider]', providers: const [
   const Provider(PopupSizeProvider, useFactory: createPopupSizeProvider)
 ])
-class defaultPopupSizeProvider {}
+class DefaultPopupSizeProvider {}

lib/src/material_popup_demo/material_popup_demo.dart

@@ -70,7 +70,8 @@ class MaterialSelectDemoComponent {
     const Language('de', 'German')
   ];
 
-  static List<OptionGroup<Language>> _languagesGroups = <OptionGroup<Language>>[
+  static final List<OptionGroup<Language>> _languagesGroups =
+      <OptionGroup<Language>>[
     new OptionGroup<Language>.withLabel(const <Language>[
       const Language('en-US', 'US English'),
       const Language('fr-CA', 'Canadian English'),
@@ -89,21 +90,21 @@ class MaterialSelectDemoComponent {
     new OptionGroup<Language>.withLabel(const <Language>[], 'Pangaea')
   ];
 
-  static List<RelativePosition> _popupPositionsAboveInput = const [
+  static final List<RelativePosition> _popupPositionsAboveInput = const [
     RelativePosition.AdjacentTopLeft,
     RelativePosition.AdjacentTopRight
   ];
-  static List<RelativePosition> _popupPositionsBelowInput = const [
+  static final List<RelativePosition> _popupPositionsBelowInput = const [
     RelativePosition.AdjacentBottomLeft,
     RelativePosition.AdjacentBottomRight
   ];
 
-  static ItemRenderer<Language> _displayNameRenderer =
+  static final ItemRenderer<Language> _displayNameRenderer =
       (HasUIDisplayName item) => item.uiDisplayName;
 
 // Specifying an itemRenderer avoids the selected item from knowing how to
 // display itself.
-  static ItemRenderer<Language> _itemRenderer =
+  static final ItemRenderer<Language> _itemRenderer =
       new CachingItemRenderer<Language>(
           (language) => "${language.label} (${language.code})");
 

lib/src/material_select_demo/material_select_demo.dart

@@ -118,10 +118,8 @@ Future testButton(Future<Null> ensureBodyContains(String text),
 Future testMaxCharInput(WebDriver driver) async {
   print("Testing input.");
 
-  Stream<WebElement> inputs =
-      await driver.findElements(const By.tagName("input"));
   WebElement maxCharInput;
-  await for (var input in inputs) {
+  await for (var input in driver.findElements(const By.tagName("input"))) {
     if (await input.attributes["aria-label"] == "Max 5 chars") {
       maxCharInput = input;
       break;
@@ -174,18 +172,20 @@ Future testDialog(
 
   var dialogText = "Lorem ipsum dolor sit amet";
 
-  var buttons = await driver.findElements(const By.tagName("material-button"));
+  var buttons =
+      await driver.findElements(const By.tagName("material-button")).toList();
 
   await ensureBodyDoesNotContain(dialogText);
-  for (var button in await buttons.toList()) {
+  for (var button in buttons) {
     if ((await button.text) == "OPEN BASIC") {
       await button.click();
       break;
     }
   }
   await ensureBodyContains(dialogText);
-  buttons = await driver.findElements(const By.tagName("material-button"));
-  for (var button in await buttons.toList()) {
+  buttons =
+      await driver.findElements(const By.tagName("material-button")).toList();
+  for (var button in buttons) {
     if ((await button.text) == "CLOSE") {
       await button.click();
       break;
@@ -202,10 +202,11 @@ Future testPopup(
 
   var popupText = "Hello, I am a pop up!";
 
-  var buttons = await driver.findElements(const By.tagName("material-button"));
+  var buttons =
+      await driver.findElements(const By.tagName("material-button")).toList();
 
   await ensureBodyDoesNotContain(popupText);
-  for (var button in await buttons.toList()) {
+  for (var button in buttons) {
     if ((await button.text) == "OPEN POPUP") {
       await button.click();
       break;
@@ -235,10 +236,11 @@ Future testTooltip(
 
   var tooltipText = "Saves the document";
 
-  var buttons = await driver.findElements(const By.tagName("material-button"));
+  var buttons =
+      await driver.findElements(const By.tagName("material-button")).toList();
 
   await ensureBodyDoesNotContain(tooltipText);
-  for (var button in await buttons.toList()) {
+  for (var button in buttons) {
     if ((await button.text) == "SAVE") {
       await driver.mouse.moveTo(element: button);
       break;
@@ -272,9 +274,10 @@ Future testList(
       await driver.findElements(const By.className("colorchanger")).first;
   await ensureElementColor(colorText, colorInitial);
 
-  var listItems =
-      await driver.findElements(const By.tagName("material-list-item"));
-  for (var listItem in await listItems.toList()) {
+  var listItems = await driver
+      .findElements(const By.tagName("material-list-item"))
+      .toList();
+  for (var listItem in listItems) {
     if ((await listItem.text).contains("Green")) {
       await listItem.click();
       break;
@@ -292,14 +295,18 @@ Future testSelect(
   var expectedSelection = "Selected Protocol: HTTPS";
   await ensureBodyDoesNotContain(expectedSelection);
 
-  var selectOptions =
-      await driver.findElements(const By.tagName("material-select-item"));
-  for (var selectOption in await selectOptions.toList()) {
+  var selectOptions = await driver
+      .findElements(const By.tagName("material-select-item"))
+      .toList();
+  for (var selectOption in selectOptions) {
     if ((await selectOption.text).contains("HTTPS")) {
       await selectOption.click();
       break;
     }
   }
+
+  await new Future.delayed(const Duration(milliseconds: 500));
+
   await ensureBodyContains(expectedSelection);
 }
 
@@ -312,18 +319,20 @@ Future testTree(
   var expectedSelection = "Selected Value: Lady and the Tramp";
   await ensureBodyDoesNotContain(expectedSelection);
 
-  var treeItems =
-      await driver.findElements(const By.className("material-tree-item"));
-  for (var treeItem in await treeItems.toList()) {
+  var treeItems = await driver
+      .findElements(const By.className("material-tree-item"))
+      .toList();
+  for (var treeItem in treeItems) {
     if ((await treeItem.text).contains("Animated Feature Films")) {
       await treeItem.click();
       break;
     }
   }
 
-  treeItems =
-      await driver.findElements(const By.className("material-tree-item"));
-  for (var treeItem in await treeItems.toList()) {
+  treeItems = await driver
+      .findElements(const By.className("material-tree-item"))
+      .toList();
+  for (var treeItem in treeItems) {
     if ((await treeItem.text).contains("Lady and the Tramp")) {
       await treeItem.click();
       break;