Improvements

- make last_name field required when creating user and update its tests
- added backend authentication event hooks (backend.auth.success and
backend.auth.logout )

Author: darryldecode

src/Darryldecode/Backend/Components/Auth/Controllers/AuthController.php

@@ -51,7 +51,7 @@ public function postLogin(Request $request, Throttle $throttle, User $user, Disp
         // if authentication is good
         if( $result->isSuccessful() )
         {
-            $dispatcher->fire('auth.loginSuccess', array($result->getData()));
+            $dispatcher->fire('backend.auth.success', array($result->getData()));
 
             if( $request->get('ru') != '' )
             {
@@ -76,7 +76,7 @@ public function getLogout(Dispatcher $dispatcher)
     {
         Auth::logout();
 
-        $dispatcher->fire('auth.logout');
+        $dispatcher->fire('backend.auth.logout');
 
         return redirect(Helpers::getLoginRoute());
     }

src/Darryldecode/Backend/Components/User/Commands/CreateUserCommand.php

@@ -86,6 +86,7 @@ public function handle(User $user, Factory $validator, Dispatcher $dispatcher, G
         // validate data
         $validationResult = $validator->make(array(
             'first_name' => $this->firstName,
+            'last_name' => $this->lastName,
             'email' => $this->email,
             'password' => $this->password,
         ), $this->user->getValidationRules());

src/Darryldecode/Backend/Components/User/Models/User.php

@@ -50,6 +50,7 @@ class User extends Model implements AuthenticatableContract, CanResetPasswordCon
 	 */
 	public static $rules = array(
 		'first_name' => 'required',
+		'last_name' => 'required',
 		'email' => 'required|email|unique:users',
 		'password' => 'required|min:8',
 	);

tests/User/functional/commands/CreateUserCommandTest.php

@@ -72,19 +72,9 @@ public function testShouldDenyIfUserHasNoPermission()
         $this->assertEquals('Not enough permission.', $result->getMessage());
     }
 
-    public function testRequiredFieldsPermissions()
+    public function testShouldRequireFirstNameField()
     {
-        // create user and logged in
-        $user = User::create(array(
-            'first_name' => 'darryl',
-            'email' => '[email protected]',
-            'password' => 'pass$darryl',
-            'permissions' => array(
-                'superuser' => 1
-            )
-        ));
-
-        $this->application['auth']->loginUsingId($user->id);
+        $this->createUserAndLoggedIn(array('superuser' => 1));
 
         // dummy request, required first name
         $request = Request::create('','GET',array(
@@ -105,6 +95,11 @@ public function testRequiredFieldsPermissions()
         $this->assertFalse($result->isSuccessful(), 'Transaction should not be successful.');
         $this->assertEquals(400, $result->getStatusCode(), 'Status code should be 400');
         $this->assertEquals('The first name field is required.', $result->getMessage());
+    }
+
+    public function testShouldRequireLastName()
+    {
+        $this->createUserAndLoggedIn(array('superuser' => 1));
 
         // dummy request, required email
         $request = Request::create('','GET',array(
@@ -124,13 +119,18 @@ public function testRequiredFieldsPermissions()
 
         $this->assertFalse($result->isSuccessful(), 'Transaction should not be successful.');
         $this->assertEquals(400, $result->getStatusCode(), 'Status code should be 400');
-        $this->assertEquals('The email field is required.', $result->getMessage());
+        $this->assertEquals('The last name field is required.', $result->getMessage());
+    }
+
+    public function testShouldRequireEmail()
+    {
+        $this->createUserAndLoggedIn(array('superuser' => 1));
 
-        // dummy request, required valid email
+        // dummy request, required email
         $request = Request::create('','GET',array(
             'firstName' => 'John',
-            'lastName' => '',
-            'email' => 'some invalid email',
+            'lastName' => 'Doe',
+            'email' => '',
             'password' => '',
             'permissions' => '',
             'groups' => array(),
@@ -144,13 +144,18 @@ public function testRequiredFieldsPermissions()
 
         $this->assertFalse($result->isSuccessful(), 'Transaction should not be successful.');
         $this->assertEquals(400, $result->getStatusCode(), 'Status code should be 400');
-        $this->assertEquals('The email must be a valid email address.', $result->getMessage());
+        $this->assertEquals('The email field is required.', $result->getMessage());
+    }
+
+    public function testShouldRequireEmailToBeUnique()
+    {
+        $this->createUserAndLoggedIn(array('superuser' => 1));
 
-        // dummy request, required unique email
+        // dummy request, required email
         $request = Request::create('','GET',array(
             'firstName' => 'John',
-            'lastName' => '',
-            'email' => '[email protected]', // this email is already used aboved
+            'lastName' => 'Doe',
+            'email' => '[email protected]', // existing email
             'password' => '',
             'permissions' => '',
             'groups' => array(),
@@ -280,4 +285,17 @@ public function testShouldAssociateTheUserToTheGroupIfThereIsAnyProvided()
         $this->assertTrue($createdUser->inGroup($artist), 'User should be in artist group');
         $this->assertFalse($createdUser->inGroup($moderator), 'User should not be in moderator group');
     }
+
+    protected function createUserAndLoggedIn($permissions)
+    {
+        // create user and logged in
+        $user = User::create(array(
+            'first_name' => 'darryl',
+            'email' => '[email protected]',
+            'password' => 'pass$darryl',
+            'permissions' => $permissions
+        ));
+
+        $this->application['auth']->loginUsingId($user->id);
+    }
 }