Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniswap V3 sync on swap events #221

Closed
merolish opened this issue Oct 15, 2024 · 1 comment
Closed

Uniswap V3 sync on swap events #221

merolish opened this issue Oct 15, 2024 · 1 comment

Comments

@merolish
Copy link

In UniswapV3Pool I see that sync_on_event_signatures and sync_from_log include swap events, but populate_tick_data as well as UniswapV3Factory::get_all_pools_from_logs do not. Is there a particular reason for this? I'd think they'd be necessary to maintain consistent state.
@0xKitsune
Copy link
Collaborator

Closing as this is no longer an issue in the upcoming 0.7.0 release.

#235 for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@merolish @0xKitsune