Skip to content

Commit e7e9a5a

Browse files
committed
review comments
1 parent a28131e commit e7e9a5a

File tree

1 file changed

+22
-28
lines changed

1 file changed

+22
-28
lines changed

community-membership.md

Lines changed: 22 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,10 @@ The following apply to the subproject for which one would be an owner:
137137

138138
New Core-maintainers can be added to the project by a super-majority (two-thirds / 66.66%) vote. Only the Core-maintainers of the repository in which the nomination is applied to have a binding vote, while Core-maintainers from other repositories are on an informed basis via a separate email thread. A potential Core-maintainer may be nominated by an existing Core-maintainer from the repository in which the nomination is applied to. A vote is conducted in private between the current Core-maintainers over the course of a one week voting period. At the end of the week, votes are counted and a pull request is made on the repo adding the new core-maintainer to the CODEOWNERS file.
139139

140-
Core-maintainers for new repositories can be nominated by any member of the steering committee and voted on in a steering committee meeting.
141-
Single Core-maintainers of a repository can nominate a new Core-maintainer and *MUST* inform the steering committee of their intention. The Core-maintainer can be approved if no objections have been raised in a period of one week.
140+
Core-Maintainers for new repositories can be nominated by any member of the steering committee and voted on in a steering committee meeting.
141+
Single Core-Maintainers of a repository can nominate a new Core-Maintainer and *MUST* inform the steering committee of their intention. The Core-Maintainer can be approved if no objections have been raised in a period of one week.
142142

143-
A Core-maintainer may step down by submitting an issue stating their intent.
143+
A Core-Maintainer may step down by submitting an issue stating their intent.
144144

145145
### Responsibilities and privileges
146146

@@ -169,10 +169,10 @@ files.
169169

170170
### Requirements
171171

172-
The following apply to the sub area(ex: building block API/ Control plane service/ Component provider) for which one would be a Feature-maintainer:
172+
The following apply to the area(ex: building block API/ Control plane service/ Component provider) for which one would be a Feature-maintainer:
173173

174-
- Deep understanding of the technical goals and direction of the sub area.
175-
- Deep understanding of the technical domain (specifically the language) of the sub area
174+
- Deep understanding of the technical goals and direction of the area.
175+
- Deep understanding of the technical domain (specifically the language) of the area
176176
- Sustained contributions to design and direction by doing all of:
177177
- Authoring and reviewing proposals
178178
- Initiating, contributing and resolving discussions For example Discord discussions, GitHub issues, meetings)
@@ -184,43 +184,37 @@ The following apply to the sub area(ex: building block API/ Control plane servic
184184

185185
### Acceptance
186186

187-
New Feature-Maintainers can be added to the project by a super-majority (two-thirds / 66.66%) vote. Only the maintainers of the repository in which the nomination is applied have a binding vote, while maintainers from other repositories are on an informed basis via a separate email thread.
187+
New Feature-Maintainers can be added to the project by a super-majority (two-thirds / 66.66%) vote. Only the Core-maintainers of the repository in which the nomination is applied have a binding vote, while maintainers from other repositories are on an informed basis via a separate email thread.
188188

189-
A potential feature-maintainer may be nominated by an existing maintainer from the repository in which the nomination is applied to. A vote is conducted in private between the current maintainers over the course of a one week voting period. At the end of the week, votes are counted, and a pull request is made on the repo adding the new feature-maintainer to the feature-maintainers.md file.
189+
A potential feature-maintainer may be nominated by an existing Core-Maintainer from the repository in which the nomination is applied to. A vote is conducted in private between the current maintainers over the course of a one week voting period. At the end of the week, votes are counted, and a pull request is made on the repo adding the new feature-maintainer to the feature-maintainers.md file.
190190

191-
Feature-maintainers MUST remain active. If they are unresponsive for >3 months, they will be automatically removed unless a super-majority of the other repository maintainers agrees to extend the period to be greater than 3 months.
191+
Feature-Maintainers MUST remain active. If they are unresponsive for >3 months, they will be automatically removed unless a super-majority of the other repository maintainers agrees to extend the period to be greater than 3 months.
192192

193193
A feature-maintainer may step down by submitting an issue stating their intent.
194194

195195
### Example of Feature Maintainers in DAPR Runtime repo:
196-
Sub Area
197-
Person Name
198-
Workflow
199-
Chris Gillum
200-
Control Plane Service(mTLS)
201-
Josh V
202-
203-
| **Subarea** | **Name** |
204-
| ---------- | ---------------------------------------------|
205-
| Workflow | Chris Gilum |
206-
| Control Plane Service(mTLS)| Josh V |
196+
197+
| **Subarea** | **Name** |**GH Handle**|
198+
| ---------- | ---------------------------------------------|-------------|
199+
| Workflow | Chris Gilum |cgillum |
200+
| Control Plane Service(mTLS)| Josh V |JoshVanL |
207201

208202
### Responsibilities and privileges
209203

210-
The following applies to the sub area(ex: building block API/ Control plane service/ Component provider) for which the feature-maintainer would be an owner:
204+
The following applies to the area(ex: building block API/ Control plane service/ Component provider) for which the feature-maintainer would be an owner:
211205

212-
- Make and approve technical design decisions for the sub area
213-
- Set technical direction and priorities for the sub area.
206+
- Make and approve technical design decisions for the area
207+
- Set technical direction and priorities for the area.
214208
- Define milestones and releases working along with the maintainers
215209
- Decides on when PRs are merged to control the release scope
216-
- Mentor and guide approvers and contributors of the sub area
210+
- Mentor and guide approvers and contributors of the area
217211
- Escalate approver and maintainer workflow concerns. (For example responsiveness, availability, and general contributor community health) to the STC
218-
- Ensure continued health of sub area:
212+
- Ensure continued health of area:
219213
- Adequate test coverage to confidently release
220214
- Tests are passing reliably (not flaky) and are fixed when they fail.
221215
- Work with other feature-maintainers & Core-maintainers to maintain the project's overall health and success holistically.
222-
- Membership tracked in feature-maintainer.md entry and scoped to a sub area.
223-
- MUST maintain components, review, and approve proposals for enhancing areas falling under the user sub area.
216+
- Membership tracked in feature-maintainer.md entry and scoped to a area.
217+
- Must maintain components, review, and approve proposals for enhancing areas falling under the user area.
224218
- Actively participate in issue triages and PR reviews
225-
- Set milestone priorities for the sub areas or delegate the responsibility to repo maintainers.
219+
- Set milestone priorities for the areas working with the repo maintainers.
226220
- Ensure a healthy process for discussion and decision making is in place

0 commit comments

Comments
 (0)