You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
| Contributor | Contribute source code, documentation or blog posts | At least one merged PR in one of the Dapr repositories. | GtiHub contributors listed per repository
11
11
| Member | Active contributor in the community. Reviewer of PRs | Sponsored by two approvers or maintainers. Multiple contributions to the project. | Dapr GitHub org member |
12
-
| Approver | Approve accepting contributions | Highly experienced and active reviewer and contributor to a subproject. |[CODEOWNERS](https://help.github.com/en/articles/about-code-owners) in GitHub |
13
-
| Maintainer | Set direction and priorities for a subproject | Demonstrated responsibility and excellent technical judgement for the subproject. |[CODEOWNERS](https://help.github.com/en/articles/about-code-owners), GitHub Team and repo ownership in GitHub |
12
+
| Approver | Approve accepting contributions | Highly experienced and active reviewer and contributor to a subproject. |[CODEOWNERS](https://help.github.com/en/articles/about-code-owners), GitHub Team and repository write access in GitHub |
13
+
| Feature Maintainer | Set direction and priorities for a feature or a specialized area of project/repo | Demonstrated responsibility and excellent technical judgement in the area. |[CODEOWNERS](https://help.github.com/en/articles/about-code-owners), GitHub Team and repository write access in GitHub |
14
+
| Maintainer | Set direction and priorities for a repository | Demonstrated responsibility and excellent technical judgement for the repository's code base. |[CODEOWNERS](https://help.github.com/en/articles/about-code-owners), GitHub Team and repository ownership in GitHub |
14
15
| Administrator | Administers the GitHub Dapr org, credentials, and related infrastructure | Highly experienced Dapr maintainer |[CODEOWNERS](https://help.github.com/en/articles/about-code-owners), GitHub Team and repo ownership in GitHub |
15
16
16
17
> Note: The Steering & Technical Committee (STC) referred to in this document is described [here](./steering-and-technical-committee-charter.md)
@@ -64,8 +65,7 @@ Defined by: Member of the Dapr GitHub organization
64
65
### Responsibilities and privileges
65
66
66
67
- Responsive to issues and PRs assigned to them
67
-
- Active owner of code contributed by them (unless ownership is explicitly
68
-
transferred)
68
+
- Active owner of code contributed by them (unless ownership is explicitly transferred)
69
69
- Code is well tested
70
70
- Tests consistently pass
71
71
- Addresses bugs or issues discovered after code is accepted
@@ -76,7 +76,7 @@ Defined by: Member of the Dapr GitHub organization
76
76
77
77
## Approver
78
78
79
-
Code approvers are able to both review and approve code contributions, as well as help maintainers triage issues and do project management.
79
+
Code approvers should review and approve code contributions, as well as help maintainers triage issues and do project management.
80
80
81
81
While code review is focused on code quality and correctness, approval is
82
82
focused on holistic acceptance of a contribution including: backwards/forwards
@@ -112,18 +112,80 @@ The following apply to the part of the codebase for which one would be an approv
112
112
- Expected to be responsive to review requests (inactivity for more than 1 month may result in suspension until active again)
113
113
- Mentor contributors and reviewers
114
114
- May approve code contributions for acceptance
115
-
- Inactivity for more than 3 months leads to a removal vote by other maintainers/approvers and not an automatic removal
115
+
- Inactivity for more than 3 months leads to a removal vote by maintainers and not an automatic removal
116
+
117
+
## Feature-maintainer
118
+
119
+
Feature-maintainers are the technical authority for a feature or specialized area of the project/repository in the Dapr org. They *MUST* have demonstrated both good judgement and responsibility towards the health of that space. Feature Maintainers can set technical direction and make or approve design decisions for their designated space.
120
+
121
+
Defined by: GitHub write permission in repository and entry in `CODEOWNERS` files.
122
+
123
+
### Requirements
124
+
125
+
The following apply to the area (ex: building block API/ Control plane service/ Component provider) for which one would be a feature-maintainer:
126
+
127
+
- Deep understanding of the technical goals and direction of the area.
128
+
- Deep understanding of the technical domain (specifically the language) of the area
129
+
- Sustained contributions to design and direction by doing all of:
- Identifying subtle or complex issues in designs and implementation PRs
133
+
- Directly contributed to the space through implementation and/or review
134
+
- Must have been active for 3 months or more for the given space
135
+
- Inactivity for more than 3 months leads to a removal vote by the repository maintainers and not an automatic removal.
136
+
137
+
138
+
### Acceptance
139
+
140
+
New feature-maintainers can be added to the project by a super-majority (two-thirds / 66.66%) vote. Only the maintainers (not feature-maintainers) of the repository in which the nomination is applied have a binding vote, while maintainers from other repositories are on an informed basis via a separate email thread.
141
+
142
+
A potential feature-maintainer may be nominated by an existing maintainer (not feature-maintainers) from the repository in which the nomination is applied to. A vote is conducted in private between the current maintainers over the course of a one week voting period. At the end of the week, votes are counted, and a pull request is made on the repo adding the new feature-maintainer to the feature-maintainers.md file.
143
+
144
+
Feature-maintainers MUST remain active. Inactivity for more than 3 months leads to a removal vote by maintainers and not an automatic removal
145
+
146
+
A feature-maintainer may step down by submitting an issue stating their intent.
147
+
148
+
Former feature-maintainers of a repository must be mentioned in the repository's README.md file, containing their name and GitHub handle under a section called "Emeritus feature-maintainers".
149
+
150
+
### Example of feature areas in DAPR Runtime repo:
151
+
152
+
- Workflow
153
+
- Distributed Scheduler
154
+
- Placement
155
+
- Actors
156
+
- PubSub
157
+
- Tracing
158
+
159
+
### Responsibilities and privileges
160
+
161
+
The following applies to the area(ex: building block API/ Control plane service/ Component provider) for which the feature-maintainer would be an owner:
162
+
163
+
- Make and approve technical design decisions for the area
164
+
- Set technical direction and priorities for the area.
165
+
- Define milestones and releases working along with the maintainers
166
+
- Decides on when PRs are merged to control the release scope
167
+
- Mentor and guide approvers and contributors of the area
168
+
- Escalate approver and maintainer workflow concerns. (For example responsiveness, availability, and general contributor community health) to the STC
169
+
- Ensure continued health of area:
170
+
- Adequate test coverage to confidently release
171
+
- Tests are passing reliably (not flaky) and are fixed when they fail.
172
+
- Work with other feature-maintainers & maintainers to maintain the project's overall health and success holistically.
173
+
- Membership tracked in feature-maintainer.md entry and scoped to a area.
174
+
- Must maintain components, review, and approve proposals for enhancing areas falling under the user area.
175
+
- Actively participate in issue triages and PR reviews
176
+
- Set milestone priorities for the areas working with the repo maintainers.
177
+
- Ensure a healthy process for discussion and decision making is in place
116
178
117
179
## Maintainer
118
180
119
-
Maintainers are the technical authority for a subproject in the Dapr org. They *MUST* have demonstrated both good judgement and responsibility towards the health of that subproject. Maintainers *MUST* set technical direction and make or approve design decisions for their subproject - either directly or through delegation of these responsibilities.
181
+
Maintainers are the technical authority for a repository in the Dapr org. They *MUST* have demonstrated both good judgement and responsibility towards the health of that repository. Maintainers *MUST* set technical direction and make or approve design decisions for their repository - either directly or through delegation of these responsibilities to approvers or feature maintainers.
120
182
121
183
Defined by: GitHub organization ownership, permissions and entry in `CODEOWNERS`
122
184
files.
123
185
124
186
### Requirements
125
187
126
-
The following apply to the subproject for which one would be an owner:
188
+
The following apply to the repository for which one would be an owner:
127
189
128
190
- Deep understanding of the technical goals and direction of the subproject
129
191
- Deep understanding of the technical domain (specifically the language) of the
@@ -142,10 +204,12 @@ The following apply to the subproject for which one would be an owner:
142
204
New maintainers can be added to the project by a super-majority (two-thirds / 66.66%) vote. Only the maintainers of the repository in which the nomination is applied to have a binding vote, while maintainers from other repositories are on an informed basis via a separate email thread. A potential maintainer may be nominated by an existing maintainer from the repository in which the nomination is applied to. A vote is conducted in private between the current maintainers over the course of a one week voting period. At the end of the week, votes are counted and a pull request is made on the repo adding the new maintainer to the CODEOWNERS file.
143
205
144
206
Maintainers for new repositories can be nominated by any member of the steering committee and voted on in a steering committee meeting.
145
-
Single maintainers of a repository can nominate a new maintainer and *MUST* inform the steering committee of their intention. The maintainer can be approved if no objections have been raised in a period of one week.
207
+
Single maintainers of a repository can nominate a new maintainer and *MUST* inform the steering committee of their intention. A new maintainer can be approved if no objections have been raised in a period of one week.
146
208
147
209
A maintainer may step down by submitting an issue to the stating their intent.
148
210
211
+
Former maintainers of a repository must be mentioned in the repository's README.md file, containing their name and GitHub handle under a section called "Emeritus maintainers".
212
+
149
213
### Responsibilities and privileges
150
214
151
215
The following apply to the subproject(repos) for which one would be an owner:
@@ -162,7 +226,7 @@ The following apply to the subproject(repos) for which one would be an owner:
162
226
- Ensure a healthy process for discussion and decision making is in place
163
227
- Work with other maintainers to maintain the project's overall health and success holistically
164
228
165
-
Maintainers *MUST* remain active. If they are unresponsive for >3 months, they will be automatically removed unless a super-majority of the other repository maintainers agrees to extend the period to be greater than 3 months.
229
+
Maintainers *MUST* remain active. If they are unresponsive for >3 months, a maintainer might start a removal voting process, requiring a super-majority of the other maintainers of the given repository or STC to approve removal.
166
230
167
231
## Administrator
168
232
@@ -177,4 +241,4 @@ An administrator must be an active Dapr maintainer for a longer time and has dee
177
241
### Responsibilities and privileges
178
242
179
243
- Administer the GitHub Dapr org and related CI/CD infrastructure.
180
-
- Perform pre-approved routine maintenance duties and ad-hoc tasks delegated by the STC without making isolated decisions.
244
+
- Perform pre-approved routine maintenance duties and ad-hoc tasks delegated by the STC without making isolated decisions.
0 commit comments