an error message when try to edit a space

[NoamQA]

1.open a space you created in DEV or web stage ENV.
2.click the "edit" button
3.change one of the fields
4.click on "save changes" button

there is a message : "Something went wrong..."

https://web-dev.common.io/commons/7a7462c7-0e56-4a16-b644-0320c477cc09/edit

(notion ticket here and here)

[andreymikhadyuk]

@ariel-dao @danielr18 I tried it and got following error:
status code: 500
endpoint: POST /commons/update
payload:

{
  "commonId": "38b9c682-b3e1-4784-a0f6-68bf0d786cd6",
  "changes": {
    "name": "Test space 1",
    "image": "https://firebasestorage.googleapis.com/v0/b/common-dev-dea4e.appspot.com/o/public_img%2Ffile_983c0f10ee7c448b9d33075bb408b8c3.png?alt=media&token=b1e726fa-86ce-4827-9775-46505ea7c94e",
    "byline": "",
    "description": "[{\"type\":\"paragraph\",\"children\":[{\"text\":\"a\"}]}]",
    "gallery": [],
    "links": []
  }
}

response:

{
  "error": "9 FAILED_PRECONDITION: The query requires an index. You can create it here: https://console.firebase.google.com/v1/r/project/common-dev-dea4e/firestore/indexes?create_composite=Ck1wcm9qZWN0cy9jb21tb24tZGV2LWRlYTRlL2RhdGFiYXNlcy8oZGVmYXVsdCkvY29sbGVjdGlvbkdyb3Vwcy9kYW9zL2luZGV4ZXMvXxABGhkKFWRpcmVjdFBhcmVudC5jb21tb25JZBABGggKBG5hbWUQARoMCghfX25hbWVfXxAB (6b9bed9d-117b-4988-ab45-047fd78b9412)",
  "errorName": "Common Error",
  "errorId": "6b9bed9d-117b-4988-ab45-047fd78b9412",
  "errorCode": "GenericError",
  "errorMessage": "Something bad happened.",
  "request": {
    "id": "6eb959ae-7daf-482d-b255-c53ee8b7cd6e",
    "body": {
      "commonId": "38b9c682-b3e1-4784-a0f6-68bf0d786cd6",
      "changes": {
        "name": "Test space 1",
        "image": "https://firebasestorage.googleapis.com/v0/b/common-dev-dea4e.appspot.com/o/public_img%2Ffile_983c0f10ee7c448b9d33075bb408b8c3.png?alt=media&token=b1e726fa-86ce-4827-9775-46505ea7c94e",
        "byline": "",
        "description": "[{\"type\":\"paragraph\",\"children\":[{\"text\":\"a\"}]}]",
        "gallery": [],
        "links": []
      }
    },
    "query": {},
    "headers": {
      "host": "us-central1-common-dev-dea4e.cloudfunctions.net",
      "sec-ch-ua": "\"Google Chrome\";v=\"111\", \"Not(A:Brand\";v=\"8\", \"Chromium\";v=\"111\"",
      "accept": "application/json, text/plain, */*",
      "content-type": "application/json",
      "sec-ch-ua-mobile": "?0",
      "authorization": "eyJhbGciOiJSUzI1NiIsImtpZCI6Ijk3OWVkMTU1OTdhYjM1Zjc4MjljZTc0NDMwN2I3OTNiN2ViZWIyZjAiLCJ0eXAiOiJKV1QifQ.eyJuYW1lIjoiQW5kcmV5IE1pa2hhZHl1ayIsInBpY3R1cmUiOiIiLCJpc3MiOiJodHRwczovL3NlY3VyZXRva2VuLmdvb2dsZS5jb20vY29tbW9uLWRldi1kZWE0ZSIsImF1ZCI6ImNvbW1vbi1kZXYtZGVhNGUiLCJhdXRoX3RpbWUiOjE2Nzg3NzI1MTcsInVzZXJfaWQiOiJqVHZDcUtGamxWYU5mQU5VUEpxNHY4ZDViSTQzIiwic3ViIjoialR2Q3FLRmpsVmFOZkFOVVBKcTR2OGQ1Ykk0MyIsImlhdCI6MTY4MDI1Mzk2NiwiZXhwIjoxNjgwMjU3NTY2LCJlbWFpbCI6ImFuZHJleUBkYW9zdGFjay5pbyIsImVtYWlsX3ZlcmlmaWVkIjp0cnVlLCJmaXJlYmFzZSI6eyJpZGVudGl0aWVzIjp7Imdvb2dsZS5jb20iOlsiMTE4MzA2MjYwMTcwMzc1MjcyNDUwIl0sImVtYWlsIjpbImFuZHJleUBkYW9zdGFjay5pbyJdfSwic2lnbl9pbl9wcm92aWRlciI6Imdvb2dsZS5jb20ifX0.UNW5o8WPM81Cunp99BM71dDunufUeFqg8GNQvOMkyN70LMsy-agwWf8mTXE50J0RDQXZuYQXqTTekuOGhU9U4oBMMu9FQvUJ0pbAmRFhB59q5A-aqjkLLGLT17gUmptBO0so1WQr6KfAUQxsEqqL647brtkP2XQsgIFrP_lw0oiw5h6_1u7omQPTF-DYiXPLuNOAZknK1pQgAIXyqvHQ5k7r6tFY2lMCAPi7FkWrANCTvc60fQbPr49hPwWcCFbaQpbYdx5E3PB0uRtReGVpe99OFeya9K3Hi_DdY75dV1SyZObVLqssEvMrigD-3lPMqBYdWCPLS1H6i-XMqxrp6A",
      "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36",
      "sec-ch-ua-platform": "\"macOS\"",
      "origin": "https://web-dev.common.io",
      "sec-fetch-site": "cross-site",
      "sec-fetch-mode": "cors",
      "sec-fetch-dest": "empty",
      "referer": "https://web-dev.common.io/",
      "accept-language": "ru-RU,ru;q=0.9,en-US;q=0.8,en;q=0.7",
      "x-cloud-trace-context": "53b7af5a6c19503e7d140691a674e8f3/1208355679478299373",
      "x-appengine-city": "kuta selatan",
      "x-appengine-region": "ba",
      "x-appengine-country": "ID",
      "x-appengine-citylatlong": "-8.781592,115.178774",
      "traceparent": "00-53b7af5a6c19503e7d140691a674e8f3-10c4f1169da13aed-00",
      "x-appengine-appversionid": "s~r01000d12d0e7ffbep-tp/87949dbbbeafd9c44d986f0db73167f6:9.451027157556249921",
      "x-appengine-timeout-ms": "599999",
      "x-appengine-https": "on",
      "x-appengine-user-ip": "202.58.195.69",
      "x-forwarded-for": "202.58.195.69",
      "x-forwarded-proto": "https",
      "forwarded": "for=\"202.58.195.69\";proto=https",
      "accept-encoding": "gzip, deflate, br",
      "x-appengine-request-log-id": "6426a40e00ff0eca1528e10c4d0001737e7230313030306431326430653766666265702d7470000138373934396462626265616664396334346439383666306462373331363766363a390001010f",
      "x-appengine-default-version-hostname": "r01000d12d0e7ffbep-tp.appspot.com",
      "function-execution-id": "4gzkxs0kf9fr",
      "transfer-encoding": "chunked"
    }
  },
  "data": {
    "code": 9,
    "details": "The query requires an index. You can create it here: https://console.firebase.google.com/v1/r/project/common-dev-dea4e/firestore/indexes?create_composite=Ck1wcm9qZWN0cy9jb21tb24tZGV2LWRlYTRlL2RhdGFiYXNlcy8oZGVmYXVsdCkvY29sbGVjdGlvbkdyb3Vwcy9kYW9zL2luZGV4ZXMvXxABGhkKFWRpcmVjdFBhcmVudC5jb21tb25JZBABGggKBG5hbWUQARoMCghfX25hbWVfXxAB",
    "metadata": {}
  }
}

[andreymikhadyuk]

@ariel-dao @danielr18 Any updates on this issue?

[ariel-dao]

@andreymikhadyuk deployed

[andreymikhadyuk]

Got another error during the edit. It says that the name already exists, but that's the name of the project, I didn't change it.
env: dev
project id: 38b9c682-b3e1-4784-a0f6-68bf0d786cd6
payload:

{
  "commonId": "38b9c682-b3e1-4784-a0f6-68bf0d786cd6",
  "changes": {
    "name": "Test space 1",
    "image": "https://firebasestorage.googleapis.com/v0/b/common-dev-dea4e.appspot.com/o/public_img%2Ffile_983c0f10ee7c448b9d33075bb408b8c3.png?alt=media&token=b1e726fa-86ce-4827-9775-46505ea7c94e",
    "byline": "",
    "description": "[{\"type\":\"paragraph\",\"children\":[{\"text\":\"Content\"}]}]",
    "gallery": [],
    "links": []
  }
}

response:

{
  "error": "common name Test space 1 already exists (f53e78cb-02dc-443f-b75c-e7c65f5c6742)",
  "errorName": "Common Error",
  "errorId": "f53e78cb-02dc-443f-b75c-e7c65f5c6742",
  "errorCode": "GenericError",
  "errorMessage": "Something bad happened.",
  "request": {
    "id": "06799751-da28-4197-ba65-980b599fa678",
    "body": {
      "commonId": "38b9c682-b3e1-4784-a0f6-68bf0d786cd6",
      "changes": {
        "name": "Test space 1",
        "image": "https://firebasestorage.googleapis.com/v0/b/common-dev-dea4e.appspot.com/o/public_img%2Ffile_983c0f10ee7c448b9d33075bb408b8c3.png?alt=media&token=b1e726fa-86ce-4827-9775-46505ea7c94e",
        "byline": "",
        "description": "[{\"type\":\"paragraph\",\"children\":[{\"text\":\"Content\"}]}]",
        "gallery": [],
        "links": []
      }
    },
    "query": {},
    "headers": {
      "host": "us-central1-common-dev-dea4e.cloudfunctions.net",
      "sec-ch-ua": "\"Google Chrome\";v=\"111\", \"Not(A:Brand\";v=\"8\", \"Chromium\";v=\"111\"",
      "accept": "application/json, text/plain, */*",
      "content-type": "application/json",
      "sec-ch-ua-mobile": "?0",
      "authorization": "eyJhbGciOiJSUzI1NiIsImtpZCI6Ijg3YzFlN2Y4MDAzNGJiYzgxYjhmMmRiODM3OTIxZjRiZDI4N2YxZGYiLCJ0eXAiOiJKV1QifQ.eyJuYW1lIjoiQW5kcmV5IE1pa2hhZHl1ayIsInBpY3R1cmUiOiIiLCJpc3MiOiJodHRwczovL3NlY3VyZXRva2VuLmdvb2dsZS5jb20vY29tbW9uLWRldi1kZWE0ZSIsImF1ZCI6ImNvbW1vbi1kZXYtZGVhNGUiLCJhdXRoX3RpbWUiOjE2Nzg3NzI1MTcsInVzZXJfaWQiOiJqVHZDcUtGamxWYU5mQU5VUEpxNHY4ZDViSTQzIiwic3ViIjoialR2Q3FLRmpsVmFOZkFOVVBKcTR2OGQ1Ykk0MyIsImlhdCI6MTY4MDU4NDIyOSwiZXhwIjoxNjgwNTg3ODI5LCJlbWFpbCI6ImFuZHJleUBkYW9zdGFjay5pbyIsImVtYWlsX3ZlcmlmaWVkIjp0cnVlLCJmaXJlYmFzZSI6eyJpZGVudGl0aWVzIjp7Imdvb2dsZS5jb20iOlsiMTE4MzA2MjYwMTcwMzc1MjcyNDUwIl0sImVtYWlsIjpbImFuZHJleUBkYW9zdGFjay5pbyJdfSwic2lnbl9pbl9wcm92aWRlciI6Imdvb2dsZS5jb20ifX0.PLVQnJKTiMbh-CSyBaJCWZq3dCFyp0F6m2dgkl2-oq_iqzHNnyYh_J8m-D7y5gAL4RUq-O_hWkj9uZoh1qBELiGhgXSVSqL7ULuxBtlHsIMqlqdyv2WBhb-wZz3005iEDvwLnzR7O9wdndSQyvBCmWnxoDBHoLcUgxDM0UfNezw1nmzcntBmwC58JO-6CqZ25YAWNp3AAxVx6whO78yzS5RClbqM2EWrpPuDzYrol_gZL0UsVbYo76zqGF7zDqg1et3PwsNUHYSySewJlJC1FzF8KNx4YBBpSH9iJpPEYMCj4O-4u0pXBIiHLCsyqAATpRY9nHDPNHwyROdtlvE04A",
      "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36",
      "sec-ch-ua-platform": "\"macOS\"",
      "origin": "https://web-dev.common.io",
      "sec-fetch-site": "cross-site",
      "sec-fetch-mode": "cors",
      "sec-fetch-dest": "empty",
      "referer": "https://web-dev.common.io/",
      "accept-language": "ru-RU,ru;q=0.9,en-US;q=0.8,en;q=0.7",
      "x-cloud-trace-context": "e644d35f52a244216a863a622c5f93c9/17731497630695439830",
      "x-appengine-region": "ba",
      "x-appengine-country": "ID",
      "x-appengine-citylatlong": "-8.781592,115.178774",
      "x-appengine-city": "kuta selatan",
      "traceparent": "00-e644d35f52a244216a863a622c5f93c9-f612ef264d483dd6-00",
      "x-appengine-appversionid": "s~r01000d12d0e7ffbep-tp/87949dbbbeafd9c44d986f0db73167f6:10.451117389470030781",
      "x-appengine-timeout-ms": "599999",
      "x-appengine-https": "on",
      "x-appengine-user-ip": "202.58.195.69",
      "x-forwarded-for": "202.58.195.69",
      "x-forwarded-proto": "https",
      "forwarded": "for=\"202.58.195.69\";proto=https",
      "accept-encoding": "gzip, deflate, br",
      "x-appengine-request-log-id": "642bae2500ff0cb8655af95bbb0001737e7230313030306431326430653766666265702d7470000138373934396462626265616664396334346439383666306462373331363766363a313000010114",
      "x-appengine-default-version-hostname": "r01000d12d0e7ffbep-tp.appspot.com",
      "function-execution-id": "vgv5y0hhpg7x",
      "transfer-encoding": "chunked"
    }
  },
  "data": { "statusCode": 409 }
}

[andreymikhadyuk]

@ariel-dao

[ariel-dao]

@andreymikhadyuk I'm not sure this is a bug. Why are you sending the name of the common if it is not changed?

[andreymikhadyuk]

@ariel-dao I cannot say what is the better approach: to send full form data (even with the fields that were not changed) or only the changed fields. Of course for us it is easier to send the whole form data. But BE can see that the name which is in the DB is of the current common which we are trying to update.