fix - totalDonation decrease order (#776)

orenyodfat · web-flow · commit 4ea11387c3fd · 2020-07-30T17:57:54.000+03:00
* fix - totalDonation decrease order

* more updates

* require acceptance at ragequit

* tests coverage

* remove member accepted

* use infra 21

* solc 0.6.12
diff --git a/.solhint.json b/.solhint.json
@@ -8,6 +8,6 @@
       "two-lines-top-level-separator": "off",
       "mark-callable-contracts": "off",
       "reason-string": "off",
-      "compiler-version": ["error","^0.6.10"]
+      "compiler-version": ["error","^0.6.12"]
     }
   }
diff --git a/buidler.config.js b/buidler.config.js
@@ -124,7 +124,7 @@ module.exports = {
   }
 },
   solc: {
-    version: "0.6.10",    // Fetch exact version from solc-bin (default: truffle's version)
+    version: "0.6.12",    // Fetch exact version from solc-bin (default: truffle's version)
     optimizer: {
       enabled: true,
       runs: 200
diff --git a/contracts/controller/Avatar.sol b/contracts/controller/Avatar.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@daostack/infra-experimental/contracts/Reputation.sol";
diff --git a/contracts/controller/Controller.sol b/contracts/controller/Controller.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "./Avatar.sol";
diff --git a/contracts/controller/DAOToken.sol b/contracts/controller/DAOToken.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@openzeppelin/contracts-ethereum-package/contracts/token/ERC20/ERC20Burnable.sol";
diff --git a/contracts/controller/Vault.sol b/contracts/controller/Vault.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@openzeppelin/contracts-ethereum-package/contracts/access/Ownable.sol";
diff --git a/contracts/globalConstraints/GlobalConstraintInterface.sol b/contracts/globalConstraints/GlobalConstraintInterface.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 // solhint-disable-next-line indent
diff --git a/contracts/globalConstraints/TokenCapGC.sol b/contracts/globalConstraints/TokenCapGC.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@openzeppelin/contracts-ethereum-package/contracts/token/ERC20/IERC20.sol";
diff --git a/contracts/libs/Bytes32ToStr.sol b/contracts/libs/Bytes32ToStr.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 library Bytes32ToStr {
diff --git a/contracts/libs/BytesLib.sol b/contracts/libs/BytesLib.sol
@@ -6,7 +6,7 @@
  *      The library lets you concatenate, slice and type cast bytes arrays both in memory and storage.
  */
 
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 
diff --git a/contracts/libs/StringUtil.sol b/contracts/libs/StringUtil.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 
diff --git a/contracts/misc/CommonToken.sol b/contracts/misc/CommonToken.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@openzeppelin/contracts-ethereum-package/contracts/token/ERC20/ERC20.sol";
diff --git a/contracts/misc/NFTManager.sol b/contracts/misc/NFTManager.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@openzeppelin/contracts-ethereum-package/contracts/token/ERC721/IERC721.sol";
diff --git a/contracts/misc/NectarRepAllocation.sol b/contracts/misc/NectarRepAllocation.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@openzeppelin/contracts-ethereum-package/contracts/math/SafeMath.sol";
diff --git a/contracts/misc/PolkaCurve.sol b/contracts/misc/PolkaCurve.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../schemes/CurveInterface.sol";
diff --git a/contracts/registry/App.sol b/contracts/registry/App.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "./ImplementationProvider.sol";
diff --git a/contracts/registry/ImplementationDirectory.sol b/contracts/registry/ImplementationDirectory.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "./ImplementationProvider.sol";
diff --git a/contracts/registry/ImplementationProvider.sol b/contracts/registry/ImplementationProvider.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 
diff --git a/contracts/registry/Package.sol b/contracts/registry/Package.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@daostack/upgrades/contracts/ownership/Ownable.sol";
diff --git a/contracts/schemes/Agreement.sol b/contracts/schemes/Agreement.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 /**
diff --git a/contracts/schemes/ArcScheme.sol b/contracts/schemes/ArcScheme.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../controller/Avatar.sol";
diff --git a/contracts/schemes/Auction4Reputation.sol b/contracts/schemes/Auction4Reputation.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@openzeppelin/contracts-ethereum-package/contracts/math/SafeMath.sol";
diff --git a/contracts/schemes/CommonInterface.sol b/contracts/schemes/CommonInterface.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 
diff --git a/contracts/schemes/Competition.sol b/contracts/schemes/Competition.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "./ContributionRewardExt.sol";
diff --git a/contracts/schemes/ContinuousLocking4Reputation.sol b/contracts/schemes/ContinuousLocking4Reputation.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@openzeppelin/contracts-ethereum-package/contracts/math/SafeMath.sol";
diff --git a/contracts/schemes/ContributionReward.sol b/contracts/schemes/ContributionReward.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../votingMachines/VotingMachineCallbacks.sol";
diff --git a/contracts/schemes/ContributionRewardExt.sol b/contracts/schemes/ContributionRewardExt.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../votingMachines/VotingMachineCallbacks.sol";
diff --git a/contracts/schemes/ControllerUpgradeScheme.sol b/contracts/schemes/ControllerUpgradeScheme.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@daostack/infra-experimental/contracts/votingMachines/IntVoteInterface.sol";
diff --git a/contracts/schemes/CurveInterface.sol b/contracts/schemes/CurveInterface.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 interface CurveInterface {
diff --git a/contracts/schemes/Dictator.sol b/contracts/schemes/Dictator.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../controller/Avatar.sol";
diff --git a/contracts/schemes/ExternalLocking4Reputation.sol b/contracts/schemes/ExternalLocking4Reputation.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "./Locking4Reputation.sol";
diff --git a/contracts/schemes/FixedReputationAllocation.sol b/contracts/schemes/FixedReputationAllocation.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../controller/Controller.sol";
diff --git a/contracts/schemes/FundingRequest.sol b/contracts/schemes/FundingRequest.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../votingMachines/VotingMachineCallbacks.sol";
diff --git a/contracts/schemes/GenericScheme.sol b/contracts/schemes/GenericScheme.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@daostack/infra-experimental/contracts/votingMachines/IntVoteInterface.sol";
diff --git a/contracts/schemes/GlobalConstraintRegistrar.sol b/contracts/schemes/GlobalConstraintRegistrar.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@daostack/infra-experimental/contracts/votingMachines/IntVoteInterface.sol";
diff --git a/contracts/schemes/JoinAndQuit.sol b/contracts/schemes/JoinAndQuit.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../votingMachines/VotingMachineCallbacks.sol";
@@ -53,9 +53,10 @@ contract JoinAndQuit is
     event ProposalExecuted(address indexed _avatar, bytes32 indexed _proposalId, int256 _decision);
 
     struct Proposal {
-        bool accepted;
         address proposedMember;
         uint256 funding;
+        bool executed;
+        bool accepted;
     }
 
     struct MemberFund {
@@ -124,22 +125,25 @@ contract JoinAndQuit is
     onlyVotingMachine(_proposalId)
     override
     returns(bool) {
-        require(proposals[_proposalId].accepted == false);
-        require(proposals[_proposalId].proposedMember != address(0));
         Proposal memory proposal = proposals[_proposalId];
+        require(proposal.proposedMember != address(0), "not a valid proposal");
+        require(proposal.executed == false, "proposal already been executed");
+        proposals[_proposalId].executed = true;
+
         bool success;
         // Check if vote was successful:
         if ((_decision == 1) && (avatar.nativeReputation().balanceOf(proposal.proposedMember) == 0)) {
             proposals[_proposalId].accepted = true;
+            fundings[proposal.proposedMember].funding = proposal.funding;
+            totalDonation = totalDonation.add(proposal.funding);
             if (fundingToken == IERC20(0)) {
                 // solhint-disable-next-line
                 (success, ) = address(avatar).call{value:proposal.funding}("");
                 require(success, "sendEther to avatar failed");
             } else {
                 fundingToken.safeTransfer(address(avatar), proposal.funding);
             }
-            fundings[proposal.proposedMember].funding = proposal.funding;
-            totalDonation = totalDonation.add(proposal.funding);
+            //this should be called/check after the transfer to the avatar.
             setFundingGoalReachedFlag();
         } else {
             if (fundingToken == IERC20(0)) {
@@ -182,9 +186,10 @@ contract JoinAndQuit is
         bytes32 proposalId = votingMachine.propose(2, voteParamsHash, proposer, address(avatar));
 
         Proposal memory proposal = Proposal({
-            accepted: false,
+            executed: false,
             proposedMember: proposer,
-            funding : _feeAmount
+            funding : _feeAmount,
+            accepted: false
         });
         proposals[proposalId] = proposal;
 
@@ -210,9 +215,9 @@ contract JoinAndQuit is
         Proposal storage proposal = proposals[_proposalId];
         require(proposal.proposedMember != address(0), "no member to redeem");
         require(!fundings[proposal.proposedMember].rageQuit, "member already rageQuit");
+        require(proposal.accepted == true, " proposal not accepted");
         //set proposal proposedMember to zero to prevent reentrancy attack.
         proposal.proposedMember = address(0);
-        require(proposal.accepted == true, " proposal not accepted");
         if (memberReputation == 0) {
             reputation = _proposal.funding;
         } else {
@@ -258,12 +263,12 @@ contract JoinAndQuit is
         } else {
             refundAmount = userDonation.mul(fundingToken.balanceOf(address(avatar))).div(totalDonation);
         }
+        totalDonation = totalDonation.sub(userDonation);
         sendToBeneficiary(refundAmount, msg.sender);
         uint256 msgSenderReputation = avatar.nativeReputation().balanceOf(msg.sender);
         require(
         Controller(
         avatar.owner()).burnReputation(msgSenderReputation, msg.sender));
-        totalDonation = totalDonation.sub(userDonation);
         emit RageQuit(address(avatar), msg.sender, refundAmount);
     }
 
diff --git a/contracts/schemes/Locking4Reputation.sol b/contracts/schemes/Locking4Reputation.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../controller/Controller.sol";
diff --git a/contracts/schemes/LockingEth4Reputation.sol b/contracts/schemes/LockingEth4Reputation.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "./Locking4Reputation.sol";
diff --git a/contracts/schemes/LockingToken4Reputation.sol b/contracts/schemes/LockingToken4Reputation.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "./Locking4Reputation.sol";
diff --git a/contracts/schemes/PriceOracleInterface.sol b/contracts/schemes/PriceOracleInterface.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 interface PriceOracleInterface {
diff --git a/contracts/schemes/ReputationAdmin.sol b/contracts/schemes/ReputationAdmin.sol
@@ -1,4 +1,4 @@
-pragma solidity 0.6.10;
+pragma solidity 0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@openzeppelin/contracts-ethereum-package/contracts/access/Ownable.sol";
diff --git a/contracts/schemes/ReputationFromToken.sol b/contracts/schemes/ReputationFromToken.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../controller/Controller.sol";
diff --git a/contracts/schemes/SchemeFactory.sol b/contracts/schemes/SchemeFactory.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@daostack/infra-experimental/contracts/votingMachines/IntVoteInterface.sol";
diff --git a/contracts/schemes/SchemeRegistrar.sol b/contracts/schemes/SchemeRegistrar.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@daostack/infra-experimental/contracts/votingMachines/VotingMachineCallbacksInterface.sol";
diff --git a/contracts/schemes/SignalScheme.sol b/contracts/schemes/SignalScheme.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@daostack/infra-experimental/contracts/votingMachines/IntVoteInterface.sol";
diff --git a/contracts/schemes/TokenTrade.sol b/contracts/schemes/TokenTrade.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../votingMachines/VotingMachineCallbacks.sol";
diff --git a/contracts/schemes/UpgradeScheme.sol b/contracts/schemes/UpgradeScheme.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@daostack/infra-experimental/contracts/votingMachines/IntVoteInterface.sol";
diff --git a/contracts/schemes/VoteInOrganizationScheme.sol b/contracts/schemes/VoteInOrganizationScheme.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../votingMachines/VotingMachineCallbacks.sol";
diff --git a/contracts/test/ARCDebug.sol b/contracts/test/ARCDebug.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "@daostack/infra-experimental/contracts/votingMachines/GenesisProtocol.sol";
diff --git a/contracts/test/ARCGenesisProtocolCallbacksMock.sol b/contracts/test/ARCGenesisProtocolCallbacksMock.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../votingMachines/VotingMachineCallbacks.sol";
diff --git a/contracts/test/ActionMock.sol b/contracts/test/ActionMock.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../controller/Avatar.sol";
diff --git a/contracts/test/AgreementMock.sol b/contracts/test/AgreementMock.sol
@@ -1,4 +1,4 @@
-pragma solidity ^0.6.10;
+pragma solidity ^0.6.12;
 // SPDX-License-Identifier: GPL-3.0
 
 import "../schemes/Agreement.sol";
diff --git a/contracts/test/ERC20Mock.sol b/contracts/test/ERC20Mock.sol
diff --git a/contracts/test/ERC721Mock.sol b/contracts/test/ERC721Mock.sol
diff --git a/contracts/test/ExternalTokenLockerMock.sol b/contracts/test/ExternalTokenLockerMock.sol
diff --git a/contracts/test/GlobalConstraintMock.sol b/contracts/test/GlobalConstraintMock.sol
diff --git a/contracts/test/IERC721NonReceiverMock.sol b/contracts/test/IERC721NonReceiverMock.sol
diff --git a/contracts/test/IERC721ReceiverMock.sol b/contracts/test/IERC721ReceiverMock.sol
diff --git a/contracts/test/PriceOracleMock.sol b/contracts/test/PriceOracleMock.sol
diff --git a/contracts/test/RewarderMock.sol b/contracts/test/RewarderMock.sol
diff --git a/contracts/test/SchemeMock.sol b/contracts/test/SchemeMock.sol
diff --git a/contracts/test/Wallet.sol b/contracts/test/Wallet.sol
diff --git a/contracts/utils/DAOFactory.sol b/contracts/utils/DAOFactory.sol
diff --git a/contracts/utils/Redeemer.sol b/contracts/utils/Redeemer.sol
diff --git a/contracts/utils/RepAllocation.sol b/contracts/utils/RepAllocation.sol
diff --git a/contracts/votingMachines/VotingMachineCallbacks.sol b/contracts/votingMachines/VotingMachineCallbacks.sol
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
diff --git a/test/joinandquit.js b/test/joinandquit.js
diff --git a/truffle.js b/truffle.js

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,6 @@`
`8`	`8`	`"two-lines-top-level-separator": "off",`
`9`	`9`	`"mark-callable-contracts": "off",`
`10`	`10`	`"reason-string": "off",`
`11`		`- "compiler-version": ["error","^0.6.10"]`
	`11`	`+ "compiler-version": ["error","^0.6.12"]`
`12`	`12`	`}`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ module.exports = {`
`124`	`124`	`}`
`125`	`125`	`},`
`126`	`126`	`solc: {`
`127`		`- version: "0.6.10", // Fetch exact version from solc-bin (default: truffle's version)`
	`127`	`+ version: "0.6.12", // Fetch exact version from solc-bin (default: truffle's version)`
`128`	`128`	`optimizer: {`
`129`	`129`	`enabled: true,`
`130`	`130`	`runs: 200`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-pragma solidity ^0.6.10;`
	`1`	`+pragma solidity ^0.6.12;`
`2`	`2`	`// SPDX-License-Identifier: GPL-3.0`
`3`	`3`
`4`	`4`	`import "@daostack/infra-experimental/contracts/Reputation.sol";`