Skip to content

Commit 012d1bc

Browse files
authored
use InitilzieAdminUpgradabilityProxy (#734)
1 parent 72478fd commit 012d1bc

File tree

4 files changed

+401
-356
lines changed

4 files changed

+401
-356
lines changed

contracts/utils/DAOFactory.sol

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import "@openzeppelin/upgrades/contracts/Initializable.sol";
44
import "@openzeppelin/upgrades/contracts/application/App.sol";
55
import "@openzeppelin/upgrades/contracts/application/ImplementationDirectory.sol";
66
import "@openzeppelin/upgrades/contracts/upgradeability/ProxyAdmin.sol";
7-
import "@openzeppelin/upgrades/contracts/upgradeability/AdminUpgradeabilityProxy.sol";
7+
import "@openzeppelin/upgrades/contracts/upgradeability/InitializableAdminUpgradeabilityProxy.sol";
88
import "solidity-bytes-utils/contracts/BytesLib.sol";
99
import "../controller/Controller.sol";
1010
import "../libs/Bytes32ToStr.sol";
@@ -157,10 +157,11 @@ contract DAOFactory is Initializable {
157157
bytes memory _data)
158158
public
159159
payable
160-
returns (AdminUpgradeabilityProxy) {
160+
returns (InitializableAdminUpgradeabilityProxy) {
161161
uint64[3] memory version = getPackageVersion(_packageVersion);
162162
address implementation = getImplementation(version, _contractName);
163-
AdminUpgradeabilityProxy proxy = (new AdminUpgradeabilityProxy).value(msg.value)(implementation, _admin, _data);
163+
InitializableAdminUpgradeabilityProxy proxy = new InitializableAdminUpgradeabilityProxy();
164+
proxy.initialize(implementation, _admin, _data);
164165
emit ProxyCreated(address(proxy), implementation, _contractName, version);
165166
return proxy;
166167
}
@@ -257,13 +258,13 @@ contract DAOFactory is Initializable {
257258
"_founderlength != _foundersTokenAmount.length");
258259
require(_founders.length == _foundersReputationAmount.length,
259260
"_founderlength != _foundersReputationAmount.length");
260-
AdminUpgradeabilityProxy nativeToken =
261+
InitializableAdminUpgradeabilityProxy nativeToken =
261262
createInstance(packageVersion, "DAOToken", address(this), _tokenInitData);
262-
AdminUpgradeabilityProxy nativeReputation =
263+
InitializableAdminUpgradeabilityProxy nativeReputation =
263264
createInstance(packageVersion, "Reputation", address(this),
264265
abi.encodeWithSignature("initialize(address)", address(this)));
265266

266-
AdminUpgradeabilityProxy avatar = createInstance(packageVersion, "Avatar", address(this),
267+
InitializableAdminUpgradeabilityProxy avatar = createInstance(packageVersion, "Avatar", address(this),
267268
abi.encodeWithSignature(
268269
"initialize(string,address,address,address)",
269270
_orgName,

0 commit comments

Comments
 (0)