Merge pull request #513 from daostack/gh-issue-512

fee.toString instead of fee.toNumber

Author: roienatan

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@daostack/arc.js",
-  "version": "2.0.0-experimental.48",
+  "version": "2.0.0-experimental.49",
   "description": "",
   "keywords": [],
   "main": "dist/lib/index.js",

package.json

@@ -1,4 +1,5 @@
 import BN from 'bn.js'
+import { BigNumber } from 'ethers/utils'
 import { DocumentNode } from 'graphql'
 import gql from 'graphql-tag'
 import {
@@ -154,7 +155,7 @@ export class JoinAndQuit extends ProposalPlugin<
     let opts
     if ((await state).pluginParams.fundingToken === NULL_ADDRESS) {
       // if we have no funding token, we shoudl send the fee as ETH
-      opts = { value: options.fee.toNumber()}
+      opts = { value: new BigNumber(options.fee.toString()) }
     } else  {
       opts = {}
     }

src/plugins/joinAndQuit/plugin.ts

@@ -1,10 +1,10 @@
-
 import {
   Contract,
   ContractReceipt as ITransactionReceipt,
   Event as ITransactionEvent
 } from 'ethers/contract'
 import { TransactionResponse } from 'ethers/providers'
+import { BigNumber } from 'ethers/utils'
 import { Observable, Observer } from 'rxjs'
 import { first, take } from 'rxjs/operators'
 import { Arc, Logger } from '../index'
@@ -15,8 +15,8 @@ export interface ITransaction {
   args: any[]
   opts?: {
     gasLimit?: number
-    gasPrice?: number
-    value?: number
+    gasPrice?: BigNumber
+    value?: BigNumber
     nonce?: number
   }
 }