Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presets Panel: Incorrect Role, "Menu Item," in one of panel's containers #5447

Open
derekjackson-das opened this issue Jan 24, 2025 · 0 comments
Labels
a11y Accessibility

Comments

@derekjackson-das
Copy link
Collaborator

Issue Description

The container that holds the text, Clear all, and Import buttons in the Presets dialog is described programmatically as a menuitem, but it does not have the UI expected of this role. This can confuse screen reader users who rely on the role description to understand what an interactive element will do or how to interact with it.

Derived from #5187 .

WCAG Criteria

1.3.1 Info and Relationships - A

Notes

Remove the role attribute, as this section does not need a role, and remove the tabindex, as it is not an interactive element that needs keyboard focus and does not need to receive focus for itself.

Screenshot or Screen Recording

Screen shot of the dev tools inspector describing the text as a menu item in the accessibility tree.

Relevant Code

<div role="menuitem" class="pointer-none group m-1.5 flex h-8 min-w-[170px] gap-2 rounded px-5 py-2.5 !pr-3 text-sm !opacity-100 focus:ring-0 radix-disabled:pointer-events-none radix-disabled:opacity-50 md:min-w-[240px]" tabindex="-1">
  ...
</div>
@derekjackson-das derekjackson-das added the a11y Accessibility label Jan 24, 2025
@derekjackson-das derekjackson-das changed the title Incorrect Role, "Menu Item," in one of the Presets Panel's containers Presets Panel: Incorrect Role, "Menu Item," in one of panel's containers Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility
Projects
None yet
Development

No branches or pull requests

1 participant