Skip to content

Missing List in the generated code #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huan opened this issue Feb 27, 2021 · 2 comments
Closed

Missing List in the generated code #218

huan opened this issue Feb 27, 2021 · 2 comments

Comments

@huan
Copy link

huan commented Feb 27, 2021

betterproto version: v2.0.0b2

Reproduce steps:

git clone [email protected]:wechaty/grpc.git
cd grpc/python
make install
make generate
cat src/wechaty_grpc/wechaty/__init__.py

We generated the following code:

# ...
from typing import AsyncIterable, AsyncIterator, Iterable, Optional, Union
# ...
    async def contact_phone(
        self, *, contact_id: str = "", phone_list: Optional[List[str]] = None
    ) -> "puppet.ContactPhoneResponse":
# ...

As we can see: there's a List in the code, but there's no List imported from typing.

Link to: wechaty/grpc#120

@huan huan changed the title Missing List in the generating code Missing List in the generated code Feb 27, 2021
@Gobot1234
Copy link
Collaborator

This is a known issue and should be fixed by #183

@huan
Copy link
Author

huan commented Feb 27, 2021

Got it, thank your very much!

Close this issue because it's a duplicated one.

@huan huan closed this as completed Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants