Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect pooled embeds #96

Open
BitPhinix opened this issue Jul 3, 2024 · 1 comment
Open

Incorrect pooled embeds #96

BitPhinix opened this issue Jul 3, 2024 · 1 comment

Comments

@BitPhinix
Copy link

BitPhinix commented Jul 3, 2024

While benchmarking our internal prompt weighting, I noticed that compel's pooled embeddings change with different prompt weighting.

I.e. pooled embeds of test != pooled embeds of (test)0.9. Compel tokenizes and encodes the prompt string, including weighting syntax, for the pooled embeds. This doesn't seem intuitive or expected.

I don't have the bandwidth to create a PR for this, but it should be quite simple to fix.

@bonlime
Copy link

bonlime commented Aug 12, 2024

@BitPhinix why do you think we need to pool the original prompt string? let's say i have a prompt "a girl with (green)0.2 hair" where i want "green" to be very slow, in the pooled prompt I want it to be small as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants